[NFC] Fixes -Wrange-loop-analysis warnings

[Mordante]

Summary

This avoids new warnings due to D68912 adds -Wrange-loop-analysis to -Wall.

It seems my previous build didn't enable all targets so this should really be the last patch of the series.

[merge_guards_bot]

Unit tests: unknown.

clang-tidy: unknown.

clang-format: unknown.

Build artifacts: diff.json, console-log.txt

[rriddle]

MLIR looks fine to me.

[MaskRay]

You can drop changes to lld. I've fixed lld -Wrange-loop-analysis a few days ago in 681b1be774964a804beabfb7c5e3bdab8f979e4a . (Archive::Child c was also deleted).

For mlir, only mlir/lib/Dialect/Linalg/Utils/Utils.cpp:117:8 needs a fix. I've fixed others in eeef50b1fee91dbe993187324003d2665ceae331.

[Mordante]

In D72210#1804355, @MaskRay wrote:

You can drop changes to lld. I've fixed lld -Wrange-loop-analysis a few days ago in 681b1be774964a804beabfb7c5e3bdab8f979e4a . (Archive::Child c was also deleted).

For mlir, only mlir/lib/Dialect/Linalg/Utils/Utils.cpp:117:8 needs a fix. I've fixed others in eeef50b1fee91dbe993187324003d2665ceae331.

Thanks for fixing those!

[Mordante]

Rebased on master. This adds one new fix and removes the ones done by others.

[nicolasvasilache]

LGTM

[MaskRay]

polly/lib/Analysis/ScopGraphPrinter.cpp

181

auto -> BasicBlock

mlir/lib/Dialect/Linalg/Utils/Utils.cpp

 
 template <>
 GenericLoopNestRangeBuilder<
     AffineForOp>::GenericLoopNestRangeBuilder(ArrayRef<ValueHandle *> ivs,
                                               ArrayRef<Value> ranges) {
   SmallVector<ValueHandle, 4> lbs;
   SmallVector<ValueHandle, 4> ubs;
   SmallVector<int64_t, 4> steps;
-  for (const Value range : ranges) {
+  for (Value range : ranges) {
     assert(range.getType() && "expected linalg.range type");
     assert(range.getDefiningOp() && "need operations to extract range parts");
     RangeOp rangeOp = cast<RangeOp>(range.getDefiningOp());
     lbs.emplace_back(ValueHandle(rangeOp.min()));
     ubs.emplace_back(ValueHandle(rangeOp.max()));
     steps.emplace_back(ValueHandle(rangeOp.step()));
   }
   builder = std::make_unique<AffineLoopNestBuilder>(ivs, lbs, ubs, steps);

polly/lib/Analysis/ScopGraphPrinter.cpp

if (SD->isMaxRegionInScop(*R)) {
       O.indent(2 * (depth + 1)) << "color = " << color << "\n";
     }
 
     for (const auto &SubRegion : *R)
       printRegionCluster(SD, SubRegion.get(), O, depth + 1);
 
     RegionInfo *RI = R->getRegionInfo();
 
-    for (const auto &BB : R->blocks())
+    for (BasicBlock *BB : R->blocks())
       if (RI->getRegionFor(BB) == R)
         O.indent(2 * (depth + 1))
             << "Node"
             << static_cast<void *>(RI->getTopLevelRegion()->getBBNode(BB))
             << ";\n";
 
     O.indent(2 * depth) << "}\n";
   }