Page MenuHomePhabricator

arpith-jacob (Arpith Jacob)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 8 2015, 9:32 PM (192 w, 3 d)

Recent Activity

Nov 21 2017

arpith-jacob added inline comments to D14254: [OpenMP] Initial implementation of OpenMP offloading library - libomptarget device RTLs..
Nov 21 2017, 10:57 AM · Unknown Object (Project)
arpith-jacob added inline comments to D14254: [OpenMP] Initial implementation of OpenMP offloading library - libomptarget device RTLs..
Nov 21 2017, 9:57 AM · Unknown Object (Project)

Nov 9 2017

arpith-jacob added a comment to D39822: [NVPTX] Model (some) side effects of warp-synchronous data exchange intrinsics..

I was not sure if the *_sync intrinsics required preventing CSE since these intrinsics capture all state as arguments (lanes in a warp to sync as an argument). However, on Volta, I think different lanes in a warp can execute the intrinsic from different syntactic locations (i.e., different program counters). If true, then we do indeed have to model the data exchanged.

Nov 9 2017, 7:53 AM

Apr 21 2017

arpith-jacob added a comment to D32321: [OpenMP] Optimized default kernel launch parameters in CUDA plugin.

Hi Jonas,

Apr 21 2017, 5:12 PM · Unknown Object (Project)

Feb 16 2017

arpith-jacob added a comment to D30050: Bug 31948: Fix assertion when bitcasting constantexpr pointers.

Thank you for this. LGTM.

Feb 16 2017, 1:14 PM
arpith-jacob updated the diff for D29879: [OpenMP] Teams reduction on the NVPTX device..

Addressed review comments.

Feb 16 2017, 4:58 AM
arpith-jacob added a comment to D29879: [OpenMP] Teams reduction on the NVPTX device..

Alexey, do you any more comments on this patch?

Feb 16 2017, 3:06 AM

Feb 14 2017

arpith-jacob updated the diff for D29910: [OpenMP] Specialize default schedule on a worksharing loop on the NVPTX device..

Hi Alexey,

Feb 14 2017, 1:22 PM
arpith-jacob added a comment to D29879: [OpenMP] Teams reduction on the NVPTX device..

Alexey, thank you for your review. I have used SizeTy instead of assuming 64-bits.

Feb 14 2017, 11:28 AM
arpith-jacob updated the diff for D29879: [OpenMP] Teams reduction on the NVPTX device..

Use SizeTy instead of assuming 64 bits!

Feb 14 2017, 11:25 AM
arpith-jacob added a comment to D29910: [OpenMP] Specialize default schedule on a worksharing loop on the NVPTX device..

Hi Alexey,

Feb 14 2017, 5:00 AM

Feb 13 2017

arpith-jacob created D29910: [OpenMP] Specialize default schedule on a worksharing loop on the NVPTX device..
Feb 13 2017, 1:47 PM

Feb 12 2017

arpith-jacob created D29879: [OpenMP] Teams reduction on the NVPTX device..
Feb 12 2017, 4:29 PM
arpith-jacob abandoned D29506: [OpenMP] Teams reduction on the NVPTX device..
Feb 12 2017, 4:27 PM
arpith-jacob updated the diff for D29758: [OpenMP] Parallel reduction on the NVPTX device..

Minor fixup of comment style on emitInterWarpCopyFunction().

Feb 12 2017, 4:25 PM
arpith-jacob updated the diff for D29758: [OpenMP] Parallel reduction on the NVPTX device..

Updated patch to address Alexey's comments. Condensed parameters in emitReduction() to a struct Options.

Feb 12 2017, 12:58 PM

Feb 10 2017

arpith-jacob added inline comments to D29758: [OpenMP] Parallel reduction on the NVPTX device..
Feb 10 2017, 7:49 AM

Feb 9 2017

arpith-jacob created D29758: [OpenMP] Parallel reduction on the NVPTX device..
Feb 9 2017, 6:48 AM
arpith-jacob added a comment to D29506: [OpenMP] Teams reduction on the NVPTX device..

The patch is too big and quite hard to review? Could you split it into several smaller parts?

Feb 9 2017, 6:42 AM

Feb 3 2017

arpith-jacob added inline comments to D29506: [OpenMP] Teams reduction on the NVPTX device..
Feb 3 2017, 12:00 PM
arpith-jacob created D29506: [OpenMP] Teams reduction on the NVPTX device..
Feb 3 2017, 11:57 AM

Jan 27 2017

arpith-jacob updated the diff for D17657: [NVPTX] Add intrinsics to support named barriers..

Looks like this patch slipped through the cracks :( I've made the requested changes.

Jan 27 2017, 1:05 PM

Jan 25 2017

arpith-jacob created D29143: [OpenMP] Codegen support for 'target teams' on the NVPTX device..
Jan 25 2017, 12:44 PM
arpith-jacob created D29128: [OpenMP] Support for the proc_bind-clause on 'target parallel' on the NVPTX device..
Jan 25 2017, 8:16 AM

Jan 24 2017

arpith-jacob created D29087: [OpenMP] Support for thread_limit-clause on the 'target teams' directive..
Jan 24 2017, 8:55 AM
arpith-jacob created D29085: [OpenMP] Support for num_teams-clause on the 'target teams' directive..
Jan 24 2017, 7:51 AM
arpith-jacob created D29084: [OpenMP] Codegen support for 'target teams' on the host..
Jan 24 2017, 7:11 AM
arpith-jacob created D29083: [OpenMP] Support for the num_threads-clause on 'target parallel' on the NVPTX device..
Jan 24 2017, 6:59 AM
arpith-jacob created D29082: [OpenMP] Support for the num_threads-clause on 'target parallel'..
Jan 24 2017, 6:55 AM

Jan 23 2017

arpith-jacob created D29026: [OpenMP] DSAChecker bug fix for combined directives..
Jan 23 2017, 7:14 AM

Jan 18 2017

arpith-jacob added inline comments to D28753: [OpenMP] Codegen support for 'target parallel' on the host..
Jan 18 2017, 4:50 AM
arpith-jacob updated the diff for D28781: [OpenMP] Support for the if-clause on the combined directive 'target parallel'..

Inherit from OMPLexical scope with an added argument to reduce code duplication.

Jan 18 2017, 3:52 AM

Jan 17 2017

arpith-jacob added a comment to D28781: [OpenMP] Support for the if-clause on the combined directive 'target parallel'..

Another correction. We'll have to create a similar scope OMPTeamsScope that inherits from OMPLexicalScope for target-teams combined directives.

Jan 17 2017, 11:39 AM
arpith-jacob added inline comments to D28781: [OpenMP] Support for the if-clause on the combined directive 'target parallel'..
Jan 17 2017, 11:10 AM
arpith-jacob added inline comments to D28781: [OpenMP] Support for the if-clause on the combined directive 'target parallel'..
Jan 17 2017, 11:08 AM
arpith-jacob updated the diff for D28753: [OpenMP] Codegen support for 'target parallel' on the host..

The patch was updated to split 'emitParallelOrTeamsOutlinedFunction' into 'emitParallelOutlinedFunction' and 'emitTeamsOutlinedFunction' to enable the use of getCapturedStmt().

Jan 17 2017, 9:38 AM
arpith-jacob added inline comments to D28753: [OpenMP] Codegen support for 'target parallel' on the host..
Jan 17 2017, 8:20 AM

Jan 16 2017

arpith-jacob updated the diff for D28753: [OpenMP] Codegen support for 'target parallel' on the host..

Updated 'getOpenMPCaptureRegions' to return the OMPD_teams region kind for the teams directive.

Jan 16 2017, 9:20 PM
arpith-jacob updated the diff for D28753: [OpenMP] Codegen support for 'target parallel' on the host..

Added a method 'getCapturedStmt' as part of OMPExecutableDirective.

Jan 16 2017, 8:47 PM
arpith-jacob created D28781: [OpenMP] Support for the if-clause on the combined directive 'target parallel'..
Jan 16 2017, 2:28 PM
arpith-jacob added a comment to D28752: [OpenMP] Refactor code that calls codegen for target regions on the device..

Thanks Alexey.

Jan 16 2017, 7:35 AM

Jan 15 2017

arpith-jacob added a parent revision for D28755: [OpenMP] Codegen for the 'target parallel' directive on the NVPTX device.: D28753: [OpenMP] Codegen support for 'target parallel' on the host..
Jan 15 2017, 5:26 PM
arpith-jacob added a child revision for D28753: [OpenMP] Codegen support for 'target parallel' on the host.: D28755: [OpenMP] Codegen for the 'target parallel' directive on the NVPTX device..
Jan 15 2017, 5:26 PM
arpith-jacob added a parent revision for D28753: [OpenMP] Codegen support for 'target parallel' on the host.: D28752: [OpenMP] Refactor code that calls codegen for target regions on the device..
Jan 15 2017, 5:25 PM
arpith-jacob added a child revision for D28752: [OpenMP] Refactor code that calls codegen for target regions on the device.: D28753: [OpenMP] Codegen support for 'target parallel' on the host..
Jan 15 2017, 5:25 PM
arpith-jacob retitled D28755: [OpenMP] Codegen for the 'target parallel' directive on the NVPTX device. from to [OpenMP] Codegen for the 'target parallel' directive on the NVPTX device..
Jan 15 2017, 5:24 PM
arpith-jacob retitled D28753: [OpenMP] Codegen support for 'target parallel' on the host. from to [OpenMP] Codegen support for 'target parallel' on the host..
Jan 15 2017, 4:44 PM
arpith-jacob retitled D28752: [OpenMP] Refactor code that calls codegen for target regions on the device. from to [OpenMP] Refactor code that calls codegen for target regions on the device..
Jan 15 2017, 4:41 PM

Jan 9 2017

arpith-jacob updated the diff for D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device..

Use i1 type for bool after all. But this time use the api ConvertType().

Jan 9 2017, 9:33 AM
arpith-jacob updated the diff for D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device..

Using CGF.ConvertTypeForMem(Context.getBoolType()) to get the right type for 'bool' rather than using i1.

Jan 9 2017, 8:23 AM
arpith-jacob added inline comments to D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device..
Jan 9 2017, 4:09 AM
arpith-jacob updated the diff for D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device..

Moved CommonActionTy to CGOpenMPRuntimeNVPTX.cpp and renamed it to NVPTXActionTy, allowing us to customize the class in the future, if necessary.

Jan 9 2017, 4:06 AM

Jan 5 2017

arpith-jacob removed a reviewer for D16460: Bug 10002 - [opencl] Wrongfully assuming RHS is always unsigned: arpith-jacob.
Jan 5 2017, 1:05 AM

Jan 3 2017

arpith-jacob updated the diff for D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device..

Updated patch based on reviews.

Jan 3 2017, 11:47 AM
arpith-jacob added inline comments to D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device..
Jan 3 2017, 10:37 AM

Jan 2 2017

arpith-jacob added inline comments to D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device..
Jan 2 2017, 4:38 AM

Dec 30 2016

arpith-jacob updated the diff for D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device..

Alexey, thank you for your review. I've updated the patch addressing your comments.

Dec 30 2016, 4:47 PM

Dec 29 2016

arpith-jacob added inline comments to D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device..
Dec 29 2016, 2:24 PM
arpith-jacob added a reviewer for D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device.: gtbercea.
Dec 29 2016, 8:35 AM

Dec 28 2016

arpith-jacob added inline comments to D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device..
Dec 28 2016, 3:18 PM
arpith-jacob retitled D28145: [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device. from to [OpenMP] Basic support for a parallel directive in a target region on an NVPTX device..
Dec 28 2016, 3:15 PM
arpith-jacob updated the diff for D28125: [OpenMP] Update target codegen for NVPTX device..

Alexey and Justin, thank you for spending the time to review this patch. I've updated the patch accordingly. I've also removed a dot ('.') from the worker function name since the character is not accepted by the nvidia linker ptxas in function names.

Dec 28 2016, 2:35 PM
arpith-jacob updated the diff for D28124: [OpenMP] Code cleanup for NVPTX OpenMP codegen.

Addressed comments in review to start function names with a lowercase letter and to fix the enum type name along with the enumerator name.

Dec 28 2016, 2:19 PM

Dec 27 2016

arpith-jacob added a parent revision for D28125: [OpenMP] Update target codegen for NVPTX device.: D28124: [OpenMP] Code cleanup for NVPTX OpenMP codegen.
Dec 27 2016, 10:39 AM
arpith-jacob added a child revision for D28124: [OpenMP] Code cleanup for NVPTX OpenMP codegen: D28125: [OpenMP] Update target codegen for NVPTX device..
Dec 27 2016, 10:39 AM
arpith-jacob retitled D28125: [OpenMP] Update target codegen for NVPTX device. from to [OpenMP] Update target codegen for NVPTX device..
Dec 27 2016, 10:38 AM
arpith-jacob retitled D28124: [OpenMP] Code cleanup for NVPTX OpenMP codegen from to [OpenMP] Code cleanup for NVPTX OpenMP codegen.
Dec 27 2016, 8:53 AM

Apr 28 2016

arpith-jacob updated subscribers of D19126: [NVPTX] Improve mangling of illegal PTX characters in global names..
Apr 28 2016, 5:06 PM

Mar 9 2016

arpith-jacob added inline comments to D17877: [OpenMP] Base support for target directive codegen on NVPTX device..
Mar 9 2016, 7:44 PM
arpith-jacob added inline comments to D17877: [OpenMP] Base support for target directive codegen on NVPTX device..
Mar 9 2016, 7:59 AM
arpith-jacob updated the diff for D17877: [OpenMP] Base support for target directive codegen on NVPTX device..

Stylistic changes to address feedback.

Mar 9 2016, 7:56 AM

Mar 4 2016

arpith-jacob added inline comments to D17877: [OpenMP] Base support for target directive codegen on NVPTX device..
Mar 4 2016, 2:02 PM
arpith-jacob updated the diff for D17877: [OpenMP] Base support for target directive codegen on NVPTX device..

Addressed feedback; see inline comments for details.

Mar 4 2016, 1:57 PM
arpith-jacob added a comment to D17890: [OpenMP][NVPTX][CUDA] Adding support for printf for an NVPTX OpenMP device..

Thanks for the quick review! The test cases are the same as the CUDA version so it should be fine.

Mar 4 2016, 10:30 AM
arpith-jacob added a child revision for D17877: [OpenMP] Base support for target directive codegen on NVPTX device.: D17890: [OpenMP][NVPTX][CUDA] Adding support for printf for an NVPTX OpenMP device..
Mar 4 2016, 10:28 AM
arpith-jacob added a parent revision for D17890: [OpenMP][NVPTX][CUDA] Adding support for printf for an NVPTX OpenMP device.: D17877: [OpenMP] Base support for target directive codegen on NVPTX device..
Mar 4 2016, 10:28 AM
arpith-jacob retitled D17890: [OpenMP][NVPTX][CUDA] Adding support for printf for an NVPTX OpenMP device. from to [OpenMP][NVPTX][CUDA] Adding support for printf for an NVPTX OpenMP device..
Mar 4 2016, 8:44 AM

Mar 3 2016

arpith-jacob retitled D17877: [OpenMP] Base support for target directive codegen on NVPTX device. from to [OpenMP] Base support for target directive codegen on NVPTX device..
Mar 3 2016, 7:35 PM
arpith-jacob added a comment to D17738: [NVPTX] Fix function identifiers that are invalid in PTX and a bug fix for the case of name collisions..

The real stable solution I think is for the IR name to be the final
name. No further mangling involved.

Mar 3 2016, 2:01 PM
arpith-jacob added a comment to D17738: [NVPTX] Fix function identifiers that are invalid in PTX and a bug fix for the case of name collisions..

Friendly ping. Rafael, do you have further concerns? Thanks.

Mar 3 2016, 7:13 AM

Feb 29 2016

arpith-jacob added a reviewer for D17738: [NVPTX] Fix function identifiers that are invalid in PTX and a bug fix for the case of name collisions.: jholewinski.
Feb 29 2016, 3:34 PM
arpith-jacob added a comment to D17738: [NVPTX] Fix function identifiers that are invalid in PTX and a bug fix for the case of name collisions..

Wouldn't it be better to error and ask the llvm producer to not create
global values with '@' and '.' when targeting nvptx?

Feb 29 2016, 3:33 PM
arpith-jacob updated the diff for D17738: [NVPTX] Fix function identifiers that are invalid in PTX and a bug fix for the case of name collisions..

Don't dangle pointers :(

Feb 29 2016, 3:25 PM
arpith-jacob retitled D17738: [NVPTX] Fix function identifiers that are invalid in PTX and a bug fix for the case of name collisions. from to [NVPTX] Fix function identifiers that are invalid in PTX and a bug fix for the case of name collisions..
Feb 29 2016, 1:55 PM

Feb 27 2016

arpith-jacob added inline comments to D17657: [NVPTX] Add intrinsics to support named barriers..
Feb 27 2016, 10:03 AM
arpith-jacob updated the diff for D17657: [NVPTX] Add intrinsics to support named barriers..

Added convergent to the barrier intrinsics.

Feb 27 2016, 9:56 AM

Feb 26 2016

arpith-jacob retitled D17657: [NVPTX] Add intrinsics to support named barriers. from to [NVPTX] Add intrinsics to support named barriers..
Feb 26 2016, 2:07 PM

Feb 4 2016

arpith-jacob updated subscribers of D9888: [OPENMP] Driver support for OpenMP offloading.
Feb 4 2016, 6:38 AM

Feb 3 2016

arpith-jacob added a comment to D16759: [OpenMP] Parsing + sema for target parallel for directive..

Alexey, I've made the change in the comments. Thanks very much for your time!

Feb 3 2016, 7:24 AM

Jan 31 2016

arpith-jacob retitled D16759: [OpenMP] Parsing + sema for target parallel for directive. from to [OpenMP] Parsing + sema for target parallel for directive..
Jan 31 2016, 3:28 PM
arpith-jacob retitled D16758: [OpenMP] Prevent nesting of target constructs within target code execution regions. from to [OpenMP] Prevent nesting of target constructs within target code execution regions..
Jan 31 2016, 3:24 PM

Jan 26 2016

arpith-jacob closed D16553: [OpenMP] Parsing + sema for target parallel directive..

Committed revision 258832.

Jan 26 2016, 10:57 AM
arpith-jacob updated subscribers of D15321: [OpenMP 4.0]Parsing and Sema support for 'omp declare target' directive (accelerator support).
Jan 26 2016, 4:19 AM

Jan 25 2016

arpith-jacob retitled D16553: [OpenMP] Parsing + sema for target parallel directive. from to [OpenMP] Parsing + sema for target parallel directive..
Jan 25 2016, 12:43 PM
arpith-jacob added a comment to D16527: [OpenMP] Parsing + sema for defaultmap clause..

Patch fixed.

Jan 25 2016, 12:35 PM
arpith-jacob updated the diff for D16527: [OpenMP] Parsing + sema for defaultmap clause..

Addressed fixes by Alexey Bataev. Thanks.

Jan 25 2016, 5:07 AM

Jan 24 2016

arpith-jacob retitled D16527: [OpenMP] Parsing + sema for defaultmap clause. from to [OpenMP] Parsing + sema for defaultmap clause..
Jan 24 2016, 6:28 PM

Jan 21 2016

arpith-jacob added a comment to D16341: [OpenMP] Check for at least one map clause on target data directive..

Committed revision 258425.

Jan 21 2016, 12:02 PM
arpith-jacob updated the diff for D16401: [OpenMP] Sema for depend clause on target exit data directive..

Added template instantiation test case for all feasible tests.

Jan 21 2016, 7:39 AM
arpith-jacob updated the diff for D16400: [OpenMP] Sema for depend clause on target enter data directive..

Added template instantiation test case for all feasible tests.

Jan 21 2016, 6:22 AM