Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Unit tests: pass. 61172 tests passed, 0 failed and 729 were skipped.
clang-tidy: pass.
clang-format: pass.
Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml
Comment Actions
This is fine with me. This patch doesn't remove the objdump checks are both necessary?
Comment Actions
llvm-readobj -r checks input relocations. llvm-objdump -d checks output disassembly. Both are necessary.
I usually prefer llvm-readelf for other checks, like -S (section table), -s (symbol table) as its output is concise. For -r, the llvm-readobj output looks better.