This is an archive of the discontinued LLVM Phabricator instance.

[ELF][Hexagon][test] Use llvm-readobj to check relocations. NFC
ClosedPublic

Authored by MaskRay on Jan 2 2020, 9:53 AM.

Diff Detail

Event Timeline

MaskRay created this revision.Jan 2 2020, 9:53 AM
Herald added a project: Restricted Project. · View Herald Transcript

Unit tests: pass. 61172 tests passed, 0 failed and 729 were skipped.

clang-tidy: pass.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

sidneym accepted this revision.Jan 2 2020, 10:44 AM

This is fine with me. This patch doesn't remove the objdump checks are both necessary?

This revision is now accepted and ready to land.Jan 2 2020, 10:44 AM

This is fine with me. This patch doesn't remove the objdump checks are both necessary?

llvm-readobj -r checks input relocations. llvm-objdump -d checks output disassembly. Both are necessary.

I usually prefer llvm-readelf for other checks, like -S (section table), -s (symbol table) as its output is concise. For -r, the llvm-readobj output looks better.

This revision was automatically updated to reflect the committed changes.