Page MenuHomePhabricator

[mlir] Update the CallGraph for nested symbol references, and simplify CallableOpInterface
ClosedPublic

Authored by rriddle on Dec 31 2019, 3:46 PM.

Details

Summary

This enables tracking calls that cross symbol table boundaries. It also simplifies some of the implementation details of CallableOpInterface, i.e. there can only be one region within the callable operation.

Depends On D72042

Diff Detail

Event Timeline

rriddle created this revision.Dec 31 2019, 3:46 PM

Unit tests: pass. 61162 tests passed, 0 failed and 728 were skipped.

clang-tidy: fail. Please fix clang-tidy findings.

clang-format: pass.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

jpienaar accepted this revision.Jan 8 2020, 1:54 PM
jpienaar marked an inline comment as done.

LG, thanks

mlir/lib/Analysis/CallGraph.cpp
79

I'm trying to think when that would even happen where we aren't in some weird state, but can't, but also not sure it would be an error state so just skipping seems fine.

This revision is now accepted and ready to land.Jan 8 2020, 1:54 PM
This revision was automatically updated to reflect the committed changes.