The typo has been present since memOpsHaveSameBasePtr was introduced in
r313208.
It caused SIInstrInfo::shouldClusterMemOps to cluster more mem ops than
it was supposed to.
Paths
| Differential D71616
[AMDGPU] Fix typo in SIInstrInfo::memOpsHaveSameBasePtr ClosedPublic Authored by foad on Dec 17 2019, 9:20 AM.
Details Summary The typo has been present since memOpsHaveSameBasePtr was introduced in It caused SIInstrInfo::shouldClusterMemOps to cluster more mem ops than
Diff Detail
Event TimelineComment Actions The change to wait.ll seems unfortunate, because the exp instructions are no longer consecutive at the end of the function (there is an s_waitcnt between them) but I think it was only working by accident before. All the other test case updates seem innocuous to me, at least the non-autogenerated ones. This revision is now accepted and ready to land.Dec 17 2019, 9:29 AM Comment Actions Unit tests: fail. 60979 tests passed, 1 failed and 727 were skipped. failed: lit.lit/shtest-format.py clang-tidy: unknown. clang-format: unknown. Build artifacts: diff.json, CMakeCache.txt, console-log.txt, test-results.xml Closed by commit rG0412f518dcb0: [AMDGPU] Fix typo in SIInstrInfo::memOpsHaveSameBasePtr (authored by foad). · Explain WhyDec 17 2019, 10:55 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 234345 llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
llvm/test/CodeGen/AMDGPU/add.i16.ll
llvm/test/CodeGen/AMDGPU/ctpop.ll
llvm/test/CodeGen/AMDGPU/ctpop16.ll
llvm/test/CodeGen/AMDGPU/fadd.f16.ll
llvm/test/CodeGen/AMDGPU/global_smrd.ll
llvm/test/CodeGen/AMDGPU/idot2.ll
llvm/test/CodeGen/AMDGPU/idot4s.ll
llvm/test/CodeGen/AMDGPU/idot4u.ll
llvm/test/CodeGen/AMDGPU/idot8s.ll
llvm/test/CodeGen/AMDGPU/idot8u.ll
llvm/test/CodeGen/AMDGPU/llvm.maxnum.f16.ll
llvm/test/CodeGen/AMDGPU/llvm.minnum.f16.ll
llvm/test/CodeGen/AMDGPU/madak.ll
llvm/test/CodeGen/AMDGPU/max.i16.ll
llvm/test/CodeGen/AMDGPU/promote-constOffset-to-imm.ll
llvm/test/CodeGen/AMDGPU/sdwa-peephole.ll
llvm/test/CodeGen/AMDGPU/shl_add_ptr.ll
llvm/test/CodeGen/AMDGPU/sub.i16.ll
llvm/test/CodeGen/AMDGPU/sub.v2i16.ll
llvm/test/CodeGen/AMDGPU/trunc-combine.ll
llvm/test/CodeGen/AMDGPU/vector_shuffle.packed.ll
llvm/test/CodeGen/AMDGPU/wait.ll
|