This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Fix typo in SIInstrInfo::memOpsHaveSameBasePtr
ClosedPublic

Authored by foad on Dec 17 2019, 9:20 AM.

Details

Summary

The typo has been present since memOpsHaveSameBasePtr was introduced in
r313208.

It caused SIInstrInfo::shouldClusterMemOps to cluster more mem ops than
it was supposed to.

Diff Detail

Event Timeline

foad created this revision.Dec 17 2019, 9:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 17 2019, 9:20 AM

The change to wait.ll seems unfortunate, because the exp instructions are no longer consecutive at the end of the function (there is an s_waitcnt between them) but I think it was only working by accident before. All the other test case updates seem innocuous to me, at least the non-autogenerated ones.

This revision is now accepted and ready to land.Dec 17 2019, 9:29 AM

Unit tests: fail. 60979 tests passed, 1 failed and 727 were skipped.

failed: lit.lit/shtest-format.py

clang-tidy: unknown.

clang-format: unknown.

Build artifacts: diff.json, CMakeCache.txt, console-log.txt, test-results.xml

This revision was automatically updated to reflect the committed changes.