Page MenuHomePhabricator

[WIP] Draft assembler support for branch alignment
Needs ReviewPublic

Authored by reames on Dec 10 2019, 4:28 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Inspired by discussion on D70157. Please direct all discussion there until direction is agreed on. This isn't worthy of review until we settle on direction and syntax, it's just posted for context.

In particular, this patch is: a) using unsettled syntax which will likely change, b) has no actual implementation, and c) is missing a whole bunch of tests.

The syntax used in this patch is:

.push_align_branch_boundary 5 jcc, fused, call
callq bar
.pop_align_branch_boundary

Diff Detail

Event Timeline

reames created this revision.Dec 10 2019, 4:28 PM
reames edited the summary of this revision. (Show Details)Dec 10 2019, 4:33 PM
reames updated this revision to Diff 233412.Dec 11 2019, 10:48 AM

Rebase after CodePadding removal.

bcain added a subscriber: bcain.Dec 12 2019, 7:21 AM
reames updated this revision to Diff 234430.Dec 17 2019, 5:30 PM
reames edited the summary of this revision. (Show Details)

Update to proposed .push_align_branch_boundary syntax. Note that there's no implementation - as that's in the original patch - this is just round trip serialization.

skan added a reviewer: skan.Dec 18 2019, 4:24 PM
skan removed a reviewer: skan.Jan 16 2020, 6:05 PM
skan added a subscriber: skan.