This is an archive of the discontinued LLVM Phabricator instance.

[ARM][MVE][Intrinsics] Add VQADDQ, VHADDQ, VRHADDQ, VQSUBQ, VHSUBQ, VQDMULHQ, VQRDMULHQ intrinsics.
ClosedPublic

Authored by MarkMurrayARM on Dec 9 2019, 5:03 AM.

Details

Summary

Add VQADDQ, VHADDQ, VRHADDQ, VQSUBQ, VHSUBQ, VQDMULHQ, VQRDMULHQ intrinsics and unit tests.

Diff Detail

Event Timeline

MarkMurrayARM created this revision.Dec 9 2019, 5:03 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptDec 9 2019, 5:03 AM

Fix long lines.

Looks nice and clean. I just think we can come up with a better name than adding a _ on the end of it!

llvm/lib/Target/ARM/ARMInstrMVE.td
1591

Maybe MVE_VQxDMULH_Base or MVE_VQxDMULHInst or something like it

1808

Again, better name please.

Address review comments.

MarkMurrayARM marked 2 inline comments as done.Dec 9 2019, 6:03 AM
dmgreen accepted this revision.Dec 9 2019, 7:56 AM

Thanks. Looks good to me, if no one else has any comments.

This revision is now accepted and ready to land.Dec 9 2019, 7:56 AM

Address review comment delivered out-of-band.

This revision was automatically updated to reflect the committed changes.