Page MenuHomePhabricator

[ARM] Enable TypePromotion by default
ClosedPublic

Authored by samparker on Dec 4 2019, 2:07 AM.

Details

Summary

ARMCodeGenPrepare has already been generalized and renamed to TypePromotion. We've had it enabled and tested downstream for a while, so now enable it by default upstream.

Diff Detail

Event Timeline

samparker created this revision.Dec 4 2019, 2:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 4 2019, 2:07 AM
SjoerdMeijer accepted this revision.Dec 4 2019, 5:29 AM

We've had this enabled by default for almost 1 year downstream now, which is a decent amount of time to shake out some codegen bugs. I agree that flipping the switch now make sense, and hopefully similar non-X86 targets enjoy decent performance improvements too.

This revision is now accepted and ready to land.Dec 4 2019, 5:29 AM
This revision was automatically updated to reflect the committed changes.

@SjoerdMeijer I added some code before committing as an arm codegen test was failing and producing worse code with this patch. The new code checks whether the promotion should be beneficial.