This is an archive of the discontinued LLVM Phabricator instance.

Paths

[UpdateTestChecks] Fix issue on handling backslashes of RUN lines.
ClosedPublic

Authored by qiucf on Dec 3 2019, 12:03 AM.

Reviewers

Summary

Incorrect arguments of rstrip in D70432 won't remove trailing backslashes properly. This patch fixes the problem.

This revision is now accepted and ready to land.Dec 3 2019, 12:29 AM

Sorry I didn't see this revision. I commited the same change in rGc246d6e536c7112019cba6cfc764daeb9088ef29

In D70941#1766519, @arichardson wrote:

Sorry I didn't see this revision. I commited the same change in rGc246d6e536c7112019cba6cfc764daeb9088ef29

Thanks!

Path

Size

llvm/

utils/

UpdateTestChecks/

2 lines

	Show First 20 Lines • Show All 104 Lines • ▼ Show 20 Lines

	def find_run_lines(test, lines):			def find_run_lines(test, lines):
	debug('Scanning for RUN lines in test file:', test)			debug('Scanning for RUN lines in test file:', test)
	raw_lines = [m.group(1)			raw_lines = [m.group(1)
	for m in [RUN_LINE_RE.match(l) for l in lines] if m]			for m in [RUN_LINE_RE.match(l) for l in lines] if m]
	run_lines = [raw_lines[0]] if len(raw_lines) > 0 else []			run_lines = [raw_lines[0]] if len(raw_lines) > 0 else []
	for l in raw_lines[1:]:			for l in raw_lines[1:]:
	if run_lines[-1].endswith('\\'):			if run_lines[-1].endswith('\\'):
	run_lines[-1] = run_lines[-1].rstrip('\\' + ' ' + l)			run_lines[-1] = run_lines[-1].rstrip('\\') + ' ' + l
	else:			else:
	run_lines.append(l)			run_lines.append(l)
	debug('Found {} RUN lines in {}:'.format(len(run_lines), test))			debug('Found {} RUN lines in {}:'.format(len(run_lines), test))
	for l in run_lines:			for l in run_lines:
	debug(' RUN: {}'.format(l))			debug(' RUN: {}'.format(l))
	return run_lines			return run_lines

	def scrub_body(body):			def scrub_body(body):
	▲ Show 20 Lines • Show All 254 Lines • Show Last 20 Lines