Page MenuHomePhabricator

[UpdateTestChecks] Share the code to parse RUN: lines between all scripts
ClosedPublic

Authored by arichardson on Tue, Nov 19, 4:24 AM.

Details

Summary

This commit also introduces a common.debug() function to avoid many
if args.verbose: statements. Depends on D70428.

Diff Detail

Event Timeline

arichardson created this revision.Tue, Nov 19, 4:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Nov 19, 4:24 AM
xbolva00 added a comment.EditedSat, Nov 23, 12:59 PM

I like this patch. Please ensure that everything works (we really need some tests for update scripts :) ).

@MaskRay ?

MaskRay added inline comments.Sat, Nov 23, 1:33 PM
llvm/utils/UpdateTestChecks/common.py
109

Use single quotes '

  • Python2 fixes
  • Address feedback
MaskRay accepted this revision.Mon, Nov 25, 12:51 PM
This revision is now accepted and ready to land.Mon, Nov 25, 12:51 PM
Closed by commit rGd9542db49e90: [UpdateTestChecks] Share the code to parse RUN: lines between all scripts (authored by Alex Richardson <Alexander.Richardson@cl.cam.ac.uk>). · Explain WhyMon, Dec 2, 3:09 AM
This revision was automatically updated to reflect the committed changes.