- User Since
- Apr 29 2020, 8:06 AM (178 w, 1 d)
Fri, Sep 1
Aug 29 2023
Jul 21 2023
Jul 20 2023
Jul 5 2023
Handle lack of git URL, as well as custom additions to the version message.
This patch has already been landed as 6d64faf. This is my first time requesting a post-commit review (since I broke the buildbot and the fix was trivial), so please let me know if I missed something in that process.
Update test cases after rebasing on ToT
Add unnamed global test case
Jul 4 2023
@nikic Are you happy with the current patchset?
Jul 2 2023
Jul 1 2023
Please also add a test of lit itself (see llvm/utils/lit/tests). I think something using --emit-coverage on a test that echoes $LLVM_PROFILE_FILE should be enough.
Jun 27 2023
@nikic Ping :)
Jun 20 2023
Added back regex matchers for anonymous global values
Jun 19 2023
Keep supporting --check-globals without explicit level as meaning '--check-globals all'
Rebase after reformatting with Black, update commit message
Jun 14 2023
@nikic Ping :)
Jun 7 2023
@nikic Did you have a look at the new patch?
May 30 2023
Revert checker behaviour for global variables to check hard-coded identifiers
Remove 'seen' mode
Replace 'transitive' mode with 'smart', where attributes are no longer checked as metadata
Introduce version bump to v3, and make 'smart' mode the default in v3
May 25 2023
May 24 2023
Overhauled how update_cc_tests.py checks globals
May 22 2023
May 4 2023
Apr 26 2023
Apr 25 2023
Apr 14 2023
Add test case emitting !annotation from clang.
Make annotation matching a generic metadata fallback.
Apr 13 2023
I'm not familiar with any upstream ways to trigger !annotations so I unfortunately don't have any test updates to upstream at this time. I'm open to suggestions for adding ways to test the change though.
Mar 14 2023
Feb 21 2023
Nov 30 2022
Nov 14 2022
Add explicit labels to FileCheck checks
Nov 11 2022
Made changes in line with what @fcloutier suggested.
No longer reorders annotations to occur before codegen. Instead EmitTrapCheck checks the function declaration for OptimizeNoneAttr.
Nov 10 2022
May 8 2021
Rebased onto upstream/main
May 7 2021
Forgot to rebase onto upstream... That explains why it went so smoothly!
Rebasing to master
Cool :) This is my first submission, so I don't have commit access. If I understand correctly that means I need someone else to commit it on my behalf, yes?
Apr 23 2021
Fixed formatting issue
Apr 22 2021
Split CHECKs to keep them closer to their relevant functions, and added debug information to disambiguate instructions where relevant.
Apr 20 2021
It should be ready to review again now :)
Removed undefs in test cases.
After a long wait I'm now finally able to work on this again! Please excuse the delay.
Addressed review comments and fixed a crash for non-local variables.
Aug 14 2020
May 7 2020
Updating D79564: [Loop-Vectorize] update test cases to accept new ouput
May 2 2020
Updating D79097: reformatting code according to pre-merge check
Accidentally created an extra revision
Updating D79097: [GVN] Improve analysis for missed optimization remark
[GVN] [Remarks] Trying to push missing file
This is my first time using both Phabricator and Arcanist, so I'm not entirely familiar with the UI and workflow, but I can't seem to find one of the test cases I added in my update. It's supposed to be in llvm/test/Transforms/GVN/opt-remarks-multiple-users.ll, but I can't see it added in the revision. Did I miss something? It's an earlier commit than the new diff I pushed, so I would've thought it would be included as well.
[GVN] Update analysis for optimization remark and add tests