Page MenuHomePhabricator

hnrklssn (Henrik G Olsson)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 29 2020, 8:06 AM (59 w, 1 d)

Recent Activity

May 8 2021

hnrklssn updated the diff for D79097: [GVN] Improve analysis for missed optimization remark.

Ran clang-format

May 8 2021, 5:50 AM · Restricted Project
hnrklssn updated the diff for D79097: [GVN] Improve analysis for missed optimization remark.

Rebased onto upstream/main

May 8 2021, 3:58 AM · Restricted Project

May 7 2021

hnrklssn added a comment to D79097: [GVN] Improve analysis for missed optimization remark.

Forgot to rebase onto upstream... That explains why it went so smoothly!

May 7 2021, 3:15 PM · Restricted Project
hnrklssn updated the diff for D79097: [GVN] Improve analysis for missed optimization remark.

Rebasing to master

May 7 2021, 3:06 PM · Restricted Project
hnrklssn added a comment to D79097: [GVN] Improve analysis for missed optimization remark.

Cool :) This is my first submission, so I don't have commit access. If I understand correctly that means I need someone else to commit it on my behalf, yes?

May 7 2021, 4:20 AM · Restricted Project

Apr 23 2021

hnrklssn updated the diff for D79097: [GVN] Improve analysis for missed optimization remark.

Fixed formatting issue

Apr 23 2021, 12:20 AM · Restricted Project

Apr 22 2021

hnrklssn updated the diff for D79097: [GVN] Improve analysis for missed optimization remark.

Split CHECKs to keep them closer to their relevant functions, and added debug information to disambiguate instructions where relevant.

Apr 22 2021, 2:53 PM · Restricted Project

Apr 20 2021

hnrklssn added a comment to D79097: [GVN] Improve analysis for missed optimization remark.

It should be ready to review again now :)

Apr 20 2021, 10:57 AM · Restricted Project
hnrklssn updated the diff for D79097: [GVN] Improve analysis for missed optimization remark.

Removed undefs in test cases.

Apr 20 2021, 10:55 AM · Restricted Project
hnrklssn added a comment to D79097: [GVN] Improve analysis for missed optimization remark.

After a long wait I'm now finally able to work on this again! Please excuse the delay.

Apr 20 2021, 10:46 AM · Restricted Project
hnrklssn updated the diff for D79097: [GVN] Improve analysis for missed optimization remark.

Addressed review comments and fixed a crash for non-local variables.

Apr 20 2021, 10:42 AM · Restricted Project

Aug 14 2020

hnrklssn added a comment to D79097: [GVN] Improve analysis for missed optimization remark.

@hnrklssn hi, are you panning to get back to this at some point?

Yes, sorry about the delay!
Currently finishing the last bits of the thesis that this work is part of has taken priority, which doesn't leave too much time since I'm now also working full time.
After that's done though I intend to come back and do the cleanup necessary to upstream as much of the work as possible. It's all related to improving optimisation remarks in one way or another. :)

Oh cool, are you planning to publish/publicize this work once it's done?

Aug 14 2020, 11:56 AM · Restricted Project
hnrklssn added a comment to D79097: [GVN] Improve analysis for missed optimization remark.

@hnrklssn hi, are you panning to get back to this at some point?

Aug 14 2020, 11:14 AM · Restricted Project

May 7 2020

hnrklssn updated the diff for D79564: [Loop-Vectorize] Emit more context in remarks for optimization record This extends the reportVectorizationFailure helper function with more information emitted after setExtraArgs. This avoids cluttering the compiler frontend remarks with low....

Updating D79564: [Loop-Vectorize] update test cases to accept new ouput

May 7 2020, 6:45 AM · Restricted Project
hnrklssn created D79564: [Loop-Vectorize] Emit more context in remarks for optimization record This extends the reportVectorizationFailure helper function with more information emitted after setExtraArgs. This avoids cluttering the compiler frontend remarks with low....
May 7 2020, 4:29 AM · Restricted Project

May 2 2020

hnrklssn updated the diff for D79097: [GVN] Improve analysis for missed optimization remark.

Updating D79097: reformatting code according to pre-merge check

May 2 2020, 5:48 AM · Restricted Project
hnrklssn abandoned D79287: [GVN] Find OtherAccess for remark even if no uses are dominating the load.

Accidentally created an extra revision

May 2 2020, 5:47 AM · Restricted Project
hnrklssn updated the diff for D79097: [GVN] Improve analysis for missed optimization remark.

Updating D79097: [GVN] Improve analysis for missed optimization remark

May 2 2020, 4:44 AM · Restricted Project
hnrklssn updated the diff for D79097: [GVN] Improve analysis for missed optimization remark.

[GVN] [Remarks] Trying to push missing file

May 2 2020, 4:44 AM · Restricted Project
hnrklssn added a comment to D79097: [GVN] Improve analysis for missed optimization remark.

This is my first time using both Phabricator and Arcanist, so I'm not entirely familiar with the UI and workflow, but I can't seem to find one of the test cases I added in my update. It's supposed to be in llvm/test/Transforms/GVN/opt-remarks-multiple-users.ll, but I can't see it added in the revision. Did I miss something? It's an earlier commit than the new diff I pushed, so I would've thought it would be included as well.

May 2 2020, 4:12 AM · Restricted Project
hnrklssn updated the diff for D79097: [GVN] Improve analysis for missed optimization remark.

[GVN] Update analysis for optimization remark and add tests

May 2 2020, 3:40 AM · Restricted Project
hnrklssn created D79287: [GVN] Find OtherAccess for remark even if no uses are dominating the load.
May 2 2020, 3:40 AM · Restricted Project

Apr 29 2020

hnrklssn created D79097: [GVN] Improve analysis for missed optimization remark.
Apr 29 2020, 9:06 AM · Restricted Project