Page MenuHomePhabricator

[ARM][MVE][Intrinsics] Add MVE VMUL intrinsics.

Authored by MarkMurrayARM on Nov 21 2019, 10:03 AM.

Diff Detail

Event Timeline

MarkMurrayARM created this revision.Nov 21 2019, 10:03 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptNov 21 2019, 10:03 AM
dmgreen added inline comments.Nov 25 2019, 2:14 AM

I think its worth adding some extra tests types. The way I like to think of it is that if someone went and completely changed the in the future, there should be enough tests for them to tell they didn't miss anything. Even if they are not someone from Arm, that knows a lot about MVE intrinsics.


This I like

Rebase and reupload patches.

simon_tatham added inline comments.Nov 26 2019, 3:25 AM

Yes, I agree that the new names of these instruction ids are better. But if you're changing these names as a side effect of this patch, please add text to the commit message calling out the change.

MarkMurrayARM marked an inline comment as done.Nov 26 2019, 5:28 AM

Respond to review comments.

simon_tatham accepted this revision.Nov 26 2019, 5:45 AM
This revision is now accepted and ready to land.Nov 26 2019, 5:45 AM
This revision was automatically updated to reflect the committed changes.