Page MenuHomePhabricator

[ARM][MVE][Intrinsics] Add MVE VMUL intrinsics.
ClosedPublic

Authored by MarkMurrayARM on Thu, Nov 21, 10:03 AM.

Diff Detail

Event Timeline

MarkMurrayARM created this revision.Thu, Nov 21, 10:03 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptThu, Nov 21, 10:03 AM
dmgreen added inline comments.Mon, Nov 25, 2:14 AM
clang/test/CodeGen/arm-mve-intrinsics/vmulq.c
13

I think its worth adding some extra tests types. The way I like to think of it is that if someone went and completely changed the arm_mve.td in the future, there should be enough tests for them to tell they didn't miss anything. Even if they are not someone from Arm, that knows a lot about MVE intrinsics.

llvm/test/CodeGen/Thumb2/LowOverheadLoops/wlstp.mir
214

This I like

Rebase and reupload patches.

simon_tatham added inline comments.Tue, Nov 26, 3:25 AM
llvm/test/CodeGen/Thumb2/LowOverheadLoops/wlstp.mir
214

Yes, I agree that the new names of these instruction ids are better. But if you're changing these names as a side effect of this patch, please add text to the commit message calling out the change.

MarkMurrayARM marked an inline comment as done.Tue, Nov 26, 5:28 AM

Respond to review comments.

simon_tatham accepted this revision.Tue, Nov 26, 5:45 AM
This revision is now accepted and ready to land.Tue, Nov 26, 5:45 AM
This revision was automatically updated to reflect the committed changes.