This is an archive of the discontinued LLVM Phabricator instance.

Differential D70269

[llvm-objcopy][NFC] Use generated object file in COFF/add-section.test
ClosedPublic

Authored by sdmitriev on Nov 14 2019, 1:12 PM.

Details

Reviewers
jhenderson
MaskRay
mstorsjo
alexander-shaposhnikov
rupprecht
Commits
rG840c891a8c24: [llvm-objcopy][NFC] Use generated object file in COFF/add-section.test
Summary

Updated LIT test from D70205 to use generated object file with extended relocation table.

Diff Detail

Event Timeline

sdmitriev created this revision.Nov 14 2019, 1:12 PM
Herald added a reviewer: alexander-shaposhnikov. · View Herald TranscriptNov 14 2019, 1:12 PM
Herald added a reviewer: rupprecht. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, seiya, abrachet, jakehehrlich. · View Herald Transcript
mstorsjo accepted this revision.Nov 15 2019, 4:23 AM

LGTM

This revision is now accepted and ready to land.Nov 15 2019, 4:23 AM
Closed by commit rG840c891a8c24: [llvm-objcopy][NFC] Use generated object file in COFF/add-section.test (authored by sdmitriev). · Explain WhyNov 15 2019, 8:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-objcopy/
COFF/
Inputs/
19 lines

Diff 229558

llvm/test/tools/llvm-objcopy/COFF/Inputs/x86_64-obj-xrelocs.yaml.gz

  • This binary file was added.

llvm/test/tools/llvm-objcopy/COFF/Inputs/x86_64-xrelocs.obj.gz

  • This binary file was deleted.

llvm/test/tools/llvm-objcopy/COFF/add-section.test

Show All 28 Lines
# CHECK-ADD-EMPTY-NAME-NEXT: IMAGE_SCN_CNT_INITIALIZED_DATA # CHECK-ADD-EMPTY-NAME-NEXT: IMAGE_SCN_CNT_INITIALIZED_DATA
# CHECK-ADD-EMPTY-NAME-NEXT: ] # CHECK-ADD-EMPTY-NAME-NEXT: ]
# CHECK-ADD-EMPTY-NAME: SectionData ( # CHECK-ADD-EMPTY-NAME: SectionData (
# CHECK-ADD-EMPTY-NAME-NEXT: 0000: {{.+}}|DEADBEEF{{.+}}| # CHECK-ADD-EMPTY-NAME-NEXT: 0000: {{.+}}|DEADBEEF{{.+}}|
# CHECK-ADD-EMPTY-NAME-NEXT: ) # CHECK-ADD-EMPTY-NAME-NEXT: )
## Test that llvm-objcopy can add a section to an object with extended ## Test that llvm-objcopy can add a section to an object with extended
## relocations. ## relocations.
# RUN: %python %p/../Inputs/ungzip.py %p/Inputs/x86_64-xrelocs.obj.gz > %t.in.xrelocs.obj # RUN: %python %p/../Inputs/ungzip.py %p/Inputs/x86_64-obj-xrelocs.yaml.gz > %t.xrelocs.yaml
# RUN: llvm-objcopy --add-section=.test.section=%t.sec %t.in.xrelocs.obj %t1.xrelocs.obj # RUN: yaml2obj %t.xrelocs.yaml > %t.xrelocs.obj
# RUN: llvm-objcopy --add-section=.test.section=%t.sec %t.xrelocs.obj %t1.xrelocs.obj
# RUN: llvm-readobj --file-headers --sections --section-data %t1.xrelocs.obj | FileCheck %s --check-prefixes=CHECK-EXTENDED-RELOCS # RUN: llvm-readobj --file-headers --sections --section-data %t1.xrelocs.obj | FileCheck %s --check-prefixes=CHECK-EXTENDED-RELOCS
# CHECK-EXTENDED-RELOCS: SectionCount: 5 # CHECK-EXTENDED-RELOCS: SectionCount: 2
# CHECK-EXTENDED-RELOCS: Name: .data # CHECK-EXTENDED-RELOCS: Name: .data
# CHECK-EXTENDED-RELOCS-NEXT: VirtualSize: # CHECK-EXTENDED-RELOCS: RelocationCount: 65535
# CHECK-EXTENDED-RELOCS-NEXT: VirtualAddress: # CHECK-EXTENDED-RELOCS: Characteristics [
# CHECK-EXTENDED-RELOCS-NEXT: RawDataSize:
# CHECK-EXTENDED-RELOCS-NEXT: PointerToRawData:
# CHECK-EXTENDED-RELOCS-NEXT: PointerToRelocations:
# CHECK-EXTENDED-RELOCS-NEXT: PointerToLineNumbers:
# CHECK-EXTENDED-RELOCS-NEXT: RelocationCount: 65535
# CHECK-EXTENDED-RELOCS-NEXT: LineNumberCount: 0
# CHECK-EXTENDED-RELOCS-NEXT: Characteristics [
# CHECK-EXTENDED-RELOCS-NEXT: IMAGE_SCN_ALIGN_16BYTES # CHECK-EXTENDED-RELOCS-NEXT: IMAGE_SCN_ALIGN_16BYTES
# CHECK-EXTENDED-RELOCS-NEXT: IMAGE_SCN_CNT_INITIALIZED_DATA # CHECK-EXTENDED-RELOCS-NEXT: IMAGE_SCN_CNT_INITIALIZED_DATA
# CHECK-EXTENDED-RELOCS-NEXT: IMAGE_SCN_LNK_NRELOC_OVFL # CHECK-EXTENDED-RELOCS-NEXT: IMAGE_SCN_LNK_NRELOC_OVFL
# CHECK-EXTENDED-RELOCS-NEXT: IMAGE_SCN_MEM_READ # CHECK-EXTENDED-RELOCS-NEXT: IMAGE_SCN_MEM_READ
# CHECK-EXTENDED-RELOCS-NEXT: IMAGE_SCN_MEM_WRITE
# CHECK-EXTENDED-RELOCS-NEXT: ] # CHECK-EXTENDED-RELOCS-NEXT: ]
# CHECK-EXTENDED-RELOCS: Name: .test.section # CHECK-EXTENDED-RELOCS: Name: .test.section
# CHECK-EXTENDED-RELOCS: Characteristics [ # CHECK-EXTENDED-RELOCS: Characteristics [
# CHECK-EXTENDED-RELOCS-NEXT: IMAGE_SCN_ALIGN_1BYTES # CHECK-EXTENDED-RELOCS-NEXT: IMAGE_SCN_ALIGN_1BYTES
# CHECK-EXTENDED-RELOCS-NEXT: IMAGE_SCN_CNT_INITIALIZED_DATA # CHECK-EXTENDED-RELOCS-NEXT: IMAGE_SCN_CNT_INITIALIZED_DATA
# CHECK-EXTENDED-RELOCS-NEXT: ] # CHECK-EXTENDED-RELOCS-NEXT: ]
# CHECK-EXTENDED-RELOCS: SectionData ( # CHECK-EXTENDED-RELOCS: SectionData (
# CHECK-EXTENDED-RELOCS-NEXT: 0000: {{.+}}|DEADBEEF{{.+}}| # CHECK-EXTENDED-RELOCS-NEXT: 0000: {{.+}}|DEADBEEF{{.+}}|
Show All 29 Lines