This is an archive of the discontinued LLVM Phabricator instance.

Performance: Add a set of visited SymbolFiles to other the FindFiles variant.
ClosedPublic

Authored by aprantl on Nov 11 2019, 5:28 PM.

Details

Summary

This is basically the same bug as in r260434 again. SymbolFileDWARF::FindTypes has exponential worst-case when digging through dependency DAG of .pcms because each object file and pcm may depend on an already-visited .pcm, which may again have dependencies. Fixed here by carrying a set of already visited SymbolFiles around.

rdar://problem/56993424

Diff Detail

Event Timeline

aprantl created this revision.Nov 11 2019, 5:28 PM
JDevlieghere accepted this revision.Nov 12 2019, 9:19 AM
This revision is now accepted and ready to land.Nov 12 2019, 9:19 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptNov 12 2019, 9:41 AM