Adding tests check all available CPUs on Mips.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
- I suggest to join both test cases into the single one
- Let's check more then empty stderr in case of success. For example, we can generate an object file, run llvm-readelf -A and check ISA: and ISA Extension: lines. Something like this:
; RUN: llc -mtriple=mips64 -mcpu=mips64r3 -filetype=obj < %s | llvm-readelf -A | FileCheck %s --check-prefix=MIPS64R3 ; MIPS64R3: ISA: MIPS64r3 ; RUN: llc -mtriple=mips64 -mcpu=octeon -filetype=obj < %s | llvm-readelf -A | FileCheck %s --check-prefix=OCTEON ; OCTEON: ISA: MIPS64r2 ; OCTEON: ISA Extension: Cavium Networks Octeon
Comment Actions
Merged and expanded the test.
Do you think the tests from D70018 should also be in the same file or is it fine how it is?
Comment Actions
Thanks for the review. I forgot to mention that I've gotten commit access in meantime so I'll be able to commit future patches.