This is an archive of the discontinued LLVM Phabricator instance.

[mips][test] Add Mips CPU tests
ClosedPublic

Authored by mstojanovic on Nov 8 2019, 10:14 AM.

Details

Summary

Adding tests check all available CPUs on Mips.

Diff Detail

Event Timeline

mstojanovic created this revision.Nov 8 2019, 10:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 8 2019, 10:14 AM
  • I suggest to join both test cases into the single one
  • Let's check more then empty stderr in case of success. For example, we can generate an object file, run llvm-readelf -A and check ISA: and ISA Extension: lines. Something like this:
; RUN: llc -mtriple=mips64 -mcpu=mips64r3 -filetype=obj < %s | llvm-readelf -A | FileCheck %s --check-prefix=MIPS64R3
; MIPS64R3: ISA: MIPS64r3

; RUN: llc -mtriple=mips64 -mcpu=octeon -filetype=obj < %s | llvm-readelf -A | FileCheck %s --check-prefix=OCTEON
; OCTEON: ISA: MIPS64r2
; OCTEON: ISA Extension: Cavium Networks Octeon

Merged and expanded the test.

Do you think the tests from D70018 should also be in the same file or is it fine how it is?

atanasyan accepted this revision.Nov 12 2019, 7:37 AM

Do you think the tests from D70018 should also be in the same file or is it fine how it is?

Both patches now looks good. Thanks. I will commit them today or tomorrow.

This revision is now accepted and ready to land.Nov 12 2019, 7:37 AM
This revision was automatically updated to reflect the committed changes.

Thanks for the review. I forgot to mention that I've gotten commit access in meantime so I'll be able to commit future patches.