This is an archive of the discontinued LLVM Phabricator instance.

Differential D70018

[mips][test] Check if the subtarget can support the requested triple width
ClosedPublic

Authored by mstojanovic on Nov 8 2019, 10:26 AM.

Details

Reviewers
atanasyan
Petar.Avramovic
petarj
Commits
rG068db2ed4d18: [mips] Show an error if 64-bit target triple provided with 32-bit CPU
Summary

When a 64-bit triple is used emit an error if the CPU only supports 32-bit code.

Diff Detail

Event Timeline

mstojanovic created this revision.Nov 8 2019, 10:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 8 2019, 10:26 AM
Herald added subscribers: hiraditya, arichardson, sdardis. · View Herald Transcript
atanasyan added inline comments.Nov 8 2019, 10:13 PM
llvm/test/CodeGen/Mips/cpus-no-mips64.ll
3

If you do not plan to add more "check prefixes" to this test, we can use default prefix CHECK and make RUN lines shorter.

mstojanovic updated this revision to Diff 228891.Nov 12 2019, 7:18 AM
mstojanovic mentioned this in D70017: [mips][test] Add Mips CPU tests.

Shortened the tests.

atanasyan accepted this revision.Nov 12 2019, 7:36 AM

LGTM

This revision is now accepted and ready to land.Nov 12 2019, 7:36 AM
Closed by commit rG068db2ed4d18: [mips] Show an error if 64-bit target triple provided with 32-bit CPU (authored by atanasyan). · Explain WhyNov 13 2019, 2:33 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: jrtc27. · View Herald TranscriptNov 13 2019, 2:33 AM

Revision Contents

PathSize
llvm/
lib/
Target/
Mips/
4 lines
test/
CodeGen/
Mips/
16 lines

Diff 229042

llvm/lib/Target/Mips/MipsSubtarget.cpp

Show First 20 Lines • Show All 250 Lines • ▼ Show 20 Lines if (StackAlignOverride)
stackAlignment = *StackAlignOverride; stackAlignment = *StackAlignOverride;
else if (isABI_N32() || isABI_N64()) else if (isABI_N32() || isABI_N64())
stackAlignment = Align(16); stackAlignment = Align(16);
else { else {
assert(isABI_O32() && "Unknown ABI for stack alignment!"); assert(isABI_O32() && "Unknown ABI for stack alignment!");
stackAlignment = Align(8); stackAlignment = Align(8);
} }
if ((isABI_N32() || isABI_N64()) && !isGP64bit())
report_fatal_error("64-bit code requested on a subtarget that doesn't "
"support it!");
return *this; return *this;
} }
bool MipsSubtarget::useConstantIslands() { bool MipsSubtarget::useConstantIslands() {
LLVM_DEBUG(dbgs() << "use constant islands " << Mips16ConstantIslands LLVM_DEBUG(dbgs() << "use constant islands " << Mips16ConstantIslands
<< "\n"); << "\n");
return Mips16ConstantIslands; return Mips16ConstantIslands;
} }
Show All 25 Lines

llvm/test/CodeGen/Mips/cpus-no-mips64.ll

  • This file was added.
; Check that we reject 64-bit mode on 32-bit only CPUs.
; RUN: not llc < %s -o /dev/null -mtriple=mips64 -mcpu=mips1 2>&1 | FileCheck %s
atanasyanUnsubmitted
Not Done
ReplyInline Actions

If you do not plan to add more "check prefixes" to this test, we can use default prefix CHECK and make RUN lines shorter.

atanasyan: If you do not plan to add more "check prefixes" to this test, we can use default prefix `CHECK`…
; RUN: not llc < %s -o /dev/null -mtriple=mips64 -mcpu=mips2 2>&1 | FileCheck %s
; RUN: not llc < %s -o /dev/null -mtriple=mips64 -mcpu=mips32 2>&1 | FileCheck %s
; RUN: not llc < %s -o /dev/null -mtriple=mips64 -mcpu=mips32r2 2>&1 | FileCheck %s
; RUN: not llc < %s -o /dev/null -mtriple=mips64 -mcpu=mips32r3 2>&1 | FileCheck %s
; RUN: not llc < %s -o /dev/null -mtriple=mips64 -mcpu=mips32r5 2>&1 | FileCheck %s
; RUN: not llc < %s -o /dev/null -mtriple=mips64 -mcpu=mips32r6 2>&1 | FileCheck %s
; CHECK: LLVM ERROR: 64-bit code requested on a subtarget that doesn't support it!
define void @foo() {
ret void
}