Differential D69787

[DebugInfo] Support for DW_OP_implicit_pointer.
Needs ReviewPublic
Actions

Authored by alok on Nov 3 2019, 11:24 PM.

Details

Reviewers

aprantl
probinson
dblaikie
jini.susan.george
SouraVX
labath

Summary

This patch adds support for DW_OP_implicit_pointer.

This will enable debugger to show dereferenced value of optimized out pointer.
It has been validated for SROA, mem2reg and Instruction-combiner optimizations.

This also fixes PR43289

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

alok created this revision.Nov 3 2019, 11:24 PM

Herald added a project: Restricted Project. · View Herald TranscriptNov 3 2019, 11:24 PM

Herald added subscribers: llvm-commits, asbirlea, hiraditya. · View Herald Transcript

Rough first review: This looks like it touches a lot of places. I think it might make more sense as several separate patches - improving salavageDebugINfo and then separate patches for each new call-site (including appropriate test cases showing how each new call site is useful).

This looks very interesting! I agree with David though that it would be nice to split this into smaller parts.

alok mentioned this in D69886: [DebugInfo] Support for DW_OP_implicit_pointer (CodeGen phase).Nov 6 2019, 3:36 AM

jmorse mentioned this in D69809: Wrong debug info generated at -O2 (-O0 is correct).Nov 6 2019, 4:13 AM

alok mentioned this in D69999: [DebugInfo] Support for DW_OP_implicit_pointer (IR Verifier and Bitcode).Nov 8 2019, 2:37 AM

alok added a parent revision: D69886: [DebugInfo] Support for DW_OP_implicit_pointer (CodeGen phase).Nov 8 2019, 2:40 AM

alok removed a parent revision: D69886: [DebugInfo] Support for DW_OP_implicit_pointer (CodeGen phase).Nov 8 2019, 2:42 AM

alok mentioned this in D70260: [DebugInfo] Support for DW_OP_implicit_pointer (salvagDebugInfo improvement)..Nov 14 2019, 11:10 AM

alok mentioned this in D70384: [DebugInfo] Support for DW_OP_implicit_pointer (for SROA optimization).Nov 18 2019, 3:36 AM

alok mentioned this in D70385: [DebugInfo] Support for DW_OP_implicit_pointer (for mem2reg optimization).Nov 18 2019, 3:40 AM

alok mentioned this in D70419: [DebugInfo] Support for DW_OP_implicit_pointer (for InstComb optimization).Nov 18 2019, 8:47 PM

alok mentioned this in D70642: [DebugInfo] Support for DW_OP_implicit_pointer (DW_OP_LLVM_argN).Nov 24 2019, 9:41 AM

alok mentioned this in D70643: [DebugInfo] Support for DW_OP_implicit_pointer (DW_OP_LLVM_implicit_pointer).Nov 24 2019, 9:45 AM

I don't know much about the generation side of debug info in llvm.

alok mentioned this in D72055: [DebugInfo] Support for DW_OP_implicit_pointer (for temp references & dynamic allocations).Jan 1 2020, 10:23 AM

Revision Contents
Changeset List

Path

Size

llvm/

include/

llvm/

CodeGen/

6 lines

MachineInstrBuilder.h

8 lines

5 lines

IR/

DebugInfoMetadata.h

6 lines

17 lines

IntrinsicInst.h

9 lines

9 lines

3 lines

Transforms/

Utils/

21 lines

lib/

CodeGen/

AsmPrinter/

DebugLocEntry.h

21 lines

DwarfCompileUnit.h

22 lines

DwarfCompileUnit.cpp

3 lines

3 lines

69 lines

DwarfExpression.h

5 lines

DwarfExpression.cpp

14 lines

CodeGenPrepare.cpp

2 lines

LiveDebugValues.cpp

2 lines

SelectionDAG/

InstrEmitter.cpp

4 lines

SDNodeDbgValue.h

19 lines

SelectionDAG.cpp

9 lines

SelectionDAGBuilder.cpp

9 lines

SelectionDAGDumper.cpp

5 lines

DebugInfo/

DWARF/

DWARFExpression.cpp

2 lines

IR/

DebugInfoMetadata.cpp

14 lines

Instruction.cpp

205 lines

IntrinsicInst.cpp

3 lines

16 lines

12 lines

5 lines

Transforms/

InstCombine/

InstCombineInternal.h

2 lines

InstructionCombining.cpp

6 lines

Scalar/

2 lines

3 lines

DeadStoreElimination.cpp

2 lines

2 lines

2 lines

2 lines

Reassociate.cpp

11 lines

8 lines

Utils/

CodeExtractor.cpp

2 lines

151 lines

PromoteMemoryToRegister.cpp

8 lines

test/

DebugInfo/

dwarfdump-implicit_pointer_instcomb.c

28 lines

dwarfdump-implicit_pointer_mem2reg.c

67 lines

dwarfdump-implicit_pointer_sroa.c

47 lines

dwarfdump-implicit_pointer_sroa_inline.c

28 lines

unittests/

Transforms/

Utils/

4 lines

Diff 227649

llvm/include/llvm/CodeGen/MachineInstr.h

Loading...

llvm/include/llvm/CodeGen/MachineInstrBuilder.h

Loading...

llvm/include/llvm/CodeGen/SelectionDAG.h

Loading...

llvm/include/llvm/IR/DebugInfoMetadata.h

Loading...

llvm/include/llvm/IR/Instruction.h

Loading...

llvm/include/llvm/IR/IntrinsicInst.h

Loading...

llvm/include/llvm/IR/Module.h

Loading...

llvm/include/llvm/IR/Value.h

Loading...

llvm/include/llvm/Transforms/Utils/Local.h

Loading...

llvm/lib/CodeGen/AsmPrinter/DebugLocEntry.h

Loading...

llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.h

Loading...

llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp

Loading...

llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h

Loading...

llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp

Loading...

llvm/lib/CodeGen/AsmPrinter/DwarfExpression.h

Loading...

llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp

Loading...

llvm/lib/CodeGen/CodeGenPrepare.cpp

Loading...

llvm/lib/CodeGen/LiveDebugValues.cpp

Loading...

llvm/lib/CodeGen/SelectionDAG/InstrEmitter.cpp

Loading...

llvm/lib/CodeGen/SelectionDAG/SDNodeDbgValue.h

Loading...

llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

Loading...

llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

Loading...

llvm/lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp

Loading...

llvm/lib/DebugInfo/DWARF/DWARFExpression.cpp

Loading...

llvm/lib/IR/DebugInfoMetadata.cpp

Loading...

llvm/lib/IR/Instruction.cpp

Loading...

llvm/lib/IR/IntrinsicInst.cpp

Loading...

llvm/lib/IR/Module.cpp

Loading...

llvm/lib/IR/Value.cpp

Loading...

llvm/lib/IR/Verifier.cpp

Loading...

llvm/lib/Transforms/InstCombine/InstCombineInternal.h

Loading...

llvm/lib/Transforms/InstCombine/InstructionCombining.cpp

Loading...

llvm/lib/Transforms/Scalar/BDCE.cpp

Loading...

llvm/lib/Transforms/Scalar/DCE.cpp

Loading...

llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp

Loading...

llvm/lib/Transforms/Scalar/EarlyCSE.cpp

Loading...

llvm/lib/Transforms/Scalar/GVN.cpp

Loading...

llvm/lib/Transforms/Scalar/LICM.cpp

Loading...

llvm/lib/Transforms/Scalar/Reassociate.cpp

Loading...

llvm/lib/Transforms/Scalar/SROA.cpp

Loading...

llvm/lib/Transforms/Utils/CodeExtractor.cpp

Loading...

llvm/lib/Transforms/Utils/Local.cpp

Loading...

llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp

Loading...

llvm/test/DebugInfo/dwarfdump-implicit_pointer_instcomb.c

Loading...

llvm/test/DebugInfo/dwarfdump-implicit_pointer_mem2reg.c

Loading...

llvm/test/DebugInfo/dwarfdump-implicit_pointer_sroa.c

Loading...

llvm/test/DebugInfo/dwarfdump-implicit_pointer_sroa_inline.c

Loading...

llvm/unittests/Transforms/Utils/LocalTest.cpp

Loading...