[compiler-rt] Support more CPUs in LSan Allocator Address Space

[krytarowski]

Summary

Handle more CPU modes of: m68k, hppa, sh3, vax, mips, sparc, ppc, alpha.

These modes are requires for NetBSD (and typically LSan/GCC).

[arichardson]

compiler-rt/lib/lsan/lsan_allocator.h

55

Maybe change this to && !defined(__mips_n32)?
For our CHERI CPU we use n64 but don't have _LP64 defined (since pointers are 128 bits).

[krytarowski]

compiler-rt/lib/lsan/lsan_allocator.h

55

There is also o32. I don't know CHERI specifics and it is not supported today on NetBSD. (And there is no LSan for FreeBSD either).

[arichardson]

compiler-rt/lib/lsan/lsan_allocator.h

55

I actually meant to add this to the change below not this one. Sorry.

However, the MIPS change seems wrong since the initial #if defined(__mips64) condition means the newly added condition never triggers.

73

__mips64 should only be defined for 64-bit architectures and as far as I know n32 is the only ABI with 32-bit pointers. Using the _LP64 macro will force us to make changes.

[krytarowski]

compiler-rt/lib/lsan/lsan_allocator.h

55

@christos what is the proper MIPS combination here?

[christos]

compiler-rt/lib/lsan/lsan_allocator.h

55

I think that all this complex mess of ifdefs is really answering the question "Are pointers 32 bits?" so why don't we switch the ifdef to that (for example: #if \_\_UINTPTR_MAX\_\_ == 0xffffffffU)

PS: h@e markup. How does one make double underscore not become underline?

[krytarowski]

compiler-rt/lib/lsan/lsan_allocator.h

55

So why aarch64 is above and ppc64 below?

[christos]

compiler-rt/lib/lsan/lsan_allocator.h

55

I don't know why aarch64 is in the 32 bit group. I think it should not be. It is the only 64 bit arch there, which looks fishy. Whoever added it should have put a comment there. Perhaps it is in the file commit history.

[krytarowski]

compiler-rt/lib/lsan/lsan_allocator.h

55

CC @sebpop and @fjricci for insight. Could you please comment on this?

[sebpop]

compiler-rt/lib/lsan/lsan_allocator.h

55

aarch64 is currently using the 32 bit allocator because the 64 bit allocator does not work in small VMA spaces, i.e., 39bit or 42bit. https://reviews.llvm.org/D60243 is trying to select the 32 or 64 bit allocators based on a runtime test.

[krytarowski]

compiler-rt/lib/lsan/lsan_allocator.h

55

@sebpop What is the minimal VMA for 64bit allocator? Full 64bit? But x86 as far as I know uses 40bit and 48bit... is it considered large?

compiler-rt/lib/lsan/lsan_allocator.h

 #else
   uptr requested_size : 32;
   uptr padding : 22;
 #endif
   u32 stack_trace_id;
 };
 
 #if defined(__mips64) || defined(__aarch64__) || defined(__i386__) || \
-    defined(__arm__)
+    defined(__arm__) || defined(__m68k__) || defined(__hppa__) ||     \
+    defined(__sh3__) || defined(__vax__) ||                           \
+    (defined(__mips64) && !defined(_LP64)) ||                         \
+    (defined(__sparc__) && !defined(_LP64)) ||                        \
+    (defined(__powerpc__) && !defined(_LP64))
 template <typename AddressSpaceViewTy>
 struct AP32 {
   static const uptr kSpaceBeg = 0;
   static const u64 kSpaceSize = SANITIZER_MMAP_RANGE_SIZE;
   static const uptr kMetadataSize = sizeof(ChunkMetadata);
   typedef __sanitizer::CompactSizeClassMap SizeClassMap;
   static const uptr kRegionSizeLog = 20;
   using AddressSpaceView = AddressSpaceViewTy;
   typedef NoOpMapUnmapCallback MapUnmapCallback;
   static const uptr kFlags = 0;
 };
 template <typename AddressSpaceView>
 using PrimaryAllocatorASVT = SizeClassAllocator32<AP32<AddressSpaceView>>;
 using PrimaryAllocator = PrimaryAllocatorASVT<LocalAddressSpaceView>;
-#elif defined(__x86_64__) || defined(__powerpc64__)
+#elif defined(__x86_64__) || defined(__powerpc64__) || defined(__sparc64__) || \
+    defined(__alpha__) || (defined(__mips64) && defined(_LP64))
 # if defined(__powerpc64__)
 const uptr kAllocatorSpace = 0xa0000000000ULL;
 const uptr kAllocatorSize  = 0x20000000000ULL;  // 2T.
 # else
 const uptr kAllocatorSpace = 0x600000000000ULL;
 const uptr kAllocatorSize  = 0x40000000000ULL;  // 4T.
 # endif
 template <typename AddressSpaceViewTy>