This is an archive of the discontinued LLVM Phabricator instance.

Differential D69699

[clang][driver] Add ProfileData to LLVM_LINK_COMPONENTS
ClosedPublic

Authored by aheejin on Oct 31 2019, 7:51 PM.

Details

Reviewers
vsk
tlively
Commits
rGb9903ec8979f: [clang][driver] Add ProfileData to LLVM_LINK_COMPONENTS
Summary

After D68351 we need this to make builds with -DBUILD_SHARED_LIB=ON
work.

Diff Detail

Event Timeline

aheejin created this revision.Oct 31 2019, 7:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 31 2019, 7:51 PM
Herald added subscribers: cfe-commits, mgorny. · View Herald Transcript
tlively accepted this revision.Oct 31 2019, 7:52 PM

LGTM!

This revision is now accepted and ready to land.Oct 31 2019, 7:52 PM
Harbormaster completed remote builds in B40385: Diff 227389.Oct 31 2019, 7:56 PM
Closed by commit rGb9903ec8979f: [clang][driver] Add ProfileData to LLVM_LINK_COMPONENTS (authored by aheejin). · Explain WhyOct 31 2019, 7:56 PM
This revision was automatically updated to reflect the committed changes.
vsk added a comment.Nov 1 2019, 9:21 AM

Thank you!

Revision Contents

PathSize
clang/
lib/
Driver/
1 line

Diff 227390

clang/lib/Driver/CMakeLists.txt

set(LLVM_LINK_COMPONENTS set(LLVM_LINK_COMPONENTS
BinaryFormat BinaryFormat
Option Option
ProfileData
Support Support
) )
if(WIN32) if(WIN32)
# MSVCToolChain.cpp uses version.dll. # MSVCToolChain.cpp uses version.dll.
set(system_libs version) set(system_libs version)
endif() endif()
▲ Show 20 Lines • Show All 70 Lines • Show Last 20 Lines