Page MenuHomePhabricator

isBuiltinFunc() uses StringRef instead of const char*
ClosedPublic

Authored by gchatelet on Oct 29 2019, 9:34 AM.

Details

Summary

This prevents a bug when passing nullptr, StringRef ctor would call strlen(nullptr).
This should fix 98f3151a7dded8838fafcb5f46e6c8358def96b8 breaking sanitizer-x86_64-linux-bootstrap-msan.

Diff Detail

Event Timeline

gchatelet created this revision.Oct 29 2019, 9:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 29 2019, 9:34 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
gchatelet edited the summary of this revision. (Show Details)Oct 29 2019, 9:35 AM
This revision was not accepted when it landed; it landed in state Needs Review.Oct 29 2019, 9:39 AM
This revision was automatically updated to reflect the committed changes.