This patch removes all the Python 3 compability imports, thus removing
Python 2 support.
Python 2 is no longer maintained since Jan 2020, a year and a half already.
Perhaps it is time to remove Python 2 support in LNT.
Paths
| Differential D69056
[LNT] Remove Python2 support ClosedPublic Authored by thopre on Oct 16 2019, 9:42 AM.
Details Summary This patch removes all the Python 3 compability imports, thus removing Python 2 is no longer maintained since Jan 2020, a year and a half already.
Diff Detail
Event Timelinethopre added a parent revision: D69055: [LNT] Code cleanup: consistently use space after comma.Oct 16 2019, 9:43 AM Comment Actions FWIW, we are still using python2 everywhere. I think the python3 version needs to stew for a bit so we can find any bugs that might have been introduced. Comment Actions
Oh yes absolutely. I don't think tests cover all issues so we'll find more. I'll be using LNT in Python 3 mode as soon as all the patches have landed so hopefully I'll uncover a big portion of those. In terms of timeframe I was thinking end of 2020. While Red Hat will have supported versions with Python 2 for a long time yet I think that's a too long time to wait. Does that sound reasonable? thopre edited parent revisions, added: D69053: [LNT] Switch docker image to Python 3; removed: D69055: [LNT] Code cleanup: consistently use space after comma.Dec 5 2019, 4:13 AM thopre retitled this revision from [LNT] [WIP] Remove Python2 support to [LNT] Remove Python2 support.Sep 3 2021, 2:41 AM Comment Actions Ohh it's happening! This looks good but you've missed the cPerf stuff, https://github.com/llvm/llvm-lnt/blob/f48d431f44610e339d00a33d57564c6029c4ff43/lnt/testing/profile/cPerf.cpp#L827 and lnt/testing/profile/__init__.py Comment Actions
What's Python2 specific in lnt/testing/profile/__init__.py? Comment Actions
The futures import at the top https://github.com/llvm/llvm-lnt/blob/f48d431f44610e339d00a33d57564c6029c4ff43/lnt/testing/profile/__init__.py#L4 Comment Actions
It's already there: https://reviews.llvm.org/D69056#change-H7ZXp1LFQQlR Comment Actions
Oh I had missed it :D Comment Actions Thanks! this looks complete now. I guess the only question is, should we bump up the version number? to make a clear line in the sand? otherwise it's hard to tell people which version supports python 2 (in case they need to run an older one for whatever reason)? or more importantly, tell which one is python 3. Comment Actions
Good point. We are currently in 0.4.2dev0 so perhaps we should tag a 0.4.2 first and then pass to 0.4.3dev0? Comment Actions
Perhaps 0.5 instead? that would give someone wanting to continue Python 2 support for whatever reason a way to continue in the 0.4.x ranges? Comment Actions
Good point, release 0.4.2 and then change version to 0.5.0dev0 on the main branch. If we realize we want to do more releases with Python2 we can create a python2 branch from the release but I think we should not do it preemptively. Thought @cmatthews ? Comment Actions
Ping @cmatthews ? Comment Actions
Yes, let me rebase and see if testsuite is still passing. This revision is now accepted and ready to land.Mar 15 2022, 9:52 AM Closed by commit rLNT0e3a5f745de6: [LNT] Remove Python2 support (authored by thopre). · Explain WhyMar 15 2022, 10:03 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 415484 docs/conf.py
examples/functions.py
examples/run_to_csv.py
lnt/external/stats/pstat.py
lnt/external/stats/stats.py
lnt/formats/PlistFormat2.py
lnt/formats/__init__.py
lnt/lnttool/__init__.py
lnt/lnttool/admin.py
lnt/lnttool/create.py
lnt/lnttool/main.py
lnt/lnttool/viewcomparison.py
lnt/server/db/testsuite.py
lnt/server/db/testsuitedb.py
lnt/server/reporting/dailyreport.py
lnt/server/ui/app.py
lnt/server/ui/filters.py
lnt/server/ui/views.py
lnt/testing/profile/__init__.py
lnt/testing/profile/cPerf.cpp
lnt/testing/profile/perf.py
lnt/testing/profile/profilev1impl.py
lnt/testing/profile/profilev2impl.py
lnt/testing/util/rcs.py
lnt/tests/builtintest.py
lnt/tests/compile.py
lnt/tests/nt.py
lnt/tests/test_suite.py
lnt/util/ImportData.py
lnt/util/ServerUtil.py
lnt/util/stats.py
lnt/util/wsgi_restart.py
setup.py
tests/SharedInputs/FakeCompilers/fakecompiler.py
tests/SharedInputs/create_temp_instance.py
tests/server/db/ImportV4TestSuiteInstance.py
tests/server/db/Migrations.py
tests/server/ui/V4Pages.py
tests/testing/CalltreeDataLoading.py
tests/utils/blast.py
tox.ini
|