Page MenuHomePhabricator

cmatthews (Chris Matthews)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 9 2015, 11:31 AM (362 w, 5 d)

Recent Activity

Tue, May 10

cmatthews committed rLNT58c7f0da8dc8: Typo in docs endpoint (authored by cmatthews).
Typo in docs endpoint
Tue, May 10, 11:59 AM · Restricted Project
cmatthews committed rLNT4d2d1fa1c6c6: Experimental Tableau support (authored by cmatthews).
Experimental Tableau support
Tue, May 10, 11:59 AM · Restricted Project
cmatthews committed rLNTec6ab2becbee: Tox target for runserver (authored by cmatthews).
Tox target for runserver
Tue, May 10, 11:59 AM · Restricted Project

Apr 6 2022

cmatthews accepted D123227: Make the version check PEP440-compliant.

Looks good, with the suggested commit message change.

Apr 6 2022, 12:38 PM · Restricted Project

Mar 29 2022

cmatthews accepted D109577: [LNT] Fixed incorrect orders behavior in case of miss formatted llvm_project_revision.

Wonderful! Thanks

Mar 29 2022, 9:16 AM · Restricted Project, Restricted Project

Mar 25 2022

cmatthews added a comment to D109577: [LNT] Fixed incorrect orders behavior in case of miss formatted llvm_project_revision.

Yep, I normally use hashlib as well.

Mar 25 2022, 2:36 PM · Restricted Project, Restricted Project

Mar 23 2022

cmatthews committed rLNTc19bad0ffd6b: Add type information to fields api (authored by cmatthews).
Add type information to fields api
Mar 23 2022, 4:39 PM · Restricted Project
cmatthews committed rLNT1a9bfb688a5e: Install modular typeshed types for dependent packages (authored by cmatthews).
Install modular typeshed types for dependent packages
Mar 23 2022, 4:39 PM · Restricted Project

Mar 15 2022

cmatthews accepted D121679: Fix flake8 failures.

Looks good. thanks!

Mar 15 2022, 10:06 AM · Restricted Project
cmatthews accepted D69056: [LNT] Remove Python2 support.

LGTM

Mar 15 2022, 9:52 AM · Restricted Project

Mar 14 2022

Herald added a project to D69056: [LNT] Remove Python2 support: Restricted Project.

I think this would be safe to land now. Are you still interested in landing it?

Mar 14 2022, 3:45 PM · Restricted Project

Mar 2 2022

cmatthews requested changes to D109577: [LNT] Fixed incorrect orders behavior in case of miss formatted llvm_project_revision.

Actually, I just realized this has a serious bug. The hash function in python is salted, so results are different between process restarts.

Mar 2 2022, 1:29 PM · Restricted Project, Restricted Project
cmatthews accepted D109577: [LNT] Fixed incorrect orders behavior in case of miss formatted llvm_project_revision.

Yep, this looks good then.

Mar 2 2022, 10:57 AM · Restricted Project, Restricted Project
cmatthews accepted D114770: [LNT] Combine perf data metrics from several files.

LGTM now. Thanks!

Mar 2 2022, 10:03 AM · Restricted Project, Restricted Project
cmatthews accepted D120539: [LNT] Removed `0x` checking for offsets in profile assembly.

Seems fine? LGTM.

Mar 2 2022, 9:58 AM · Restricted Project, Restricted Project

Jan 26 2022

cmatthews accepted D118170: [LNT] Fix the graph page to show multiple metrics for the same test.

LGTM. Thanks!

Jan 26 2022, 10:03 AM · Restricted Project

Dec 7 2021

cmatthews requested changes to D114770: [LNT] Combine perf data metrics from several files.
Dec 7 2021, 11:35 AM · Restricted Project, Restricted Project

Dec 3 2021

cmatthews accepted D111289: [LNT] Refactored the Graph page to use the library plotly instead of jQuery.flot.
Dec 3 2021, 1:01 PM · Restricted Project
cmatthews added a comment to D111289: [LNT] Refactored the Graph page to use the library plotly instead of jQuery.flot.

Wow, v4_graph is complex!

Dec 3 2021, 1:01 PM · Restricted Project
cmatthews added a comment to D111289: [LNT] Refactored the Graph page to use the library plotly instead of jQuery.flot.

Oh yes! I did have to load the page, then do a refresh before the old parts of the patch went away.

Dec 3 2021, 12:37 PM · Restricted Project
cmatthews added a comment to D111289: [LNT] Refactored the Graph page to use the library plotly instead of jQuery.flot.

Can you update this patch now that some of the changes have landed?

Dec 3 2021, 10:03 AM · Restricted Project

Nov 29 2021

cmatthews accepted D114332: Copy lnt_graph.js as lnt_regression.js and use it in v4_new_regressions.html and v4_regression_detail.html.

LGTM

Nov 29 2021, 9:33 AM · Restricted Project
cmatthews accepted D114333: Update graph API to return the original string revision as X values.

LGTM

Nov 29 2021, 9:31 AM · Restricted Project

Nov 17 2021

cmatthews added a comment to D111289: [LNT] Refactored the Graph page to use the library plotly instead of jQuery.flot.

I just made a few comments while skimming this.

Nov 17 2021, 2:04 PM · Restricted Project
cmatthews added a comment to D111289: [LNT] Refactored the Graph page to use the library plotly instead of jQuery.flot.

This still needs to be more targeted.

Nov 17 2021, 1:40 PM · Restricted Project

Nov 15 2021

cmatthews accepted D113646: [lit] NFC: Add missing option descriptions to documentation.

LGTM. Thanks!

Nov 15 2021, 9:50 AM · Restricted Project

Nov 9 2021

cmatthews accepted D113470: Allow setting auth_token at 1st container startup.

LGTM

Nov 9 2021, 1:07 PM

Oct 26 2021

cmatthews added inline comments to D112525: [LNT] Add more information to error messages.
Oct 26 2021, 1:55 PM · Restricted Project
cmatthews accepted D112525: [LNT] Add more information to error messages.

LGTM. Thanks!

Oct 26 2021, 12:04 PM · Restricted Project

Oct 25 2021

cmatthews added a comment to D111289: [LNT] Refactored the Graph page to use the library plotly instead of jQuery.flot.

See the discussion here:

Oct 25 2021, 2:54 PM · Restricted Project
cmatthews accepted D95033: Disable mypy cache.

This SGTM. Can you add a note to revisit in a future version of mypy as well.

Oct 25 2021, 1:51 PM
cmatthews added a comment to D111289: [LNT] Refactored the Graph page to use the library plotly instead of jQuery.flot.

I have gone through these code areas a lot in the past, I am happy to review this.

Oct 25 2021, 12:22 PM · Restricted Project
cmatthews added a comment to D111289: [LNT] Refactored the Graph page to use the library plotly instead of jQuery.flot.

As a start, split the non-patch related changes out. Specifically, at least split the changes in: test_matrix_page.py, test_api.py, the renames, the error message updates in views.py, the refactoring in api.py.

Oct 25 2021, 12:20 PM · Restricted Project

Oct 8 2021

cmatthews accepted D111389: [LNT] Added the ability to disable regressions processing to improve performance.

Great idea! They can be very slow on large DBs to process.

Oct 8 2021, 11:52 AM · Restricted Project

Sep 16 2021

cmatthews added a comment to D109577: [LNT] Fixed incorrect orders behavior in case of miss formatted llvm_project_revision.

One real problem that we are having is that the most common submission format that I know if is the git describe output. We are using that everywhere.

Sep 16 2021, 10:23 AM · Restricted Project, Restricted Project

Sep 13 2021

cmatthews committed rLNT6a3f7bbaa221: Docs pages should not mention SVN anymore (authored by cmatthews).
Docs pages should not mention SVN anymore
Sep 13 2021, 10:44 AM
cmatthews committed rLNT60fdaa9b7f2d: Bump gunicorn version (authored by cmatthews).
Bump gunicorn version
Sep 13 2021, 10:44 AM

Sep 7 2021

cmatthews accepted D109235: Use new plistlib API.

LGTM

Sep 7 2021, 10:23 AM

Sep 1 2021

cmatthews committed rLNT09fd15bdeb22: Use certifi for SSL certificates (authored by cmatthews).
Use certifi for SSL certificates
Sep 1 2021, 11:48 AM

Jul 13 2021

cmatthews committed rLNT99ef19c43d26: Remove python-dateutil as a dependency (authored by cmatthews).
Remove python-dateutil as a dependency
Jul 13 2021, 12:47 PM
cmatthews committed rLNT65b4990a2535: Fix some old urls in docs (authored by cmatthews).
Fix some old urls in docs
Jul 13 2021, 12:47 PM
cmatthews committed rLNT8a6a6197ecaa: Make sure FCs and RI are flushed to the database before title rebuild (authored by cmatthews).
Make sure FCs and RI are flushed to the database before title rebuild
Jul 13 2021, 12:20 PM

Jul 12 2021

cmatthews committed rLNT4bb9f06c9086: Enhance Regression audit log (authored by cmatthews).
Enhance Regression audit log
Jul 12 2021, 5:41 PM
cmatthews committed rLNT11b59eb59718: Fix "column cons.consrc does not exist" (authored by cmatthews).
Fix "column cons.consrc does not exist"
Jul 12 2021, 5:41 PM

Jun 22 2021

cmatthews updated subscribers of D104706: Install missing mypy stubs.

In recent versions of mypy, they have a --install-types flag which can do this automatically.

Jun 22 2021, 9:46 AM

Jan 20 2021

cmatthews accepted D94759: Mirror LLVM's arc config.
Jan 20 2021, 10:02 AM

Jan 14 2021

cmatthews accepted D94722: Fix whitespaces flake8 errors and warnings.
Jan 14 2021, 2:02 PM
cmatthews accepted D94721: Fix multiple import on one line.
Jan 14 2021, 2:02 PM
cmatthews accepted D94723: Fix under and over continuation indentation.
Jan 14 2021, 2:01 PM
cmatthews accepted D94720: Fix non multiple of 4 indentation.
Jan 14 2021, 2:01 PM
cmatthews accepted D94686: Fix all unused imports flake8 warnings.
Jan 14 2021, 12:59 PM
cmatthews accepted D94635: Fix server/ui/V4Pages test.

LGTM

Jan 14 2021, 10:55 AM
cmatthews accepted D94663: Fix use of wrong and undef variable.

LGTM.

Jan 14 2021, 10:53 AM
cmatthews added a comment to D94686: Fix all unused imports flake8 warnings.

Could you put your analysis of why the noqa is needed in the noqa comments, so that it will be easy to understand from looking at the code?

Jan 14 2021, 10:52 AM

Oct 2 2020

cmatthews accepted D87235: Test default compare in global status page.

LGTM. Thanks!

Oct 2 2020, 1:01 PM

Sep 21 2020

cmatthews accepted D88061: [Testsuite] allow a linker to be specified.

LGTM. Thanks!

Sep 21 2020, 6:04 PM

Jul 8 2020

cmatthews accepted D83396: [LNT] Use minimized version of jquery.scrolltofixed.

Good idea. Thanks!

Jul 8 2020, 10:45 AM

Jun 6 2020

cmatthews accepted D81337: Add max-failures option to lit documentation.

Good idea!

Jun 6 2020, 6:08 PM · Restricted Project

May 1 2020

cmatthews accepted D79250: Fix crash in psycopg2 with docker image.
May 1 2020, 6:44 PM
cmatthews accepted D79238: Fix pip install line in Dockerfile.

Thanks, I didn’t have a system to check my changes on!

May 1 2020, 6:44 PM

Apr 30 2020

cmatthews requested changes to D61598: lnt runtest test-suite: add --qemu-user-mode support.

Sure, this is fine. Can you add a test?

Apr 30 2020, 10:41 AM
cmatthews accepted D78632: [LNT] Fix rm-machine error reporting.

Sorry, I was reviewing out of order and approved: D79183 which also has a fix for this. I like the test case though, could you commit the test case?

Apr 30 2020, 10:40 AM
cmatthews accepted D79183: Fix dynamic import of http.client.

Thanks!

Apr 30 2020, 10:40 AM
cmatthews accepted D76308: [LNT] Fix legend color .

Thanks!

Apr 30 2020, 10:40 AM
cmatthews accepted D75891: [LNT] Fix get_sliding_runs of RunInfo.

Good catch! Thanks!

Apr 30 2020, 10:08 AM

Apr 12 2020

cmatthews accepted D77986: [lit] Move llvm-test-suite result codes into llvm/lit.

Lgtm. Thanks!

Apr 12 2020, 8:50 PM · Restricted Project

Feb 14 2020

cmatthews accepted D74593: Fixes a bug in pstat module.
Feb 14 2020, 10:12 AM

Feb 13 2020

cmatthews accepted D74175: Removing SVN download of LIT due to MonoRepo.

LGTM

Feb 13 2020, 1:29 PM · Restricted Project
cmatthews added a comment to D74175: Removing SVN download of LIT due to MonoRepo.

Just to confirm, you are using git+git not git+https?

Feb 13 2020, 10:43 AM · Restricted Project

Feb 7 2020

cmatthews requested changes to D74175: Removing SVN download of LIT due to MonoRepo.

Can you remove the commented out old line. Otherwise, LGTM.

Feb 7 2020, 4:14 PM · Restricted Project
cmatthews added a comment to D74175: Removing SVN download of LIT due to MonoRepo.

In the past there has been rev lock between LNT and LIT, so we try to fetch the most up to date lit we can. The pypi version can be quite out of date.

Feb 7 2020, 3:38 PM · Restricted Project
cmatthews requested changes to D74175: Removing SVN download of LIT due to MonoRepo.

How is the lit requirement no longer needed? This URL does not work, but the we still require lit to be installed for the system to work. I think this needed to be updated to fetch the latest lit from the GitHub repo.

Feb 7 2020, 11:58 AM · Restricted Project

Feb 3 2020

cmatthews accepted D42894: [LNT] Use session saved baseline in run comparison report.

LGTM

Feb 3 2020, 11:39 AM · Restricted Project

Jan 17 2020

cmatthews accepted D72278: [test] On Mac, don't try to use result of sysctl command if calling it failed..

LGMT.

Jan 17 2020, 12:09 PM · Restricted Project

Jan 10 2020

cmatthews accepted D72278: [test] On Mac, don't try to use result of sysctl command if calling it failed..

LGTM. Could you maybe update the message something like warning: calling sysctl failed, defaulting to no fma3

Jan 10 2020, 2:34 PM · Restricted Project

Dec 5 2019

cmatthews added a comment to D68779: [LNT][NFC] Fix global import in function.

I think we need testing on all versions of python we support. I suggest one version on 3 that is recent only. We currently have no python3 users, so maybe just 3.6 and newer?

Dec 5 2019, 10:52 AM

Dec 4 2019

cmatthews accepted D68802: [LNT] Python 3 support: fix writing report to tmp file.
Dec 4 2019, 11:37 AM
cmatthews accepted D68920: [LNT] Python 3 support: specify how to sort dict.
Dec 4 2019, 11:37 AM
cmatthews accepted D68989: [LNT] Python 3 support: don't assume URL params order.

We should probably use the url parser on these, and check them formally. This is okay for now though.

Dec 4 2019, 11:37 AM
cmatthews accepted D69042: [LNT] Python 3 support: define hash for Order class.
Dec 4 2019, 11:37 AM
cmatthews accepted D68987: [LNT] Python 3 support: store color value as int.
Dec 4 2019, 11:37 AM
cmatthews accepted D68988: [LNT] Python 3 support: adapt regex for div by 0 msg.
Dec 4 2019, 11:37 AM
cmatthews accepted D68986: [LNT] Python 3 support: adapt XML parsing with extra entities.
Dec 4 2019, 11:30 AM
cmatthews added a comment to D69053: [LNT] Switch docker image to Python 3.

I don't use Docker. Can someone else review?

Dec 4 2019, 11:28 AM
cmatthews accepted D69055: [LNT] Code cleanup: consistently use space after comma.
Dec 4 2019, 11:28 AM
cmatthews accepted D69054: [LNT] Remove useless import fallback.
Dec 4 2019, 11:28 AM
cmatthews accepted D69052: [LNT] Python 3 support: enable testing for Python 3.
Dec 4 2019, 11:28 AM

Nov 11 2019

cmatthews accepted D67821: [LNT] Python 3 support: use Python 2's division behavior.

Thanks for the comments. LGTM.

Nov 11 2019, 10:13 AM
cmatthews added a comment to D68779: [LNT][NFC] Fix global import in function.

I don't understand why we are not using normal import at the top level here?

Nov 11 2019, 10:13 AM

Oct 16 2019

cmatthews added a comment to D69056: [LNT] Remove Python2 support.

FWIW, we are still using python2 everywhere. I think the python3 version needs to stew for a bit so we can find any bugs that might have been introduced.

Oct 16 2019, 10:00 AM · Restricted Project

Oct 15 2019

cmatthews committed rL374950: Add Chris Matthews.
Add Chris Matthews
Oct 15 2019, 2:42 PM

Oct 9 2019

cmatthews accepted D68220: [LNT] Python 3 support: stable showtests output.

Yeah, that seems fine.

Oct 9 2019, 11:17 AM

Sep 27 2019

cmatthews committed rL373111: Make the short version of --cmake-define -D.
Make the short version of --cmake-define -D
Sep 27 2019, 11:52 AM
cmatthews accepted D67884: [LNT] Sort machines by ID as expected by test case.

Yeah, this LGTM.

Sep 27 2019, 11:19 AM · Restricted Project

Sep 18 2019

cmatthews committed rL372241: Support for codesigning executables on Darwin.
Support for codesigning executables on Darwin
Sep 18 2019, 11:16 AM
cmatthews accepted D65751: [LNT] Add support for v2 fmt in test data library.

Thanks!

Sep 18 2019, 10:40 AM · Restricted Project
cmatthews accepted D65794: [LNT] Add docker containerization files.

Looks good. Thanks!

Sep 18 2019, 10:40 AM · Restricted Project

Sep 13 2019

cmatthews accepted D67534: [LNT] Python 3 support: Minor automatic 2to3 fixups.

LGTM.

Sep 13 2019, 10:51 AM · Restricted Project
cmatthews added inline comments to D67535: [LNT] Python 3 support: Update `<>` and `None` comparisons.
Sep 13 2019, 10:43 AM · Restricted Project
cmatthews accepted D67533: [LNT] Python 3 support: Set up (client) setup requirements.

LGTM.

Sep 13 2019, 10:40 AM · Restricted Project