Page MenuHomePhabricator

cmatthews (Chris Matthews)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 9 2015, 11:31 AM (242 w, 3 h)

Recent Activity

Fri, Jan 17

cmatthews accepted D72278: [test] On Mac, don't try to use result of sysctl command if calling it failed..

LGMT.

Fri, Jan 17, 12:09 PM · Restricted Project

Fri, Jan 10

cmatthews accepted D72278: [test] On Mac, don't try to use result of sysctl command if calling it failed..

LGTM. Could you maybe update the message something like warning: calling sysctl failed, defaulting to no fma3

Fri, Jan 10, 2:34 PM · Restricted Project

Dec 5 2019

cmatthews added a comment to D68779: [LNT][NFC] Fix global import in function.

I think we need testing on all versions of python we support. I suggest one version on 3 that is recent only. We currently have no python3 users, so maybe just 3.6 and newer?

Dec 5 2019, 10:52 AM

Dec 4 2019

cmatthews accepted D68802: [LNT] Python 3 support: fix writing report to tmp file.
Dec 4 2019, 11:37 AM
cmatthews accepted D68920: [LNT] Python 3 support: specify how to sort dict.
Dec 4 2019, 11:37 AM
cmatthews accepted D68989: [LNT] Python 3 support: don't assume URL params order.

We should probably use the url parser on these, and check them formally. This is okay for now though.

Dec 4 2019, 11:37 AM
cmatthews accepted D69042: [LNT] Python 3 support: define hash for Order class.
Dec 4 2019, 11:37 AM
cmatthews accepted D68987: [LNT] Python 3 support: store color value as int.
Dec 4 2019, 11:37 AM
cmatthews accepted D68988: [LNT] Python 3 support: adapt regex for div by 0 msg.
Dec 4 2019, 11:37 AM
cmatthews accepted D68986: [LNT] Python 3 support: adapt XML parsing with extra entities.
Dec 4 2019, 11:30 AM
cmatthews added a comment to D69053: [LNT] Switch docker image to Python 3.

I don't use Docker. Can someone else review?

Dec 4 2019, 11:28 AM
cmatthews accepted D69055: [LNT] Code cleanup: consistently use space after comma.
Dec 4 2019, 11:28 AM
cmatthews accepted D69054: [LNT] Remove useless import fallback.
Dec 4 2019, 11:28 AM
cmatthews accepted D69052: [LNT] Python 3 support: enable testing for Python 3.
Dec 4 2019, 11:28 AM

Nov 11 2019

cmatthews accepted D67821: [LNT] Python 3 support: use Python 2's division behavior.

Thanks for the comments. LGTM.

Nov 11 2019, 10:13 AM
cmatthews added a comment to D68779: [LNT][NFC] Fix global import in function.

I don't understand why we are not using normal import at the top level here?

Nov 11 2019, 10:13 AM

Oct 16 2019

cmatthews added a comment to D69056: [LNT] [WIP] Remove Python2 support.

FWIW, we are still using python2 everywhere. I think the python3 version needs to stew for a bit so we can find any bugs that might have been introduced.

Oct 16 2019, 10:00 AM

Oct 15 2019

cmatthews committed rL374950: Add Chris Matthews.
Add Chris Matthews
Oct 15 2019, 2:42 PM

Oct 9 2019

cmatthews accepted D68220: [LNT] Python 3 support: stable showtests output.

Yeah, that seems fine.

Oct 9 2019, 11:17 AM

Sep 27 2019

cmatthews committed rL373111: Make the short version of --cmake-define -D.
Make the short version of --cmake-define -D
Sep 27 2019, 11:52 AM
cmatthews accepted D67884: [LNT] Sort machines by ID as expected by test case.

Yeah, this LGTM.

Sep 27 2019, 11:19 AM · Restricted Project

Sep 18 2019

cmatthews committed rL372241: Support for codesigning executables on Darwin.
Support for codesigning executables on Darwin
Sep 18 2019, 11:16 AM
cmatthews accepted D65751: [LNT] Add support for v2 fmt in test data library.

Thanks!

Sep 18 2019, 10:40 AM · Restricted Project
cmatthews accepted D65794: [LNT] Add docker containerization files.

Looks good. Thanks!

Sep 18 2019, 10:40 AM · Restricted Project

Sep 13 2019

cmatthews accepted D67534: [LNT] Python 3 support: Minor automatic 2to3 fixups.

LGTM.

Sep 13 2019, 10:51 AM · Restricted Project
cmatthews added inline comments to D67535: [LNT] Python 3 support: Update `<>` and `None` comparisons.
Sep 13 2019, 10:43 AM · Restricted Project
cmatthews accepted D67533: [LNT] Python 3 support: Set up (client) setup requirements.

LGTM.

Sep 13 2019, 10:40 AM · Restricted Project
cmatthews accepted D67532: [LNT] Python 3 support: print statements.

LGTM. Thanks!

Sep 13 2019, 10:33 AM · Restricted Project

Sep 3 2019

cmatthews added inline comments to D65751: [LNT] Add support for v2 fmt in test data library.
Sep 3 2019, 10:58 AM · Restricted Project

Aug 12 2019

cmatthews accepted D65747: [LNT] Add unittests for test data creation library.

LGTM.

Aug 12 2019, 10:58 AM · Restricted Project
cmatthews accepted D65751: [LNT] Add support for v2 fmt in test data library.

Looks good.

Aug 12 2019, 10:58 AM · Restricted Project

Jul 10 2019

cmatthews resigned from D64065: Skip test earlier if metric is not found in compare.py.
Jul 10 2019, 10:54 AM · Restricted Project

Jul 1 2019

cmatthews accepted D64028: [zorg] Add a new build script for use with monorepo.

LGTM, thanks!

Jul 1 2019, 1:31 PM · Restricted Project

Jun 5 2019

cmatthews accepted D61662: in test_suite run_test function, opt and self.opt is same obect.

LGTM. Thanks

Jun 5 2019, 10:59 AM · Restricted Project

Jan 22 2019

cmatthews committed rL351904: This should not have been comitted!.
This should not have been comitted!
Jan 22 2019, 4:19 PM

Jan 7 2019

cmatthews accepted D56133: [LNT] fix ValueError in corner case.

LGTM. Thanks!

Jan 7 2019, 4:14 PM

Dec 20 2018

cmatthews committed rL349791: A few more linter fixups.
A few more linter fixups
Dec 20 2018, 10:29 AM
cmatthews committed rL349790: Some more parts of the tree that are linter clean now.
Some more parts of the tree that are linter clean now
Dec 20 2018, 10:29 AM
cmatthews committed rL349789: Suppress most common linter warnings: we probably will not fix these, and they….
Suppress most common linter warnings: we probably will not fix these, and they…
Dec 20 2018, 10:29 AM
cmatthews committed rL349788: Cleanups suggested by linter.
Cleanups suggested by linter
Dec 20 2018, 10:29 AM
cmatthews committed rL349787: Imports fixups.
Imports fixups
Dec 20 2018, 10:29 AM
cmatthews committed rL349786: Also print stats, so we can see how we are progressing.
Also print stats, so we can see how we are progressing
Dec 20 2018, 10:29 AM
cmatthews committed rL349785: Fix whitespace here too.
Fix whitespace here too
Dec 20 2018, 10:28 AM

Dec 18 2018

cmatthews committed rL349594: Whitespace fixups.
Whitespace fixups
Dec 18 2018, 4:24 PM
cmatthews committed rL349593: Unused import.
Unused import
Dec 18 2018, 4:24 PM
cmatthews committed rL349592: Unused import.
Unused import
Dec 18 2018, 4:24 PM
cmatthews committed rL349591: whitespace fixup, unused import.
whitespace fixup, unused import
Dec 18 2018, 4:24 PM
cmatthews committed rL349590: whitespace fixup.
whitespace fixup
Dec 18 2018, 4:24 PM
cmatthews committed rL349589: fatal was not imported, and fix formatting.
fatal was not imported, and fix formatting
Dec 18 2018, 4:24 PM
cmatthews committed rL349588: Remove another * import, and put back the import that is needed..
Remove another * import, and put back the import that is needed.
Dec 18 2018, 4:14 PM
cmatthews committed rL349587: Help mypy understand this.
Help mypy understand this
Dec 18 2018, 4:14 PM
cmatthews committed rL349586: Get rid of nasty * imports.
Get rid of nasty * imports
Dec 18 2018, 4:13 PM
cmatthews committed rL349584: I think this is unused.
I think this is unused
Dec 18 2018, 3:58 PM
cmatthews committed rL349583: Fixup invalid imports.
Fixup invalid imports
Dec 18 2018, 3:58 PM
cmatthews committed rL349582: Some type annotations to make Mypy happier.
Some type annotations to make Mypy happier
Dec 18 2018, 3:58 PM
cmatthews committed rL349579: Getting server UI tests working in flake8.
Getting server UI tests working in flake8
Dec 18 2018, 3:43 PM
cmatthews committed rL349578: Scaleability improvements: don't expire objects and use better query.
Scaleability improvements: don't expire objects and use better query
Dec 18 2018, 3:43 PM
cmatthews committed rL349577: Add a whitelist of files to keep linter clean.
Add a whitelist of files to keep linter clean
Dec 18 2018, 3:43 PM
cmatthews committed rL349576: Do bulk add to avoid DB round trips.
Do bulk add to avoid DB round trips
Dec 18 2018, 3:43 PM
cmatthews committed rL349575: Prevent detached object errors.
Prevent detached object errors
Dec 18 2018, 3:42 PM
cmatthews committed rL349574: Short circuit regression fix checking.
Short circuit regression fix checking
Dec 18 2018, 3:42 PM

Dec 14 2018

cmatthews committed rL349220: Make sure hooks are not run before they are loaded.
Make sure hooks are not run before they are loaded
Dec 14 2018, 4:38 PM
cmatthews committed rL349219: Make a cache for machine -> order lookup.
Make a cache for machine -> order lookup
Dec 14 2018, 4:38 PM
cmatthews committed rL349218: Register hooks in command line importing.
Register hooks in command line importing
Dec 14 2018, 4:38 PM

Dec 13 2018

cmatthews committed rL349116: whitespace fixups to blast.
whitespace fixups to blast
Dec 13 2018, 4:45 PM
cmatthews committed rL349114: Tox based testing.
Tox based testing
Dec 13 2018, 4:33 PM
cmatthews committed rL349113: pep8 whitespace fixups.
pep8 whitespace fixups
Dec 13 2018, 4:33 PM
cmatthews committed rL349112: Unused import.
Unused import
Dec 13 2018, 4:33 PM
cmatthews committed rL349111: Seems like a lot of E266 in the lit test cases, disable that.
Seems like a lot of E266 in the lit test cases, disable that
Dec 13 2018, 4:33 PM
cmatthews committed rL349110: Use ToT lit.
Use ToT lit
Dec 13 2018, 4:33 PM
cmatthews committed rL349109: Add some project policy for formatting so style tools are more useful.
Add some project policy for formatting so style tools are more useful
Dec 13 2018, 4:33 PM
cmatthews committed rL349108: Unused imports.
Unused imports
Dec 13 2018, 4:33 PM
cmatthews committed rL349107: pep8.
pep8
Dec 13 2018, 4:33 PM
cmatthews committed rL349106: Newest version of psycopg2 seems to work well, and has fixes for tox.
Newest version of psycopg2 seems to work well, and has fixes for tox
Dec 13 2018, 4:33 PM
cmatthews committed rL349105: This was an invalid type annotation.
This was an invalid type annotation
Dec 13 2018, 4:33 PM
cmatthews committed rL349104: Fix test.
Fix test
Dec 13 2018, 4:33 PM
cmatthews committed rL349103: Unused..
Unused.
Dec 13 2018, 4:32 PM
cmatthews committed rL349102: Fix Tuple has not .state.
Fix Tuple has not .state
Dec 13 2018, 4:32 PM
cmatthews committed rL349101: Unused..
Unused.
Dec 13 2018, 4:32 PM
cmatthews committed rL349100: Type annotations for regression code.
Type annotations for regression code
Dec 13 2018, 4:32 PM
cmatthews committed rL349099: This type annotation had grown stale.
This type annotation had grown stale
Dec 13 2018, 4:32 PM
cmatthews committed rL349079: Make timers easier to find in the logs.
Make timers easier to find in the logs
Dec 13 2018, 12:08 PM

Dec 11 2018

cmatthews committed rL348883: Import cleanup.
Import cleanup
Dec 11 2018, 11:01 AM
cmatthews committed rL348882: the sys import was used.
the sys import was used
Dec 11 2018, 11:01 AM
cmatthews committed rL348881: Time new regression creation.
Time new regression creation
Dec 11 2018, 10:53 AM
cmatthews committed rL348880: Preload orders and tests.
Preload orders and tests
Dec 11 2018, 10:53 AM
cmatthews committed rL348878: Logging should be info level if we are verbose.
Logging should be info level if we are verbose
Dec 11 2018, 10:53 AM
cmatthews committed rL348879: Prefer absolute imports, and remove unused import.
Prefer absolute imports, and remove unused import
Dec 11 2018, 10:53 AM
cmatthews committed rL348877: Don't call repr on all timed functions arguments.
Don't call repr on all timed functions arguments
Dec 11 2018, 10:53 AM
cmatthews committed rL348876: Keep a lookup table to avoid querying for FieldChange existence.
Keep a lookup table to avoid querying for FieldChange existence
Dec 11 2018, 10:53 AM

Oct 18 2018

cmatthews accepted D53136: [LNT] Come up with MIN_PERCENTAGE_CHANGE value.

LGTM.

Oct 18 2018, 10:49 AM

Oct 9 2018

cmatthews committed rL344090: Sleep endpoint for diagnosing timeout issues.
Sleep endpoint for diagnosing timeout issues
Oct 9 2018, 3:47 PM

Sep 28 2018

cmatthews committed rL343347: make lit builtins a package.
make lit builtins a package
Sep 28 2018, 10:57 AM

Sep 27 2018

cmatthews accepted D52593: [LNT] Sort fields according to order defined in YAML files..

LGTM.

Sep 27 2018, 2:22 PM
cmatthews accepted D51405: [LNT][RFC] Introduce Latest Runs Report..

I bet some of these report queries are going to be really slow on big databases. But we can fix them up over time if that is the case. LGTM.

Sep 27 2018, 1:32 PM

Sep 4 2018

cmatthews updated subscribers of D51609: [LNT] Enable X-Forwarded-* headers to be accepted..

What are you using for the backend web server?

Sep 4 2018, 12:44 PM
cmatthews requested changes to D51609: [LNT] Enable X-Forwarded-* headers to be accepted..

The docs mention "Do not use this middleware in non-proxy setups for security reasons." I would assume because this allows the client to set the host information. I use this in our setups. I think I apply it in the app launch file that we hand to gunicorn instead of here.

Sep 4 2018, 11:26 AM

Aug 29 2018

cmatthews requested changes to D51405: [LNT][RFC] Introduce Latest Runs Report..

This is a great idea. Thanks for setting it up!

Aug 29 2018, 10:53 AM
cmatthews added inline comments to D51405: [LNT][RFC] Introduce Latest Runs Report..
Aug 29 2018, 10:52 AM
cmatthews added a comment to D51405: [LNT][RFC] Introduce Latest Runs Report..

Testcases?

Aug 29 2018, 10:46 AM