Page MenuHomePhabricator

cmatthews (Chris Matthews)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 9 2015, 11:31 AM (214 w, 7 h)

Recent Activity

Wed, Jul 10

cmatthews resigned from D64065: Skip test earlier if metric is not found in compare.py.
Wed, Jul 10, 10:54 AM · Restricted Project

Mon, Jul 1

cmatthews accepted D64028: [zorg] Add a new build script for use with monorepo.

LGTM, thanks!

Mon, Jul 1, 1:31 PM · Restricted Project

Jun 5 2019

cmatthews accepted D61662: in test_suite run_test function, opt and self.opt is same obect.

LGTM. Thanks

Jun 5 2019, 10:59 AM · Restricted Project

Jan 22 2019

cmatthews committed rL351904: This should not have been comitted!.
This should not have been comitted!
Jan 22 2019, 4:19 PM

Jan 7 2019

cmatthews accepted D56133: [LNT] fix ValueError in corner case.

LGTM. Thanks!

Jan 7 2019, 4:14 PM

Dec 20 2018

cmatthews committed rL349791: A few more linter fixups.
A few more linter fixups
Dec 20 2018, 10:29 AM
cmatthews committed rL349790: Some more parts of the tree that are linter clean now.
Some more parts of the tree that are linter clean now
Dec 20 2018, 10:29 AM
cmatthews committed rL349789: Suppress most common linter warnings: we probably will not fix these, and they….
Suppress most common linter warnings: we probably will not fix these, and they…
Dec 20 2018, 10:29 AM
cmatthews committed rL349788: Cleanups suggested by linter.
Cleanups suggested by linter
Dec 20 2018, 10:29 AM
cmatthews committed rL349787: Imports fixups.
Imports fixups
Dec 20 2018, 10:29 AM
cmatthews committed rL349786: Also print stats, so we can see how we are progressing.
Also print stats, so we can see how we are progressing
Dec 20 2018, 10:29 AM
cmatthews committed rL349785: Fix whitespace here too.
Fix whitespace here too
Dec 20 2018, 10:28 AM

Dec 18 2018

cmatthews committed rL349594: Whitespace fixups.
Whitespace fixups
Dec 18 2018, 4:24 PM
cmatthews committed rL349593: Unused import.
Unused import
Dec 18 2018, 4:24 PM
cmatthews committed rL349592: Unused import.
Unused import
Dec 18 2018, 4:24 PM
cmatthews committed rL349591: whitespace fixup, unused import.
whitespace fixup, unused import
Dec 18 2018, 4:24 PM
cmatthews committed rL349590: whitespace fixup.
whitespace fixup
Dec 18 2018, 4:24 PM
cmatthews committed rL349589: fatal was not imported, and fix formatting.
fatal was not imported, and fix formatting
Dec 18 2018, 4:24 PM
cmatthews committed rL349588: Remove another * import, and put back the import that is needed..
Remove another * import, and put back the import that is needed.
Dec 18 2018, 4:14 PM
cmatthews committed rL349587: Help mypy understand this.
Help mypy understand this
Dec 18 2018, 4:14 PM
cmatthews committed rL349586: Get rid of nasty * imports.
Get rid of nasty * imports
Dec 18 2018, 4:13 PM
cmatthews committed rL349584: I think this is unused.
I think this is unused
Dec 18 2018, 3:58 PM
cmatthews committed rL349583: Fixup invalid imports.
Fixup invalid imports
Dec 18 2018, 3:58 PM
cmatthews committed rL349582: Some type annotations to make Mypy happier.
Some type annotations to make Mypy happier
Dec 18 2018, 3:58 PM
cmatthews committed rL349579: Getting server UI tests working in flake8.
Getting server UI tests working in flake8
Dec 18 2018, 3:43 PM
cmatthews committed rL349578: Scaleability improvements: don't expire objects and use better query.
Scaleability improvements: don't expire objects and use better query
Dec 18 2018, 3:43 PM
cmatthews committed rL349577: Add a whitelist of files to keep linter clean.
Add a whitelist of files to keep linter clean
Dec 18 2018, 3:43 PM
cmatthews committed rL349576: Do bulk add to avoid DB round trips.
Do bulk add to avoid DB round trips
Dec 18 2018, 3:43 PM
cmatthews committed rL349575: Prevent detached object errors.
Prevent detached object errors
Dec 18 2018, 3:42 PM
cmatthews committed rL349574: Short circuit regression fix checking.
Short circuit regression fix checking
Dec 18 2018, 3:42 PM

Dec 14 2018

cmatthews committed rL349220: Make sure hooks are not run before they are loaded.
Make sure hooks are not run before they are loaded
Dec 14 2018, 4:38 PM
cmatthews committed rL349219: Make a cache for machine -> order lookup.
Make a cache for machine -> order lookup
Dec 14 2018, 4:38 PM
cmatthews committed rL349218: Register hooks in command line importing.
Register hooks in command line importing
Dec 14 2018, 4:38 PM

Dec 13 2018

cmatthews committed rL349116: whitespace fixups to blast.
whitespace fixups to blast
Dec 13 2018, 4:45 PM
cmatthews committed rL349114: Tox based testing.
Tox based testing
Dec 13 2018, 4:33 PM
cmatthews committed rL349113: pep8 whitespace fixups.
pep8 whitespace fixups
Dec 13 2018, 4:33 PM
cmatthews committed rL349112: Unused import.
Unused import
Dec 13 2018, 4:33 PM
cmatthews committed rL349111: Seems like a lot of E266 in the lit test cases, disable that.
Seems like a lot of E266 in the lit test cases, disable that
Dec 13 2018, 4:33 PM
cmatthews committed rL349110: Use ToT lit.
Use ToT lit
Dec 13 2018, 4:33 PM
cmatthews committed rL349109: Add some project policy for formatting so style tools are more useful.
Add some project policy for formatting so style tools are more useful
Dec 13 2018, 4:33 PM
cmatthews committed rL349108: Unused imports.
Unused imports
Dec 13 2018, 4:33 PM
cmatthews committed rL349107: pep8.
pep8
Dec 13 2018, 4:33 PM
cmatthews committed rL349106: Newest version of psycopg2 seems to work well, and has fixes for tox.
Newest version of psycopg2 seems to work well, and has fixes for tox
Dec 13 2018, 4:33 PM
cmatthews committed rL349105: This was an invalid type annotation.
This was an invalid type annotation
Dec 13 2018, 4:33 PM
cmatthews committed rL349104: Fix test.
Fix test
Dec 13 2018, 4:33 PM
cmatthews committed rL349103: Unused..
Unused.
Dec 13 2018, 4:32 PM
cmatthews committed rL349102: Fix Tuple has not .state.
Fix Tuple has not .state
Dec 13 2018, 4:32 PM
cmatthews committed rL349101: Unused..
Unused.
Dec 13 2018, 4:32 PM
cmatthews committed rL349100: Type annotations for regression code.
Type annotations for regression code
Dec 13 2018, 4:32 PM
cmatthews committed rL349099: This type annotation had grown stale.
This type annotation had grown stale
Dec 13 2018, 4:32 PM
cmatthews committed rL349079: Make timers easier to find in the logs.
Make timers easier to find in the logs
Dec 13 2018, 12:08 PM

Dec 11 2018

cmatthews committed rL348883: Import cleanup.
Import cleanup
Dec 11 2018, 11:01 AM
cmatthews committed rL348882: the sys import was used.
the sys import was used
Dec 11 2018, 11:01 AM
cmatthews committed rL348881: Time new regression creation.
Time new regression creation
Dec 11 2018, 10:53 AM
cmatthews committed rL348880: Preload orders and tests.
Preload orders and tests
Dec 11 2018, 10:53 AM
cmatthews committed rL348878: Logging should be info level if we are verbose.
Logging should be info level if we are verbose
Dec 11 2018, 10:53 AM
cmatthews committed rL348879: Prefer absolute imports, and remove unused import.
Prefer absolute imports, and remove unused import
Dec 11 2018, 10:53 AM
cmatthews committed rL348877: Don't call repr on all timed functions arguments.
Don't call repr on all timed functions arguments
Dec 11 2018, 10:53 AM
cmatthews committed rL348876: Keep a lookup table to avoid querying for FieldChange existence.
Keep a lookup table to avoid querying for FieldChange existence
Dec 11 2018, 10:53 AM

Oct 18 2018

cmatthews accepted D53136: [LNT] Come up with MIN_PERCENTAGE_CHANGE value.

LGTM.

Oct 18 2018, 10:49 AM

Oct 9 2018

cmatthews committed rL344090: Sleep endpoint for diagnosing timeout issues.
Sleep endpoint for diagnosing timeout issues
Oct 9 2018, 3:47 PM

Sep 28 2018

cmatthews committed rL343347: make lit builtins a package.
make lit builtins a package
Sep 28 2018, 10:57 AM

Sep 27 2018

cmatthews accepted D52593: [LNT] Sort fields according to order defined in YAML files..

LGTM.

Sep 27 2018, 2:22 PM
cmatthews accepted D51405: [LNT][RFC] Introduce Latest Runs Report..

I bet some of these report queries are going to be really slow on big databases. But we can fix them up over time if that is the case. LGTM.

Sep 27 2018, 1:32 PM

Sep 4 2018

cmatthews updated subscribers of D51609: [LNT] Enable X-Forwarded-* headers to be accepted..

What are you using for the backend web server?

Sep 4 2018, 12:44 PM
cmatthews requested changes to D51609: [LNT] Enable X-Forwarded-* headers to be accepted..

The docs mention "Do not use this middleware in non-proxy setups for security reasons." I would assume because this allows the client to set the host information. I use this in our setups. I think I apply it in the app launch file that we hand to gunicorn instead of here.

Sep 4 2018, 11:26 AM

Aug 29 2018

cmatthews requested changes to D51405: [LNT][RFC] Introduce Latest Runs Report..

This is a great idea. Thanks for setting it up!

Aug 29 2018, 10:53 AM
cmatthews added inline comments to D51405: [LNT][RFC] Introduce Latest Runs Report..
Aug 29 2018, 10:52 AM
cmatthews added a comment to D51405: [LNT][RFC] Introduce Latest Runs Report..

Testcases?

Aug 29 2018, 10:46 AM

Aug 17 2018

cmatthews accepted D50915: [LNT] In command-line tool expand tilde when resolving commands..
Aug 17 2018, 1:23 PM
cmatthews accepted D50916: [LNT] In command-line tool allow to use relative path for test suite location..
Aug 17 2018, 1:23 PM

Jun 26 2018

cmatthews committed rL335679: replace fragile version check with a better fragile version check.
replace fragile version check with a better fragile version check
Jun 26 2018, 3:38 PM
cmatthews committed rL335678: Fix error in run_info.
Fix error in run_info
Jun 26 2018, 3:38 PM

Jun 11 2018

cmatthews accepted D48003: [LNT] Sort machines in machines view..
Jun 11 2018, 10:19 AM

Jun 5 2018

cmatthews committed rL334050: Docs for graph_for_sample.
Docs for graph_for_sample
Jun 5 2018, 2:45 PM
cmatthews committed rL334048: And now the test resource file I forgot to add.
And now the test resource file I forgot to add
Jun 5 2018, 1:49 PM
cmatthews committed rL334047: Some simple support for detecting which devices are attached to a mac.
Some simple support for detecting which devices are attached to a mac
Jun 5 2018, 1:47 PM

May 31 2018

cmatthews committed rT333710: Make compatible with upstream lit.
Make compatible with upstream lit
May 31 2018, 4:57 PM
cmatthews committed rL333710: Make compatible with upstream lit.
Make compatible with upstream lit
May 31 2018, 4:44 PM

May 29 2018

cmatthews added a comment to D47486: [LNT] Request authentization for lnt submit command via secret_key in lnt.cfg file..

Secret key is used. That is the value that Flask is using to encrypt the cookies flask uses for sessions. It is also very secret, so we don't want it showing up outside the server config file.

May 29 2018, 10:29 AM

May 24 2018

cmatthews committed rL333249: Use quoteattr to ensure we make well formed attributes.
Use quoteattr to ensure we make well formed attributes
May 24 2018, 5:35 PM

May 22 2018

cmatthews updated subscribers of D47186: [LNT] Sort machines in Compare to by names..
May 22 2018, 2:26 PM
cmatthews accepted D47185: [LNT] API: add Tests resource..

Very useful. Thanks!

May 22 2018, 1:59 PM
cmatthews accepted D47186: [LNT] Sort machines in Compare to by names..

LGTM

May 22 2018, 1:55 PM

May 21 2018

cmatthews accepted D44007: [LNT] API: add Fields resource..

LGTM. Thanks

May 21 2018, 12:47 PM

May 15 2018

cmatthews committed rL332424: remove output xml incase it is leftover from another run.
remove output xml incase it is leftover from another run
May 15 2018, 5:40 PM
cmatthews committed rL332423: Use not to catch unexpected pass as well as remove old test results.
Use not to catch unexpected pass as well as remove old test results
May 15 2018, 5:37 PM
cmatthews added a comment to D46886: Escape ]]> in xunit xml output.

Sure, I will update the test today.

May 15 2018, 10:24 AM
cmatthews added a comment to D46886: Escape ]]> in xunit xml output.

The test does not care what the return code of lit is, just that the xml output is correct.

May 15 2018, 10:09 AM
cmatthews updated subscribers of D46886: Escape ]]> in xunit xml output.

There is a test case that intentionally fails to provide failing output. That makes lit return an error exit value. Any way to change what lit exits with?

May 15 2018, 10:03 AM
cmatthews accepted D46886: Escape ]]> in xunit xml output.

Is this an issue you are hitting? I noticed we spend a lot of time in string replace while writing the xunit files when the output is large (for instance if every test in the test suite fails). I was hoping the number of replaces we do could go down.

May 15 2018, 9:49 AM

May 11 2018

cmatthews committed rL332161: Requirements can have & in them!.
Requirements can have & in them!
May 11 2018, 5:17 PM
cmatthews committed rL332156: Add the message attribute to skipped.
Add the message attribute to skipped
May 11 2018, 4:19 PM
cmatthews committed rL332148: Overhaul unicode handling in xunit output.
Overhaul unicode handling in xunit output
May 11 2018, 3:22 PM
cmatthews committed rL332116: [LIT] replace output escapes wit a cdata block.
[LIT] replace output escapes wit a cdata block
May 11 2018, 11:43 AM

May 10 2018

cmatthews committed rL332065: Support Unsupported Tests in xunit output.
Support Unsupported Tests in xunit output
May 10 2018, 5:31 PM
cmatthews committed rL332064: Refactor xunit test case builder to not use as much str addition.
Refactor xunit test case builder to not use as much str addition
May 10 2018, 5:31 PM
cmatthews committed rL332056: [LIT] Move xunit tests tests into their own location, and and add failures.
[LIT] Move xunit tests tests into their own location, and and add failures
May 10 2018, 3:55 PM
cmatthews committed rL332032: Justin says this version of requests is too old.
Justin says this version of requests is too old
May 10 2018, 1:11 PM

May 9 2018

cmatthews added a comment to D46186: [LNT] Make content of send emails to be in utf-8..

ping. Could you commit this. It is breaking somewhere for me! Thanks

May 9 2018, 5:23 PM