Page MenuHomePhabricator

Fixed plistlib API usage for both python 2.7 and 3.x
ClosedPublic

Authored by kpdev42 on Oct 20 2021, 11:58 PM.

Diff Detail

Repository
rLNT LNT

Event Timeline

kpdev42 created this revision.Oct 20 2021, 11:58 PM
kpdev42 requested review of this revision.Oct 20 2021, 11:58 PM

I like the simplicity of it compared to my solution, but I'm a bit bothered by plistformat2 being in fact the same format. But it is simpler and less ugly than what I did. @tnfchris what is your opinion?

@kpdev42 Are you still using LNT in Python 2 mode? If not maybe we should just drop Python 2 support (https://reviews.llvm.org/D69056)

thopre accepted this revision.Oct 21 2021, 12:23 AM

Alright, let's keep this version. Thanks!

This revision is now accepted and ready to land.Oct 21 2021, 12:23 AM
This revision was automatically updated to reflect the committed changes.