This is an archive of the discontinued LLVM Phabricator instance.

Differential D69052

[LNT] Python 3 support: enable testing for Python 3
ClosedPublic

Authored by thopre on Oct 16 2019, 9:37 AM.

Details

Reviewers
cmatthews
hubert.reinterpretcast
kristof.beyls
leandron
PrzemekWirkus
Summary

Now that all tests are passing in Python 3 enable testing for Python 3
in addition of testing for Python 2.

Diff Detail

Event Timeline

thopre created this revision.Oct 16 2019, 9:37 AM
thopre added a parent revision: D69048: [LNT] Python 3 support: run tests with UTF-8 encoding.Oct 16 2019, 9:38 AM
thopre added a child revision: D69053: [LNT] Switch docker image to Python 3.
Harbormaster completed remote builds in B39651: Diff 225247.Oct 16 2019, 9:41 AM
thopre added reviewers: leandron, PrzemekWirkus.Dec 4 2019, 7:01 AM
cmatthews accepted this revision.Dec 4 2019, 11:24 AM
This revision is now accepted and ready to land.Dec 4 2019, 11:24 AM
thopre edited parent revisions, added: D68985: [LNT] Python 3 support: requests.response as text; removed: D69048: [LNT] Python 3 support: run tests with UTF-8 encoding.Dec 5 2019, 4:12 AM
thopre edited parent revisions, added: D68938: [LNT] Python 3 support: subprocess IO as text; removed: D68985: [LNT] Python 3 support: requests.response as text.Dec 5 2019, 7:44 AM
thopre edited parent revisions, added: D68921: [LNT] Python 3 support: fix server/ui/statsTester.py test discovery; removed: D68938: [LNT] Python 3 support: subprocess IO as text.Dec 5 2019, 8:31 AM
thopre added a child revision: D71085: [LNT] Declare support for Python 3.6+.Dec 5 2019, 12:08 PM
thopre removed a child revision: D69053: [LNT] Switch docker image to Python 3.
thopre edited parent revisions, added: D68863: [LNT] Python 3 support: don't assume order of cmake args; removed: D68921: [LNT] Python 3 support: fix server/ui/statsTester.py test discovery.Dec 6 2019, 1:31 AM
thopre closed this revision.Dec 12 2019, 6:03 AM
thopre added a comment.Dec 12 2019, 6:03 AM

Committed as d9a8050d19ee28dd3c2ab07d23a1382dd35b43e6

Revision Contents

PathSize
2 lines

Diff 225247

tox.ini

[base] [base]
# Files we'd like to keep lint clean. Lets hope we can expand this list. # Files we'd like to keep lint clean. Lets hope we can expand this list.
whitelist_files = ./setup.py whitelist_files = ./setup.py
./deployment/ ./deployment/
./lnt/formats/ ./lnt/formats/
./lnt/util/ ./lnt/util/
./lnt/tests/ ./lnt/tests/
./lnt/testing/ ./lnt/testing/
./tests/server/ui/ ./tests/server/ui/
[tox] [tox]
envlist = py27 envlist = py27
py3
mypy mypy
flake8 flake8
[testenv] [testenv]
whitelist_externals = rm whitelist_externals = rm
deps = -rrequirements.txt deps = -rrequirements.txt
commands = commands =
rm -rf ./test_run_tmp rm -rf ./test_run_tmp
lit -sv ./tests/ lit -sv ./tests/
[testenv:mypy] [testenv:mypy]
basepython = python3 basepython = python3
skip_install = true skip_install = true
deps = deps =
mypy mypy
commands = commands =
# No where close to passing yet, but nice to have. # No where close to passing yet, but nice to have.
- mypy --junit-xml=junit-{envname}.xml --py2 --ignore-missing-imports lnt - mypy --junit-xml=junit-{envname}.xml --py2 --ignore-missing-imports lnt
- mypy --junit-xml=junit-{envname}.xml --ignore-missing-imports lnt
[testenv:flake8] [testenv:flake8]
skip_install = true skip_install = true
deps = deps =
flake8 flake8
commands = commands =
# Still lots of problems. # Still lots of problems.
- flake8 --statistics --exclude=./lnt/external/ ./lnt/ ./tests/ ./setup.py ./deployment/ - flake8 --statistics --exclude=./lnt/external/ ./lnt/ ./tests/ ./setup.py ./deployment/
# But lets keep the clean files clean. # But lets keep the clean files clean.
flake8 {[base]whitelist_files} flake8 {[base]whitelist_files}