This is an archive of the discontinued LLVM Phabricator instance.

Differential D68815

[AIX] Use .space instead of .zero in assembly
ClosedPublic

Authored by daltenty on Oct 10 2019, 10:07 AM.

Details

Reviewers
Xiangling_L
jasonliu
sfertile
DiggerLin
Commits
rG033d16cedc08: [AIX] Use .space instead of .zero in assembly
rL374564: [AIX] Use .space instead of .zero in assembly
Summary

The AIX system assembler does not understand .zero, so we should prefer
emitting .space.

Diff Detail

Event Timeline

daltenty created this revision.Oct 10 2019, 10:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 10 2019, 10:07 AM
Herald added subscribers: llvm-commits, jsji, MaskRay and 3 others. · View Herald Transcript
daltenty added reviewers: Xiangling_L, jasonliu, sfertile, DiggerLin.Oct 10 2019, 10:08 AM
Herald added a subscriber: • wuzish. · View Herald TranscriptOct 10 2019, 10:08 AM
Harbormaster completed remote builds in B39341: Diff 224397.Oct 10 2019, 10:13 AM
sfertile accepted this revision.Oct 11 2019, 6:12 AM

LGTM.

This revision is now accepted and ready to land.Oct 11 2019, 6:12 AM
Closed by commit rG033d16cedc08: [AIX] Use .space instead of .zero in assembly (authored by daltenty). · Explain WhyOct 11 2019, 8:14 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
Target/
PowerPC/
MCTargetDesc/
1 line
test/
CodeGen/
PowerPC/
17 lines

Diff 224397

llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCAsmInfo.cpp

Show First 20 Lines • Show All 80 Lines • ▼ Show 20 LinesPPCELFMCAsmInfo::PPCELFMCAsmInfo(bool is64Bit, const Triple& T) {
UseIntegratedAssembler = true; UseIntegratedAssembler = true;
} }
void PPCXCOFFMCAsmInfo::anchor() {} void PPCXCOFFMCAsmInfo::anchor() {}
PPCXCOFFMCAsmInfo::PPCXCOFFMCAsmInfo(bool Is64Bit, const Triple &T) { PPCXCOFFMCAsmInfo::PPCXCOFFMCAsmInfo(bool Is64Bit, const Triple &T) {
assert(!IsLittleEndian && "Little-endian XCOFF not supported."); assert(!IsLittleEndian && "Little-endian XCOFF not supported.");
CodePointerSize = CalleeSaveStackSlotSize = Is64Bit ? 8 : 4; CodePointerSize = CalleeSaveStackSlotSize = Is64Bit ? 8 : 4;
ZeroDirective = "\t.space\t";
} }

llvm/test/CodeGen/PowerPC/aix-space.ll

  • This file was added.
; RUN: llc -verify-machineinstrs -O0 -mcpu=pwr7 -mtriple powerpc-ibm-aix-xcoff < %s | FileCheck %s
@a = common global double 0.000000e+00, align 8
; Get some constants into the constant pool that need spacing for alignment
define void @e() {
entry:
%0 = load double, double* @a, align 8
%mul = fmul double 1.500000e+00, %0
store double %mul, double* @a, align 8
%mul1 = fmul double 0x3F9C71C71C71C71C, %0
store double %mul1, double* @a, align 8
ret void
}
; CHECK: .space 4
; CHECK-NOT: .zero