Page MenuHomePhabricator

[Tests] Output of od can be lower or upper case (llvm-objcopy/yaml2obj).
ClosedPublic

Authored by Kai on Oct 9 2019, 4:29 AM.

Details

Summary

The command od -t x is used to dump data in hex format.
The LIT tests assumes that the hex characters are in lowercase.
However, there are also platforms which use uppercase letter.

To solve this issue the tests are updated to use the new
--ignore-case option of FileCheck.

Diff Detail

Event Timeline

Kai created this revision.Oct 9 2019, 4:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 9 2019, 4:29 AM
rupprecht accepted this revision.Oct 9 2019, 3:26 PM

Much better :)

This revision is now accepted and ready to land.Oct 9 2019, 3:26 PM
This revision was automatically updated to reflect the committed changes.

I reverted this change in r374358 because it depends on https://reviews.llvm.org/D68146, which broke tests.

Please run ninja check-all before committing.

I know I am late, but when you re-committed, you should have updated this sentence to mention a concrete example other than a fuzzy mention about the existence:

However, there are also platforms which use uppercase letter.

Probably https://reviews.llvm.org/D68146#1689253 "z/OS USS". Ideally, include a dump of od on that system.

The uppercase problem is a pretty unfortunate fact and --ignore-case is mostly hidden knowledge which can only be learned by informed by the people caring about the platform.