SBDebugger::SetInputFile, SetOutputFile, etc.

[lawrence_danna]

Summary

Add new methods to SBDebugger to set IO files as SBFiles instead of
as FILE* streams.

In future commits, the FILE* methods will be deprecated and these
will become the primary way to set the debugger I/O streams.

[lawrence_danna]

clang-format fix

[labath]

Looks mostly fine to me. Just a couple of questions inline...

lldb/packages/Python/lldbsuite/test/python_api/file_handle/TestFileHandle.py

190–191

self.assertTrue(status.Success())

lldb/source/API/SBDebugger.cpp

296–343

Any chance we could make this method simply delegate to the SBFile version ?

lldb/source/Core/Debugger.cpp

828–834

Could we make it so that the validity of the file_sp argument is checked at the SB level? That way you wouldn't need the Status result here. Same goes for stdout and stderr methods.

[lawrence_danna]

propagated updates from parent

[lawrence_danna]

pushed validity checks out to the SB layer

[lawrence_danna]

assertions instead of exceptions

[labath]

LGTM. thanks.

lldb/include/lldb/API/SBFile.h

31–37

All (including private) SB methods should be defined out of line. Otherwise, their implementation becomes a part of the ABI.

[lawrence_danna]

no inlines in the API