This is an archive of the discontinued LLVM Phabricator instance.

protect libedit and LLDB gui from receiving null FILE* streams

Authored by lawrence_danna on Oct 8 2019, 6:04 PM.



We now have valid files that will return NULL from GetStream().
libedit and the LLDB gui are the only places left that need FILE*
streams. Both are doing curses-like user interaction that only
make sense with a real terminal anyway, so there is no need to convert
them off of their use of FILE*. But we should check for null streams
before enabling these features.

Diff Detail

Event Timeline

lawrence_danna created this revision.Oct 8 2019, 6:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 8 2019, 6:04 PM
JDevlieghere accepted this revision.Oct 8 2019, 9:14 PM
This revision is now accepted and ready to land.Oct 8 2019, 9:14 PM
labath accepted this revision.Oct 9 2019, 6:06 AM
This revision was automatically updated to reflect the committed changes.