fixed whitespace and commited

Does this fix it for you?

In D113650#3136407, @aprantl wrote:

This seems to have broken the green dragon incremental bot: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/38387/

In D113650#3136407, @aprantl wrote:

This seems to have broken the green dragon incremental bot: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/38387/

rebase

cmake fix

rebased, and include win32

revert change that disabled the test

In D113650#3128674, @stella.stamenova wrote:

Can you please disable the test on Windows or back your change out until there's a fix? There are already other failures that are getting missed because the bot is red.

cleanup cmake usage

fix cmake error message condition for cross-compile

OK this should work in all configs I think, as long as sys.executable ultimately points at something under sys.prefix

maybe this approach is better

comments

In D112973#3122496, @stella.stamenova wrote:

Windows buildbot is broken:

https://lab.llvm.org/buildbot/#/builders/83/builds/11865

cleanup

changed internal apis to use StructuredData instead of char*

clang-format

updated according to reviewer feedback.

@stella.stamenova fixed

In D113047#3106732, @stella.stamenova wrote:

The Windows buildbot is still broken after this change:

https://lab.llvm.org/buildbot/#/builders/83/builds/11630

That approach would work great for my purposes, i'll update like that.

In D112988#3103992, @stella.stamenova wrote:

It looks like some of the tests need to be updated after this change (at least on Windows, the Windows LLDB bot is broken now):

https://lab.llvm.org/buildbot/#/builders/83/builds/11623/steps/7/logs/stdio

In D112988#3103574, @jingham wrote:

Ha! It was apparently so easy to add the test that it wasn't noticeable (at least by me!).

This isn't directly relevant to your patch, since this wasn't behavior you changed, but it seems weird to me to suppress the commands but print their output? Is that really the behavior we want for -Q?

In D112988#3103463, @jingham wrote:

There was one typo I pointed out, and it would be good to add a test. I'm sure this worked at some point, but wasn't tested so it was broken without anybody noticing. We want to make sure that doesn't happen again... It should be easy to write a Shell test case that just runs an lldb with the -Q option, sources a file and checks that you don't see output from it.

fix typo

change lldb-python into a script instead of a feature of Driver.cpp

In D112973#3101602, @JDevlieghere wrote:

FWIW crashlog.py has a good example of how to import LLDB. It's complicated slightly by us having to honor the LLDB_DEFAULT_PYTHON_VERSION, but otherwise it's pretty simple:

clang-format

Looks fine to me, assuming that the tests pass.

despite there being no references to this function, it is not actually unused.

@omjavaid ok to re-land?

rebased

rebased

@omjavaid sorry I didn't catch that on pre-submit testing. PyLong_AsLongLong and friends do not automatically convert on python2 like they do on python3. It's fixed now.

fix python2 problems

wrap long line

fix

review fixes

fixed

fix initializer

delete operator= too

fixed