Page MenuHomePhabricator

lawrence_danna (Lawrence D'Anna)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 11 2017, 3:24 PM (241 w, 1 d)

Recent Activity

Dec 2 2021

lawrence_danna added a comment to D114973: [lldb] add fallback for LLDB_PYTHON_RELATIVE_PATH.

fixed whitespace and commited

Dec 2 2021, 9:14 PM · Restricted Project
lawrence_danna committed rG27ca9458012c: [lldb] add fallback for LLDB_PYTHON_RELATIVE_PATH (authored by lawrence_danna).
[lldb] add fallback for LLDB_PYTHON_RELATIVE_PATH
Dec 2 2021, 9:14 PM
lawrence_danna closed D114973: [lldb] add fallback for LLDB_PYTHON_RELATIVE_PATH.
Dec 2 2021, 9:14 PM · Restricted Project
lawrence_danna added a comment to D113650: [lldb] fix -print-script-interpreter-info on windows.

Does this fix it for you?

Dec 2 2021, 7:40 PM · Restricted Project
lawrence_danna added a reviewer for D114973: [lldb] add fallback for LLDB_PYTHON_RELATIVE_PATH: clayborg.
Dec 2 2021, 7:40 PM · Restricted Project
lawrence_danna requested review of D114973: [lldb] add fallback for LLDB_PYTHON_RELATIVE_PATH.
Dec 2 2021, 10:32 AM · Restricted Project

Nov 17 2021

lawrence_danna committed rG63270710f13a: [lldb] remove usage of distutils, fix python path on debian/ubuntu (authored by lawrence_danna).
[lldb] remove usage of distutils, fix python path on debian/ubuntu
Nov 17 2021, 1:14 PM
lawrence_danna closed D114106: [lldb] remove usage of distutils, fix python path on debian/ubuntu.
Nov 17 2021, 1:14 PM · Restricted Project
lawrence_danna requested review of D114106: [lldb] remove usage of distutils, fix python path on debian/ubuntu.
Nov 17 2021, 10:28 AM · Restricted Project
lawrence_danna added a comment to D113650: [lldb] fix -print-script-interpreter-info on windows.

This seems to have broken the green dragon incremental bot: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/38387/

Nov 17 2021, 9:59 AM · Restricted Project
lawrence_danna committed rGf07ddbc620a0: [lldb] build failure for LLDB_PYTHON_EXE_RELATIVE_PATH on greendragon (authored by lawrence_danna).
[lldb] build failure for LLDB_PYTHON_EXE_RELATIVE_PATH on greendragon
Nov 17 2021, 9:27 AM

Nov 16 2021

lawrence_danna added a comment to D113650: [lldb] fix -print-script-interpreter-info on windows.

This seems to have broken the green dragon incremental bot: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/38387/

Nov 16 2021, 5:52 PM · Restricted Project
lawrence_danna committed rGae389b2450bd: [lldb] use EXT_SUFFIX for python extension (authored by lawrence_danna).
[lldb] use EXT_SUFFIX for python extension
Nov 16 2021, 2:32 PM
lawrence_danna closed D112972: [lldb] use EXT_SUFFIX for python extension.
Nov 16 2021, 2:32 PM · Restricted Project
lawrence_danna committed rG4c2cf3a314d9: [lldb] fix -print-script-interpreter-info on windows (authored by lawrence_danna).
[lldb] fix -print-script-interpreter-info on windows
Nov 16 2021, 1:51 PM
lawrence_danna closed D113650: [lldb] fix -print-script-interpreter-info on windows.
Nov 16 2021, 1:50 PM · Restricted Project

Nov 12 2021

lawrence_danna updated the diff for D112972: [lldb] use EXT_SUFFIX for python extension.

rebase

Nov 12 2021, 6:53 PM · Restricted Project
lawrence_danna updated the diff for D113650: [lldb] fix -print-script-interpreter-info on windows.

cmake fix

Nov 12 2021, 6:53 PM · Restricted Project
lawrence_danna updated the diff for D112972: [lldb] use EXT_SUFFIX for python extension.

rebased, and include win32

Nov 12 2021, 3:54 PM · Restricted Project
lawrence_danna updated the diff for D113650: [lldb] fix -print-script-interpreter-info on windows.

revert change that disabled the test

Nov 12 2021, 3:47 PM · Restricted Project
lawrence_danna committed rG19cd6f31d83e: [lldb] temporarily disable TestPaths.test_interpreter_info on windows (authored by lawrence_danna).
[lldb] temporarily disable TestPaths.test_interpreter_info on windows
Nov 12 2021, 3:42 PM
lawrence_danna added a comment to D113650: [lldb] fix -print-script-interpreter-info on windows.

Can you please disable the test on Windows or back your change out until there's a fix? There are already other failures that are getting missed because the bot is red.

Nov 12 2021, 3:42 PM · Restricted Project
lawrence_danna updated the diff for D113650: [lldb] fix -print-script-interpreter-info on windows.

cleanup cmake usage

Nov 12 2021, 3:31 PM · Restricted Project
lawrence_danna updated the diff for D113650: [lldb] fix -print-script-interpreter-info on windows.

fix cmake error message condition for cross-compile

Nov 12 2021, 10:04 AM · Restricted Project

Nov 11 2021

lawrence_danna added a comment to D113650: [lldb] fix -print-script-interpreter-info on windows.

OK this should work in all configs I think, as long as sys.executable ultimately points at something under sys.prefix

Nov 11 2021, 11:15 AM · Restricted Project
lawrence_danna updated the summary of D113650: [lldb] fix -print-script-interpreter-info on windows.
Nov 11 2021, 11:14 AM · Restricted Project
lawrence_danna updated the diff for D113650: [lldb] fix -print-script-interpreter-info on windows.

maybe this approach is better

Nov 11 2021, 11:12 AM · Restricted Project
lawrence_danna added inline comments to D113650: [lldb] fix -print-script-interpreter-info on windows.
Nov 11 2021, 10:08 AM · Restricted Project
lawrence_danna added a comment to D113650: [lldb] fix -print-script-interpreter-info on windows.

comments

Nov 11 2021, 9:55 AM · Restricted Project
lawrence_danna added inline comments to D113650: [lldb] fix -print-script-interpreter-info on windows.
Nov 11 2021, 9:52 AM · Restricted Project
lawrence_danna added a reviewer for D113650: [lldb] fix -print-script-interpreter-info on windows: stella.stamenova.
Nov 11 2021, 12:00 AM · Restricted Project

Nov 10 2021

lawrence_danna added a comment to D112973: [lldb] make it easier to find LLDB's python.
Nov 10 2021, 11:59 PM · Restricted Project
lawrence_danna requested review of D113650: [lldb] fix -print-script-interpreter-info on windows.
Nov 10 2021, 11:57 PM · Restricted Project
lawrence_danna committed rGbbef51eb43c2: [lldb] make it easier to find LLDB's python (authored by lawrence_danna).
[lldb] make it easier to find LLDB's python
Nov 10 2021, 10:34 AM
lawrence_danna closed D112973: [lldb] make it easier to find LLDB's python.
Nov 10 2021, 10:34 AM · Restricted Project
lawrence_danna added inline comments to D112973: [lldb] make it easier to find LLDB's python.
Nov 10 2021, 9:12 AM · Restricted Project
lawrence_danna updated the diff for D112973: [lldb] make it easier to find LLDB's python.

cleanup

Nov 10 2021, 9:12 AM · Restricted Project
lawrence_danna updated the diff for D112973: [lldb] make it easier to find LLDB's python.

changed internal apis to use StructuredData instead of char*

Nov 10 2021, 7:58 AM · Restricted Project

Nov 9 2021

lawrence_danna updated the diff for D112973: [lldb] make it easier to find LLDB's python.

clang-format

Nov 9 2021, 12:10 AM · Restricted Project
lawrence_danna updated the summary of D112973: [lldb] make it easier to find LLDB's python.
Nov 9 2021, 12:07 AM · Restricted Project
lawrence_danna updated the summary of D112973: [lldb] make it easier to find LLDB's python.
Nov 9 2021, 12:06 AM · Restricted Project
lawrence_danna updated the diff for D112973: [lldb] make it easier to find LLDB's python.

updated according to reviewer feedback.

Nov 9 2021, 12:05 AM · Restricted Project

Nov 4 2021

lawrence_danna added a comment to D113047: [lldb] update TestEchoCommands.

@stella.stamenova fixed

Nov 4 2021, 1:25 AM · Restricted Project
lawrence_danna committed rG531d877ee641: [lldb] Fix TestEchoCommands.test again (authored by lawrence_danna).
[lldb] Fix TestEchoCommands.test again
Nov 4 2021, 1:24 AM

Nov 3 2021

lawrence_danna added a comment to D113047: [lldb] update TestEchoCommands.

The Windows buildbot is still broken after this change:

https://lab.llvm.org/buildbot/#/builders/83/builds/11630

Nov 3 2021, 10:45 AM · Restricted Project

Nov 2 2021

lawrence_danna added a comment to D112973: [lldb] make it easier to find LLDB's python.

That approach would work great for my purposes, i'll update like that.

Nov 2 2021, 10:55 PM · Restricted Project
lawrence_danna committed rG7f01f78593d6: [lldb] update TestEchoCommands (authored by lawrence_danna).
[lldb] update TestEchoCommands
Nov 2 2021, 2:30 PM
lawrence_danna closed D113047: [lldb] update TestEchoCommands.
Nov 2 2021, 2:30 PM · Restricted Project
lawrence_danna added a comment to D112988: [lldb] fix --source-quietly.

It looks like some of the tests need to be updated after this change (at least on Windows, the Windows LLDB bot is broken now):

https://lab.llvm.org/buildbot/#/builders/83/builds/11623/steps/7/logs/stdio

Nov 2 2021, 1:59 PM · Restricted Project
lawrence_danna requested review of D113047: [lldb] update TestEchoCommands.
Nov 2 2021, 1:38 PM · Restricted Project
lawrence_danna committed rGe2a6c08bbc38: [lldb] fix --source-quietly (authored by lawrence_danna).
[lldb] fix --source-quietly
Nov 2 2021, 11:02 AM
lawrence_danna closed D112988: [lldb] fix --source-quietly.
Nov 2 2021, 11:02 AM · Restricted Project
lawrence_danna added a comment to D112988: [lldb] fix --source-quietly.

Ha! It was apparently so easy to add the test that it wasn't noticeable (at least by me!).

This isn't directly relevant to your patch, since this wasn't behavior you changed, but it seems weird to me to suppress the commands but print their output? Is that really the behavior we want for -Q?

Nov 2 2021, 10:53 AM · Restricted Project
lawrence_danna added a comment to D112988: [lldb] fix --source-quietly.

There was one typo I pointed out, and it would be good to add a test. I'm sure this worked at some point, but wasn't tested so it was broken without anybody noticing. We want to make sure that doesn't happen again... It should be easy to write a Shell test case that just runs an lldb with the -Q option, sources a file and checks that you don't see output from it.

Nov 2 2021, 10:31 AM · Restricted Project
lawrence_danna updated the diff for D112988: [lldb] fix --source-quietly.

fix typo

Nov 2 2021, 10:30 AM · Restricted Project
lawrence_danna requested review of D112988: [lldb] fix --source-quietly.
Nov 2 2021, 12:32 AM · Restricted Project

Nov 1 2021

lawrence_danna updated the diff for D112973: [lldb] make it easier to find LLDB's python.

change lldb-python into a script instead of a feature of Driver.cpp

Nov 1 2021, 11:13 PM · Restricted Project
lawrence_danna added a comment to D112973: [lldb] make it easier to find LLDB's python.

FWIW crashlog.py has a good example of how to import LLDB. It's complicated slightly by us having to honor the LLDB_DEFAULT_PYTHON_VERSION, but otherwise it's pretty simple:

Nov 1 2021, 5:35 PM · Restricted Project
lawrence_danna updated the summary of D112973: [lldb] make it easier to find LLDB's python.
Nov 1 2021, 4:59 PM · Restricted Project
lawrence_danna requested review of D112973: [lldb] make it easier to find LLDB's python.
Nov 1 2021, 4:58 PM · Restricted Project
lawrence_danna requested review of D112972: [lldb] use EXT_SUFFIX for python extension.
Nov 1 2021, 4:55 PM · Restricted Project

Oct 19 2021

lawrence_danna committed rG8ac5a6641fa4: [lldb] improve the help strings for gdb-remote and kdp-remote (authored by lawrence_danna).
[lldb] improve the help strings for gdb-remote and kdp-remote
Oct 19 2021, 1:09 PM
lawrence_danna closed D111965: [lldb] improve the help strings for gdb-remote and kdp-remote.
Oct 19 2021, 1:08 PM · Restricted Project

Oct 18 2021

lawrence_danna added a reviewer for D111965: [lldb] improve the help strings for gdb-remote and kdp-remote: jingham.
Oct 18 2021, 3:08 PM · Restricted Project

Oct 17 2021

lawrence_danna updated the diff for D111965: [lldb] improve the help strings for gdb-remote and kdp-remote.

clang-format

Oct 17 2021, 9:23 AM · Restricted Project
lawrence_danna requested review of D111965: [lldb] improve the help strings for gdb-remote and kdp-remote.
Oct 17 2021, 9:18 AM · Restricted Project

Oct 15 2021

lawrence_danna committed rG4594f8116543: Fix Xcode project for debugserver (authored by Lawrence D'\''Anna <lawrence_danna@apple.com>).
Fix Xcode project for debugserver
Oct 15 2021, 3:10 PM
lawrence_danna closed D111910: Fix Xcode project for debugserver.
Oct 15 2021, 3:10 PM · Restricted Project
lawrence_danna requested review of D111910: Fix Xcode project for debugserver.
Oct 15 2021, 2:46 PM · Restricted Project

Sep 5 2020

lawrence_danna committed rG0c642828612d: scan-build-py: fix multiprocessing error (authored by lawrence_danna).
scan-build-py: fix multiprocessing error
Sep 5 2020, 11:11 AM
lawrence_danna closed D87051: scan-build-py: fix multiprocessing error.
Sep 5 2020, 11:10 AM · Restricted Project

Sep 2 2020

lawrence_danna updated the summary of D87051: scan-build-py: fix multiprocessing error.
Sep 2 2020, 12:17 PM · Restricted Project
lawrence_danna updated the summary of D87051: scan-build-py: fix multiprocessing error.
Sep 2 2020, 12:17 PM · Restricted Project
lawrence_danna requested review of D87051: scan-build-py: fix multiprocessing error.
Sep 2 2020, 12:16 PM · Restricted Project

Aug 21 2020

lawrence_danna accepted D86381: Move Py_buffer_RAII to .h file so SWIG 2 doesnt have to parse it.

Looks fine to me, assuming that the tests pass.

Aug 21 2020, 3:55 PM · Restricted Project
lawrence_danna added inline comments to D77480: Fix illegal early call to PyBuffer_Release in swig typemaps.
Aug 21 2020, 12:14 PM · Restricted Project
lawrence_danna added inline comments to D77480: Fix illegal early call to PyBuffer_Release in swig typemaps.
Aug 21 2020, 12:13 PM · Restricted Project

May 18 2020

lawrence_danna abandoned D78603: remove unused function LLDBSwigPython_GetIndexOfChildWithName.

despite there being no references to this function, it is not actually unused.

May 18 2020, 11:54 AM · Restricted Project

May 8 2020

lawrence_danna committed rG52712d3ff7a2: Re-land "get rid of PythonInteger::GetInteger()" (authored by lawrence_danna).
Re-land "get rid of PythonInteger::GetInteger()"
May 8 2020, 11:15 AM
lawrence_danna closed D78462: get rid of PythonInteger::GetInteger().
May 8 2020, 11:15 AM · Restricted Project

Apr 24 2020

lawrence_danna added a comment to D78462: get rid of PythonInteger::GetInteger().

@omjavaid ok to re-land?

Apr 24 2020, 10:50 AM · Restricted Project
lawrence_danna updated the diff for D78462: get rid of PythonInteger::GetInteger().

rebased

Apr 24 2020, 10:15 AM · Restricted Project

Apr 23 2020

lawrence_danna updated the diff for D78462: get rid of PythonInteger::GetInteger().

rebased

Apr 23 2020, 2:07 PM · Restricted Project
lawrence_danna added a comment to D78462: get rid of PythonInteger::GetInteger().

@omjavaid sorry I didn't catch that on pre-submit testing. PyLong_AsLongLong and friends do not automatically convert on python2 like they do on python3. It's fixed now.

Apr 23 2020, 11:57 AM · Restricted Project
lawrence_danna updated the diff for D78462: get rid of PythonInteger::GetInteger().

fix python2 problems

Apr 23 2020, 11:53 AM · Restricted Project

Apr 21 2020

lawrence_danna created D78603: remove unused function LLDBSwigPython_GetIndexOfChildWithName.
Apr 21 2020, 5:53 PM · Restricted Project
lawrence_danna committed rG737521217295: get rid of PythonInteger::GetInteger() (authored by lawrence_danna).
get rid of PythonInteger::GetInteger()
Apr 21 2020, 5:21 PM
lawrence_danna closed D78462: get rid of PythonInteger::GetInteger().
Apr 21 2020, 5:21 PM · Restricted Project
lawrence_danna added inline comments to D78462: get rid of PythonInteger::GetInteger().
Apr 21 2020, 5:21 PM · Restricted Project
lawrence_danna updated the diff for D78462: get rid of PythonInteger::GetInteger().

wrap long line

Apr 21 2020, 5:21 PM · Restricted Project

Apr 20 2020

lawrence_danna updated the diff for D78462: get rid of PythonInteger::GetInteger().

fix

Apr 20 2020, 2:05 PM · Restricted Project
lawrence_danna added inline comments to D78462: get rid of PythonInteger::GetInteger().
Apr 20 2020, 12:27 PM · Restricted Project
lawrence_danna updated the diff for D78462: get rid of PythonInteger::GetInteger().

review fixes

Apr 20 2020, 12:27 PM · Restricted Project

Apr 19 2020

lawrence_danna created D78462: get rid of PythonInteger::GetInteger().
Apr 19 2020, 2:57 PM · Restricted Project

Apr 7 2020

lawrence_danna committed rGc8de17bca658: Fix illegal early call to PyBuffer_Release in swig typemaps (authored by lawrence_danna).
Fix illegal early call to PyBuffer_Release in swig typemaps
Apr 7 2020, 1:38 PM
lawrence_danna closed D77480: Fix illegal early call to PyBuffer_Release in swig typemaps.
Apr 7 2020, 1:38 PM · Restricted Project
lawrence_danna added a comment to D77480: Fix illegal early call to PyBuffer_Release in swig typemaps.

fixed

Apr 7 2020, 12:34 PM · Restricted Project
lawrence_danna updated the diff for D77480: Fix illegal early call to PyBuffer_Release in swig typemaps.

fix initializer

Apr 7 2020, 12:33 PM · Restricted Project

Apr 6 2020

lawrence_danna updated the diff for D77480: Fix illegal early call to PyBuffer_Release in swig typemaps.

delete operator= too

Apr 6 2020, 1:37 PM · Restricted Project
lawrence_danna added a comment to D77480: Fix illegal early call to PyBuffer_Release in swig typemaps.

fixed

Apr 6 2020, 1:04 PM · Restricted Project