Page MenuHomePhabricator

SBFile: add a bunch of tests that should eventually work.
ClosedPublic

Authored by lawrence_danna on Thu, Oct 3, 4:28 PM.

Details

Summary

It's really annoying and confusing to have to keep referring
back to earlier versions of this SBFile work to find the
tests that need to be added for each patch, and not duplicate
them with new tests.

This patch just imports all my tests. A bunch of them don't
work yet, so they are marked to be skipped. They'll be
unmarked as I fix them.

One of these tests will actually trip an assert in the SWIG
code now instead of just failing, so I'm fixing that here too.

Diff Detail

Event Timeline

lawrence_danna created this revision.Thu, Oct 3, 4:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Oct 3, 4:28 PM
labath added a comment.Fri, Oct 4, 1:30 AM

Makes sense. Would it make sense to use @expectedFailure instead of @skipIf? That way you'll get an notification once a test actually starts passing...

use expectedFailure

labath accepted this revision.Mon, Oct 7, 4:44 AM
This revision is now accepted and ready to land.Mon, Oct 7, 4:44 AM
JDevlieghere accepted this revision.Mon, Oct 7, 2:02 PM
This revision was automatically updated to reflect the committed changes.