remove a smattering of isolated, unnecessary uses of FILE*

[lawrence_danna]

Summary

There a a few call sites that use FILE* which are easy to
fix without disrupting anything else.

[labath]

lldb/source/Core/IOHandler.cpp

333

It looks like this could actually use the Stream interface to write this stuff (*m_output_sp << prompt). Ideally, I guess we wouldn't even have formatted output capabilities on the File class, and things would always go through streams for stuff like this..

494

same here.

lldb/source/Expression/REPL.cpp

426

and here.

[JDevlieghere]

LGTM modulo the stream changes.

[lawrence_danna]

fixed

[lawrence_danna]

fixed

[lawrence_danna]

rebased

[lawrence_danna]

rebased

lldb/source/API/SBDebugger.cpp

if (m_opaque_sp) {
     if (target_sp)
       lock = std::unique_lock<std::recursive_mutex>(target_sp->GetAPIMutex());
 
     SBCommandInterpreter sb_interpreter(GetCommandInterpreter());
     SBCommandReturnObject result;
 
     sb_interpreter.HandleCommand(command, result, false);
 
-    if (GetErrorFileHandle() != nullptr)
-      result.PutError(GetErrorFile());
-    if (GetOutputFileHandle() != nullptr)
-      result.PutOutput(GetOutputFile());
+    result.PutError(m_opaque_sp->GetErrorStream().GetFileSP());
+    result.PutOutput(m_opaque_sp->GetOutputStream().GetFileSP());
 
     if (!m_opaque_sp->GetAsyncExecution()) {
       SBProcess process(GetCommandInterpreter().GetProcess());
       ProcessSP process_sp(process.GetSP());
       if (process_sp) {
         EventSP event_sp;
         ListenerSP lldb_listener_sp = m_opaque_sp->GetListener();
         while (lldb_listener_sp->GetEventForBroadcaster(

lldb/source/Core/IOHandler.cpp

if (in) {
 
         if (m_multi_line && m_curr_line_idx > 0)
           prompt = GetContinuationPrompt();
 
         if (prompt == nullptr)
           prompt = GetPrompt();
 
         if (prompt && prompt[0]) {
-          FILE *out = GetOutputFILE();
-          if (out) {
-            ::fprintf(out, "%s", prompt);
-            ::fflush(out);
+          if (m_output_sp) {
+            m_output_sp->Printf("%s", prompt);
+            m_output_sp->Flush();
           }
         }
       }
       char buffer[256];
       bool done = false;
       bool got_line = false;
       m_editing = true;
       while (!done) {

 #endif
     bool done = false;
     Status error;
 
     while (!done) {
       // Show line numbers if we are asked to
       std::string line;
       if (m_base_line_number > 0 && GetIsInteractive()) {
-        FILE *out = GetOutputFILE();
-        if (out)
-          ::fprintf(out, "%u%s", m_base_line_number + (uint32_t)lines.GetSize(),
+        if (m_output_sp) {
+          m_output_sp->Printf("%u%s",
+                              m_base_line_number + (uint32_t)lines.GetSize(),
                               GetPrompt() == nullptr ? " " : "");
         }
+      }
 
       m_curr_line_idx = lines.GetSize();
 
       bool interrupted = false;
       if (GetLine(line, interrupted) && !interrupted) {
         lines.AppendString(line);
         done = m_delegate.IOHandlerIsInputComplete(*this, lines);
       } else {

lldb/source/Expression/REPL.cpp

if (code[0] == ':') {
             // Now set the default file and line to the REPL source file
             m_target.GetSourceManager().SetDefaultFileAndLine(
                 FileSpec(m_repl_source_path), new_default_line);
           }
           static_cast<IOHandlerEditline &>(io_handler)
               .SetBaseLineNumber(m_code.GetSize() + 1);
         }
         if (extra_line) {
-          fprintf(output_sp->GetFile().GetStream(), "\n");
+          output_sp->Printf("\n");
         }
       }
     }
 
     // Don't complain about the REPL process going away if we are in the
     // process of quitting.
     if (!did_quit && (!process_sp || !process_sp->IsAlive())) {
       error_sp->Printf(