Page MenuHomePhabricator

[llvm-objcopy][test] Clean up -B tests
ClosedPublic

Authored by MaskRay on Sep 17 2019, 11:24 PM.

Details

Summary

-B is ignored for GNU objcopy compatibility after D67215/r371914.

  • Delete mentions of -B from input-output-target.test - we have enough -B tests.
  • Merge binary-input-with-arch.test into binary-output-target.test.

Diff Detail

Repository
rL LLVM

Event Timeline

MaskRay created this revision.Sep 17 2019, 11:24 PM
Herald added a project: Restricted Project. · View Herald Transcript

To be clear though, we have a test ensuring that -B is ignored, correct?

To be clear though, we have a test ensuring that -B is ignored, correct?

Yes.

ELF/binary-input-and-output.test
21:## -B is ignored.
22:# RUN: llvm-objcopy -I binary -B i386:x86-64 -O binary %t.txt %t.5.txt

ELF/binary-input-error.test
3:## -B is ignored.
4:# RUN: llvm-objcopy -I binary -B xyz %t.txt %t.o

ELF/binary-output-target.test
77:## In GNU objcopy, e_machine is EM_NONE unless -B is specifid.
79:## We fill in the field regardless of -B.
rupprecht accepted this revision.Sep 24 2019, 2:42 PM
This revision is now accepted and ready to land.Sep 24 2019, 2:42 PM
This revision was automatically updated to reflect the committed changes.