We still attempt to highlight them as underlying types, but fallback to
the generic 'typedef' highlighting kind if the underlying type is too
complicated.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
- Build Status
Buildable 37916 Build 37915: arc lint + arc unit
Event Timeline
clang-tools-extra/clangd/SemanticHighlighting.cpp | ||
---|---|---|
530 | Not sure what the rules for the scope names are, happy to change if I'm doing it wrong |
clang-tools-extra/clangd/SemanticHighlighting.cpp | ||
---|---|---|
530 | I think the current name is fine, just checked the name for this type in vscode highlighting configs, but didn't find a particular name for this type (my guess is that regex-based highlighting is not able to catch this case). | |
clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp | ||
498–499 | nit: the comment is out-of-date with this patch. |
- Remove stale comment
clang-tools-extra/clangd/SemanticHighlighting.cpp | ||
---|---|---|
530 | Ack. Keeping as is, thanks for taking a look. |
clang-tools-extra/clangd/SemanticHighlighting.cpp | ||
---|---|---|
530 |
we don't support it yet, this is a feature request in https://github.com/clangd/clangd/issues/143.
Yes, we will fallback to the color for entity.name.type. |
Not sure what the rules for the scope names are, happy to change if I'm doing it wrong