This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC][XCOFF] Verify symbol table in xcoff object files. [NFC]
ClosedPublic

Authored by sfertile on Aug 29 2019, 7:27 AM.

Download Raw Diff

Details

Reviewers

jasonliu
xingxue
hubert.reinterpretcast
DiggerLin

Commits

rG74966aca3559: [PowerPC][XCOFF] Verify symbol table in xcoff object files. [NFC]
rL371237: [PowerPC][XCOFF] Verify symbol table in xcoff object files. [NFC]

Summary

Extend the common/local-common testing for object files to also verify the symbol table now that the needed functionality has landed in llvm-readobj.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

sfertile created this revision.Aug 29 2019, 7:27 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2019, 7:27 AM

Herald added subscribers: shchenz, jsji, MaskRay, nemanjai. · View Herald Transcript

jasonliu added inline comments.Aug 29 2019, 8:01 AM

llvm/test/CodeGen/PowerPC/aix-xcoff-common.ll
69	These Index could easily change when we add more functionality into XCOFF object writer. Do we care about making the test case more robust?

Herald added a subscriber: • wuzish. · View Herald TranscriptAug 29 2019, 8:01 AM

sfertile marked an inline comment as done.Sep 3 2019, 7:29 AM

sfertile added inline comments.

llvm/test/CodeGen/PowerPC/aix-xcoff-common.ll
69	What do you have in mind?

Used numeric substitution block for symbol table indexes.

sfertile marked an inline comment as done and an inline comment as not done.Sep 3 2019, 8:02 AM

sfertile added inline comments.

llvm/test/CodeGen/PowerPC/aix-xcoff-common.ll
69	Ok, I found the numeric substitution blocks in the Filecheck docs. I wasn't aware of that before, thanks.

LGTM.

This revision is now accepted and ready to land.Sep 3 2019, 2:54 PM

Closed by commit rL371237: [PowerPC][XCOFF] Verify symbol table in xcoff object files. [NFC] (authored by sfertile). · Explain WhySep 6 2019, 11:54 AM

This revision was automatically updated to reflect the committed changes.

sfertile marked an inline comment as not done.

Revision Contents

Path

Size

llvm/

test/

CodeGen/

PowerPC/

aix-xcoff-common.ll

148 lines

aix-xcoff-lcomm.ll

68 lines

Diff 218456

llvm/test/CodeGen/PowerPC/aix-xcoff-common.ll

	; RUN: llc -mtriple powerpc-ibm-aix-xcoff < %s \| FileCheck %s			; RUN: llc -mtriple powerpc-ibm-aix-xcoff < %s \| FileCheck %s

	; RUN: llc -mtriple powerpc-ibm-aix-xcoff -filetype=obj -o %t.o < %s			; RUN: llc -mtriple powerpc-ibm-aix-xcoff -filetype=obj -o %t.o < %s
	; RUN: llvm-readobj --section-headers --file-header %t.o \| \			; RUN: llvm-readobj --section-headers --file-header %t.o \| \
	; RUN: FileCheck --check-prefix=OBJ %s			; RUN: FileCheck --check-prefix=OBJ %s
				; RUN: llvm-readobj --syms %t.o \| FileCheck --check-prefix=SYMS %s

	; RUN: not llc -mtriple powerpc64-ibm-aix-xcoff -filetype=obj -o %t.o 2>&1 \			; RUN: not llc -mtriple powerpc64-ibm-aix-xcoff -filetype=obj -o %t.o 2>&1 \
	; RUN: < %s \| FileCheck --check-prefix=XCOFF64 %s			; RUN: < %s \| FileCheck --check-prefix=XCOFF64 %s

	; XCOFF64: LLVM ERROR: 64-bit XCOFF object files are not supported yet.			; XCOFF64: LLVM ERROR: 64-bit XCOFF object files are not supported yet.

	@a = common global i32 0, align 4			@a = common global i32 0, align 4
	@b = common global i64 0, align 8			@b = common global i64 0, align 8
	Show All 39 Lines
	; OBJ-NEXT: RawDataOffset: 0x0			; OBJ-NEXT: RawDataOffset: 0x0
	; OBJ-NEXT: RelocationPointer: 0x0			; OBJ-NEXT: RelocationPointer: 0x0
	; OBJ-NEXT: LineNumberPointer: 0x0			; OBJ-NEXT: LineNumberPointer: 0x0
	; OBJ-NEXT: NumberOfRelocations: 0			; OBJ-NEXT: NumberOfRelocations: 0
	; OBJ-NEXT: NumberOfLineNumbers: 0			; OBJ-NEXT: NumberOfLineNumbers: 0
	; OBJ-NEXT: Type: STYP_BSS (0x80)			; OBJ-NEXT: Type: STYP_BSS (0x80)
	; OBJ-NEXT: }			; OBJ-NEXT: }
	; OBJ-NEXT: ]			; OBJ-NEXT: ]

				; SYMS: File: {{.*}}aix-xcoff-common.ll.tmp.o
				; SYMS-NEXT: Format: aixcoff-rs6000
				; SYMS-NEXT: Arch: powerpc
				; SYMS-NEXT: AddressSize: 32bit
				; SYMS-NEXT: Symbols [
				; SYMS-NEXT: Symbol {
				; SYMS-NEXT: Index: [[#Index:]]
				jasonliuUnsubmitted Not Done Reply Inline Actions These Index could easily change when we add more functionality into XCOFF object writer. Do we care about making the test case more robust? jasonliu: These Index could easily change when we add more functionality into XCOFF object writer. Do we…
				sfertileAuthorUnsubmitted Not Done Reply Inline Actions What do you have in mind? sfertile: What do you have in mind?
				sfertileAuthorUnsubmitted Done Reply Inline Actions Ok, I found the numeric substitution blocks in the Filecheck docs. I wasn't aware of that before, thanks. sfertile: Ok, I found the numeric substitution blocks in the Filecheck docs. I wasn't aware of that…
				; SYMS-NEXT: Name: a
				; SYMS-NEXT: Value (RelocatableAddress): 0x0
				; SYMS-NEXT: Section: .bss
				; SYMS-NEXT: Type: 0x0
				; SYMS-NEXT: StorageClass: C_EXT (0x2)
				; SYMS-NEXT: NumberOfAuxEntries: 1
				; SYMS-NEXT: CSECT Auxiliary Entry {
				; SYMS-NEXT: Index: [[#Index + 1]]
				; SYMS-NEXT: SectionLen: 4
				; SYMS-NEXT: ParameterHashIndex: 0x0
				; SYMS-NEXT: TypeChkSectNum: 0x0
				; SYMS-NEXT: SymbolAlignmentLog2: 2
				; SYMS-NEXT: SymbolType: XTY_CM (0x3)
				; SYMS-NEXT: StorageMappingClass: XMC_RW (0x5)
				; SYMS-NEXT: StabInfoIndex: 0x0
				; SYMS-NEXT: StabSectNum: 0x0
				; SYMS-NEXT: }
				; SYMS-NEXT: }
				; SYMS-NEXT: Symbol {
				; SYMS-NEXT: Index: [[#Index + 2]]
				; SYMS-NEXT: Name: b
				; SYMS-NEXT: Value (RelocatableAddress): 0x8
				; SYMS-NEXT: Section: .bss
				; SYMS-NEXT: Type: 0x0
				; SYMS-NEXT: StorageClass: C_EXT (0x2)
				; SYMS-NEXT: NumberOfAuxEntries: 1
				; SYMS-NEXT: CSECT Auxiliary Entry {
				; SYMS-NEXT: Index: [[#Index + 3]]
				; SYMS-NEXT: SectionLen: 8
				; SYMS-NEXT: ParameterHashIndex: 0x0
				; SYMS-NEXT: TypeChkSectNum: 0x0
				; SYMS-NEXT: SymbolAlignmentLog2: 3
				; SYMS-NEXT: SymbolType: XTY_CM (0x3)
				; SYMS-NEXT: StorageMappingClass: XMC_RW (0x5)
				; SYMS-NEXT: StabInfoIndex: 0x0
				; SYMS-NEXT: StabSectNum: 0x0
				; SYMS-NEXT: }
				; SYMS-NEXT: }
				; SYMS-NEXT: Symbol {
				; SYMS-NEXT: Index: [[#Index + 4]]
				; SYMS-NEXT: Name: c
				; SYMS-NEXT: Value (RelocatableAddress): 0x10
				; SYMS-NEXT: Section: .bss
				; SYMS-NEXT: Type: 0x0
				; SYMS-NEXT: StorageClass: C_EXT (0x2)
				; SYMS-NEXT: NumberOfAuxEntries: 1
				; SYMS-NEXT: CSECT Auxiliary Entry {
				; SYMS-NEXT: Index: [[#Index + 5]]
				; SYMS-NEXT: SectionLen: 2
				; SYMS-NEXT: ParameterHashIndex: 0x0
				; SYMS-NEXT: TypeChkSectNum: 0x0
				; SYMS-NEXT: SymbolAlignmentLog2: 1
				; SYMS-NEXT: SymbolType: XTY_CM (0x3)
				; SYMS-NEXT: StorageMappingClass: XMC_RW (0x5)
				; SYMS-NEXT: StabInfoIndex: 0x0
				; SYMS-NEXT: StabSectNum: 0x0
				; SYMS-NEXT: }
				; SYMS-NEXT: }
				; SYMS-NEXT: Symbol {
				; SYMS-NEXT: Index: [[#Index + 6]]
				; SYMS-NEXT: Name: d
				; SYMS-NEXT: Value (RelocatableAddress): 0x18
				; SYMS-NEXT: Section: .bss
				; SYMS-NEXT: Type: 0x0
				; SYMS-NEXT: StorageClass: C_EXT (0x2)
				; SYMS-NEXT: NumberOfAuxEntries: 1
				; SYMS-NEXT: CSECT Auxiliary Entry {
				; SYMS-NEXT: Index: [[#Index + 7]]
				; SYMS-NEXT: SectionLen: 8
				; SYMS-NEXT: ParameterHashIndex: 0x0
				; SYMS-NEXT: TypeChkSectNum: 0x0
				; SYMS-NEXT: SymbolAlignmentLog2: 3
				; SYMS-NEXT: SymbolType: XTY_CM (0x3)
				; SYMS-NEXT: StorageMappingClass: XMC_RW (0x5)
				; SYMS-NEXT: StabInfoIndex: 0x0
				; SYMS-NEXT: StabSectNum: 0x0
				; SYMS-NEXT: }
				; SYMS-NEXT: }
				; SYMS-NEXT: Symbol {
				; SYMS-NEXT: Index: [[#Index + 8]]
				; SYMS-NEXT: Name: f
				; SYMS-NEXT: Value (RelocatableAddress): 0x20
				; SYMS-NEXT: Section: .bss
				; SYMS-NEXT: Type: 0x0
				; SYMS-NEXT: StorageClass: C_EXT (0x2)
				; SYMS-NEXT: NumberOfAuxEntries: 1
				; SYMS-NEXT: CSECT Auxiliary Entry {
				; SYMS-NEXT: Index: [[#Index + 9]]
				; SYMS-NEXT: SectionLen: 4
				; SYMS-NEXT: ParameterHashIndex: 0x0
				; SYMS-NEXT: TypeChkSectNum: 0x0
				; SYMS-NEXT: SymbolAlignmentLog2: 2
				; SYMS-NEXT: SymbolType: XTY_CM (0x3)
				; SYMS-NEXT: StorageMappingClass: XMC_RW (0x5)
				; SYMS-NEXT: StabInfoIndex: 0x0
				; SYMS-NEXT: StabSectNum: 0x0
				; SYMS-NEXT: }
				; SYMS-NEXT: }
				; SYMS-NEXT: Symbol {
				; SYMS-NEXT: Index: [[#Index + 10]]
				; SYMS-NEXT: Name: over_aligned
				; SYMS-NEXT: Value (RelocatableAddress): 0x40
				; SYMS-NEXT: Section: .bss
				; SYMS-NEXT: Type: 0x0
				; SYMS-NEXT: StorageClass: C_EXT (0x2)
				; SYMS-NEXT: NumberOfAuxEntries: 1
				; SYMS-NEXT: CSECT Auxiliary Entry {
				; SYMS-NEXT: Index: [[#Index + 11]]
				; SYMS-NEXT: SectionLen: 8
				; SYMS-NEXT: ParameterHashIndex: 0x0
				; SYMS-NEXT: TypeChkSectNum: 0x0
				; SYMS-NEXT: SymbolAlignmentLog2: 5
				; SYMS-NEXT: SymbolType: XTY_CM (0x3)
				; SYMS-NEXT: StorageMappingClass: XMC_RW (0x5)
				; SYMS-NEXT: StabInfoIndex: 0x0
				; SYMS-NEXT: StabSectNum: 0x0
				; SYMS-NEXT: }
				; SYMS-NEXT: }
				; SYMS-NEXT: Symbol {
				; SYMS-NEXT: Index: [[#Index + 12]]
				; SYMS-NEXT: Name: array
				; SYMS-NEXT: Value (RelocatableAddress): 0x48
				; SYMS-NEXT: Section: .bss
				; SYMS-NEXT: Type: 0x0
				; SYMS-NEXT: StorageClass: C_EXT (0x2)
				; SYMS-NEXT: NumberOfAuxEntries: 1
				; SYMS-NEXT: CSECT Auxiliary Entry {
				; SYMS-NEXT: Index: [[#Index + 13]]
				; SYMS-NEXT: SectionLen: 33
				; SYMS-NEXT: ParameterHashIndex: 0x0
				; SYMS-NEXT: TypeChkSectNum: 0x0
				; SYMS-NEXT: SymbolAlignmentLog2: 0
				; SYMS-NEXT: SymbolType: XTY_CM (0x3)
				; SYMS-NEXT: StorageMappingClass: XMC_RW (0x5)
				; SYMS-NEXT: StabInfoIndex: 0x0
				; SYMS-NEXT: StabSectNum: 0x0
				; SYMS-NEXT: }
				; SYMS-NEXT: }
				; SYMS-NEXT: ]

llvm/test/CodeGen/PowerPC/aix-xcoff-lcomm.ll

	; RUN: llc -mtriple powerpc-ibm-aix-xcoff < %s \| FileCheck %s			; RUN: llc -mtriple powerpc-ibm-aix-xcoff < %s \| FileCheck %s
	; RUN: llc -mtriple powerpc64-ibm-aix-xcoff < %s \| FileCheck %s			; RUN: llc -mtriple powerpc64-ibm-aix-xcoff < %s \| FileCheck %s

	; RUN: llc -mtriple powerpc-ibm-aix-xcoff -filetype=obj -o %t.o < %s			; RUN: llc -mtriple powerpc-ibm-aix-xcoff -filetype=obj -o %t.o < %s
	; RUN: llvm-readobj --section-headers --file-header %t.o \| \			; RUN: llvm-readobj --section-headers --file-header %t.o \| \
	; RUN: FileCheck --check-prefix=OBJ %s			; RUN: FileCheck --check-prefix=OBJ %s
				; RUN: llvm-readobj --syms %t.o \| FileCheck --check-prefix=SYMS %s

	; RUN: not llc -mtriple powerpc64-ibm-aix-xcoff -filetype=obj < %s 2>&1 \| \			; RUN: not llc -mtriple powerpc64-ibm-aix-xcoff -filetype=obj < %s 2>&1 \| \
	; RUN: FileCheck --check-prefix=OBJ64 %s			; RUN: FileCheck --check-prefix=OBJ64 %s
	; OBJ64: LLVM ERROR: 64-bit XCOFF object files are not supported yet.			; OBJ64: LLVM ERROR: 64-bit XCOFF object files are not supported yet.

	@a = internal global i32 0, align 4			@a = internal global i32 0, align 4
	@b = internal global i64 0, align 8			@b = internal global i64 0, align 8
	@c = internal global i16 0, align 2			@c = internal global i16 0, align 2
	Show All 25 Lines
	; OBJ-NEXT: RawDataOffset: 0x0			; OBJ-NEXT: RawDataOffset: 0x0
	; OBJ-NEXT: RelocationPointer: 0x0			; OBJ-NEXT: RelocationPointer: 0x0
	; OBJ-NEXT: LineNumberPointer: 0x0			; OBJ-NEXT: LineNumberPointer: 0x0
	; OBJ-NEXT: NumberOfRelocations: 0			; OBJ-NEXT: NumberOfRelocations: 0
	; OBJ-NEXT: NumberOfLineNumbers: 0			; OBJ-NEXT: NumberOfLineNumbers: 0
	; OBJ-NEXT: Type: STYP_BSS (0x80)			; OBJ-NEXT: Type: STYP_BSS (0x80)
	; OBJ-NEXT: }			; OBJ-NEXT: }
	; OBJ-NEXT: ]			; OBJ-NEXT: ]

				; SYMS: File: {{.*}}aix-xcoff-lcomm.ll.tmp.o
				; SYMS-NEXT: Format: aixcoff-rs6000
				; SYMS-NEXT: Arch: powerpc
				; SYMS-NEXT: AddressSize: 32bit
				; SYMS-NEXT: Symbols [
				; SYMS-NEXT: Symbol {
				; SYMS-NEXT: Index: [[#Index:]]
				; SYMS-NEXT: Name: a
				; SYMS-NEXT: Value (RelocatableAddress): 0x0
				; SYMS-NEXT: Section: .bss
				; SYMS-NEXT: Type: 0x0
				; SYMS-NEXT: StorageClass: C_HIDEXT (0x6B)
				; SYMS-NEXT: NumberOfAuxEntries: 1
				; SYMS-NEXT: CSECT Auxiliary Entry {
				; SYMS-NEXT: Index: [[#Index + 1]]
				; SYMS-NEXT: SectionLen: 4
				; SYMS-NEXT: ParameterHashIndex: 0x0
				; SYMS-NEXT: TypeChkSectNum: 0x0
				; SYMS-NEXT: SymbolAlignmentLog2: 2
				; SYMS-NEXT: SymbolType: XTY_CM (0x3)
				; SYMS-NEXT: StorageMappingClass: XMC_BS (0x9)
				; SYMS-NEXT: StabInfoIndex: 0x0
				; SYMS-NEXT: StabSectNum: 0x0
				; SYMS-NEXT: }
				; SYMS-NEXT: }
				; SYMS-NEXT: Symbol {
				; SYMS-NEXT: Index: [[#Index + 2]]
				; SYMS-NEXT: Name: b
				; SYMS-NEXT: Value (RelocatableAddress): 0x8
				; SYMS-NEXT: Section: .bss
				; SYMS-NEXT: Type: 0x0
				; SYMS-NEXT: StorageClass: C_HIDEXT (0x6B)
				; SYMS-NEXT: NumberOfAuxEntries: 1
				; SYMS-NEXT: CSECT Auxiliary Entry {
				; SYMS-NEXT: Index: [[#Index + 3]]
				; SYMS-NEXT: SectionLen: 8
				; SYMS-NEXT: ParameterHashIndex: 0x0
				; SYMS-NEXT: TypeChkSectNum: 0x0
				; SYMS-NEXT: SymbolAlignmentLog2: 3
				; SYMS-NEXT: SymbolType: XTY_CM (0x3)
				; SYMS-NEXT: StorageMappingClass: XMC_BS (0x9)
				; SYMS-NEXT: StabInfoIndex: 0x0
				; SYMS-NEXT: StabSectNum: 0x0
				; SYMS-NEXT: }
				; SYMS-NEXT: }
				; SYMS-NEXT: Symbol {
				; SYMS-NEXT: Index: [[#Index + 4]]
				; SYMS-NEXT: Name: c
				; SYMS-NEXT: Value (RelocatableAddress): 0x10
				; SYMS-NEXT: Section: .bss
				; SYMS-NEXT: Type: 0x0
				; SYMS-NEXT: StorageClass: C_HIDEXT (0x6B)
				; SYMS-NEXT: NumberOfAuxEntries: 1
				; SYMS-NEXT: CSECT Auxiliary Entry {
				; SYMS-NEXT: Index: [[#Index + 5]]
				; SYMS-NEXT: SectionLen: 2
				; SYMS-NEXT: ParameterHashIndex: 0x0
				; SYMS-NEXT: TypeChkSectNum: 0x0
				; SYMS-NEXT: SymbolAlignmentLog2: 1
				; SYMS-NEXT: SymbolType: XTY_CM (0x3)
				; SYMS-NEXT: StorageMappingClass: XMC_BS (0x9)
				; SYMS-NEXT: StabInfoIndex: 0x0
				; SYMS-NEXT: StabSectNum: 0x0
				; SYMS-NEXT: }
				; SYMS-NEXT: }
				; SYMS-NEXT: ]