Page MenuHomePhabricator

[ARM] Select vaddva
ClosedPublic

Authored by samtebbs on Aug 19 2019, 3:34 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

samtebbs created this revision.Aug 19 2019, 3:34 AM

Can you add some i64 tests, just to show that it does something without breaking.

samtebbs updated this revision to Diff 216138.Aug 20 2019, 7:01 AM
dmgreen accepted this revision.Aug 20 2019, 7:34 AM

LGTM, thanks.

Its sometimes hard to tell if these functions exactly match up to that they are replacing, with all the extends going on. I believe this one is OK, but make sure it's tested.

llvm/test/CodeGen/Thumb2/mve-vaddv.ll
38 ↗(On Diff #216138)

Can you add one for vaddv too, just before you commit?

This revision is now accepted and ready to land.Aug 20 2019, 7:34 AM
samtebbs marked an inline comment as done.Aug 20 2019, 7:46 AM
samtebbs added inline comments.
llvm/test/CodeGen/Thumb2/mve-vaddv.ll
38 ↗(On Diff #216138)

Yes, good spot.

Closed by commit rL369404: [ARM] Select vaddva (authored by samtebbs, committed by ). · Explain WhyAug 20 2019, 9:33 AM
This revision was automatically updated to reflect the committed changes.