Page MenuHomePhabricator

[Object] Add tapi files to object
ClosedPublic

Authored by cishida on Aug 13 2019, 1:04 PM.

Details

Summary

The intention for this is to allow reading and printing symbols out from
llvm-nm. Tapi file, and Tapi universal follow a similiar format to
their respective MachO Object format.

The tests are dependent on llvm-nm processing tbd files which is why its in D66160

Diff Detail

Event Timeline

cishida created this revision.Aug 13 2019, 1:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2019, 1:04 PM
cishida edited the summary of this revision. (Show Details)Aug 13 2019, 1:25 PM

We can discuss what is a good class name for TapiFile and TapiUniversal. It should be consistent with the other patch as well.

Also try to avoid clang-format the line you didn't modify.

ributzka accepted this revision.Aug 20 2019, 10:27 AM

LGTM, but we should also wait for Lang's feedback.

This revision is now accepted and ready to land.Aug 20 2019, 10:27 AM
lhames accepted this revision.Aug 20 2019, 10:46 AM

Looks good to me too. :)

This revision was automatically updated to reflect the committed changes.