Page MenuHomePhabricator

[TextAPI] Update reader to be supported by lib/Object

Authored by cishida on Aug 13 2019, 9:12 AM.



To be able to use the TextAPI/Reader for tbd file consumption (by libObject)
it gets passed a MemoryBufferRef which isn't castable to MemoryBuffer.
Updated the tests to expect that input as well.

Diff Detail


Event Timeline

cishida created this revision.Aug 13 2019, 9:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2019, 9:12 AM
cishida edited the summary of this revision. (Show Details)Aug 13 2019, 9:21 AM
steven_wu accepted this revision.Aug 13 2019, 1:26 PM


25 ↗(On Diff #214853)

What happened to this function? Is this declared and never implemented?

This revision is now accepted and ready to land.Aug 13 2019, 1:26 PM
cishida marked an inline comment as done.Aug 13 2019, 1:32 PM

I currently don't have commit access, so would anyone mind pushing this up to master?

25 ↗(On Diff #214853)

yep, never created an error because it was never called by anything

ributzka added inline comments.Aug 13 2019, 2:01 PM
638 ↗(On Diff #214853)

Why did this move? Won't that leak the memory in the error case?

cishida updated this revision to Diff 214968.Aug 13 2019, 4:18 PM

[TextAPI] prevent memory leak for Interface File

cishida marked an inline comment as done.Aug 13 2019, 4:19 PM
cishida added inline comments.
638 ↗(On Diff #214853)

resolved offline

This revision was automatically updated to reflect the committed changes.