Page MenuHomePhabricator

[Driver] Use enumeration for quoting mode. NFC
AcceptedPublic

Authored by smeenai on Aug 6 2019, 5:45 PM.

Details

Summary

Boolean parameters are generally hard to understand, especially when we
don't consistently have a comment for them. Change to an enumeration.

While I believe this change is worthwhile by itself, its main purpose is
to serve as cleanup for a follow-up which will add a third mode to this
enumeration, to allow verbatim printing of arguments (without any
quoting or escaping).

Event Timeline

smeenai created this revision.Aug 6 2019, 5:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 6 2019, 5:45 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
phosek accepted this revision.Aug 6 2019, 6:46 PM

LGTM

This revision is now accepted and ready to land.Aug 6 2019, 6:46 PM
rnk accepted this revision.Aug 7 2019, 2:34 PM

lgtm+2