Page MenuHomePhabricator

[CompilerType] Simplify the interface a bit more..
ClosedPublic

Authored by davide on Aug 5 2019, 4:31 PM.

Details

Summary

.. removing IsMeaninglessWithoutTypeResolution(). I'm fairly
confident this was introduced to support swift, where
static types [without dynamic counterpart] don't carry a lot
of value. Since then, the formatters and dynamic type resolution
has been rewritten, and we employ different solutions. This function
is unused here too, so let's get read of it.

rdar://problem/36377967

Diff Detail

Repository
rL LLVM

Event Timeline

davide created this revision.Aug 5 2019, 4:31 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2019, 4:31 PM
JDevlieghere accepted this revision.Aug 5 2019, 4:33 PM
This revision is now accepted and ready to land.Aug 5 2019, 4:33 PM
xiaobai accepted this revision.Aug 5 2019, 4:34 PM
alex added a comment.Aug 5 2019, 4:36 PM

I was marked as a review on this, but I suspect you intended to get some other Alex :-)

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2019, 5:02 PM
davide added a comment.Aug 5 2019, 5:07 PM

I was marked as a review on this, but I suspect you intended to get some other Alex :-)

yes, sorry. My bad.