Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
lib/CodeGen/CGOpenMPRuntime.cpp | ||
---|---|---|
7695 ↗ | (On Diff #211969) | Why? |
lib/CodeGen/CGOpenMPRuntime.cpp | ||
---|---|---|
7695 ↗ | (On Diff #211969) | If the pointee has been mapped as TO/FROM/etc already no need to map it TO/FROM/etc again. |
Comment Actions
There's already D55892 with a better set of tests, including target enter data / target exit data.
Comment Actions
How would you like me to proceed? It looks like the other patch has been sitting there approved for many many months.
Comment Actions
Yes, the patch has been waiting for the runtime implementation first and then commit.
Comment Actions
@Hahnfeld I have merged the tests from the previous patch as per Alexey's suggestion - with minor changes to make them pass. Let me know if this now addresses your previous comments.
lib/CodeGen/CGOpenMPRuntime.cpp | ||
---|---|---|
7695 ↗ | (On Diff #211969) | I'm not sure if there's a test for this. I can't verify right now, so I trust you that it's covered. |
lib/CodeGen/CGOpenMPRuntime.cpp | ||
---|---|---|
7695 ↗ | (On Diff #211969) | I added the test as per Alexey's previous request. |