Well, what is says on the tin I guess!
Some more changes:
- Move isInevitablySinking() from BugReporter.cpp to CFGBlock's interface
- Rename and move findBlockForNode() from BugReporter.cpp to ExplodedNode::getCFGBlock()
- Add some testcases, but are these assert implementations esoteric enough?
I think the depth-first manner is an implementation detail and the result of this method should not depend on the traversal strategy. I would remove that part from the comment.