Details
Details
- Reviewers
nhaehnle
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Mostly seems reasonable to me, but two questions inline.
lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp | ||
---|---|---|
745–755 | Could we rearrange these to have a signature analogous to parseCachePolicy, to sanity-check that no bits in CachePolicy are set unexpectedly? | |
lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp | ||
1600–1611 | What's the intention here? |
Comment Actions
I don't have that hash. I do have 67f1f6ff8c07b5eef7239679a6b534efe933ceaa though, which is quite old indeed. Either way, it's fine.
Could we rearrange these to have a signature analogous to parseCachePolicy, to sanity-check that no bits in CachePolicy are set unexpectedly?