Page MenuHomePhabricator

AMDGPU/GlobalISel: Select llvm.amdgcn.raw.buffer.store
ClosedPublic

Authored by arsenm on Jul 24 2019, 11:49 AM.

Details

Reviewers
nhaehnle

Diff Detail

Event Timeline

arsenm created this revision.Jul 24 2019, 11:49 AM

Mostly seems reasonable to me, but two questions inline.

lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
745–755

Could we rearrange these to have a signature analogous to parseCachePolicy, to sanity-check that no bits in CachePolicy are set unexpectedly?

lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
1600–1611

What's the intention here?

arsenm marked 2 inline comments as done.Aug 5 2019, 7:12 AM
arsenm added inline comments.
lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
745–755

I think that's a lot uglier. That kind of check belongs in the verifier

lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
1600–1611

This is leftover junk from when I thought it was a good idea to select this here

arsenm updated this revision to Diff 213357.Aug 5 2019, 7:13 AM

Remove leftover junk

This revision is now accepted and ready to land.Jan 22 2020, 2:43 AM
arsenm closed this revision.Jan 27 2020, 12:08 PM

Slightly confused, but I think this was ca2672accec386bd80804db659b5f06674ebd5be?

Slightly confused, but I think this was ca2672accec386bd80804db659b5f06674ebd5be?

I don't have that hash. I do have 67f1f6ff8c07b5eef7239679a6b534efe933ceaa though, which is quite old indeed. Either way, it's fine.