Differential D64877

AMDGPU/GlobalISel: Attempt to RegBankSelect image intrinsics
ClosedPublic
Actions

Authored by arsenm on Jul 17 2019, 12:04 PM.

Tags

None

Subscribers

kzhuravl, jvesely, wdng and 7 others

Details

Reviewers

nhaehnle
tstellar

Summary

Images should always have 2 consecutive, mandatory SGPR arguments.

Diff Detail

Event Timeline

arsenm created this revision.Jul 17 2019, 12:04 PM

Herald added subscribers: Petar.Avramovic, t-tye, tpr and 6 others. · View Herald TranscriptJul 17 2019, 12:04 PM

arsenm added a parent revision: D58232: GlobalISel: Don't materialize immarg arguments to intrinsics.Jul 17 2019, 12:04 PM

LGTM.

This revision is now accepted and ready to land.Jul 17 2019, 1:53 PM

r372289

Revision Contents
Changeset List

			Path	Packages
M			lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp (2 lines)
M			lib/Target/AMDGPU/AMDGPURegisterBankInfo.h (11 lines)
M			lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp (101 lines)
A	M		test/CodeGen/AMDGPU/GlobalISel/regbankselect-amdgcn.image.load.1d.ll (181 lines)
A	M		test/CodeGen/AMDGPU/GlobalISel/regbankselect-amdgcn.image.sample.1d.ll (268 lines)

Diff 210387

lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp

Loading...

lib/Target/AMDGPU/AMDGPURegisterBankInfo.h

Loading...

lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp

Loading...

test/CodeGen/AMDGPU/GlobalISel/regbankselect-amdgcn.image.load.1d.ll

Loading...

test/CodeGen/AMDGPU/GlobalISel/regbankselect-amdgcn.image.sample.1d.ll

Loading...