Page MenuHomePhabricator

[NFC][PowerPC]Change ADDIStocHA to ADDIStocHA8 to follow 64-bit naming convention
ClosedPublic

Authored by Xiangling_L on Jul 16 2019, 11:59 AM.

Details

Summary

Since we are planning to add ADDIStocHA for 32bit in later patch, we decided to change 64bit one first to follow naming convention with 8 behind opcode.

Diff Detail

Repository
rL LLVM

Event Timeline

Xiangling_L created this revision.Jul 16 2019, 11:59 AM
jsji added a comment.Jul 16 2019, 1:13 PM

Please also remember to add [PowerPC] to title for all powerpc related patches. Thanks.

Should also update one comments .
lib/Target/PowerPC/PPCISelLowering.cpp:14316: // is that for large code model we have ADDISTocHa + LDtocL and for

llvm/lib/Target/PowerPC/P9InstrResources.td
151 ↗(On Diff #210145)

Do we have plan to add ADDItocL8 as well?
Why not use (8)? so that we don't need to update this again for ADDItocL8 ?

sfertile added inline comments.Jul 16 2019, 2:11 PM
llvm/lib/Target/PowerPC/P9InstrResources.td
151 ↗(On Diff #210145)

Do we have plan to add ADDItocL8 as well?

Not in the near term, although from what I understand of AIX we will need to add one if we add an option similar to XL's -qtocdata for 32-bit code.

Why not use (8)? so that we don't need to update this again for ADDItocL8 ?

I think this is a good suggestion

Xiangling_L marked an inline comment as done.
Xiangling_L retitled this revision from [NFC]Change ADDIStocHA to ADDIStocHA8 to follow 64-bit naming convention to [NFC][PowerPC]Change ADDIStocHA to ADDIStocHA8 to follow 64-bit naming convention.

use (8)? + update a comment

llvm/lib/Target/PowerPC/P9InstrResources.td
151 ↗(On Diff #210145)

Thank you for your suggestion, I will update it to use (8)?. And we haven't spot any place where ADDItocL is needed on AIX since AIX is always toc-referenced. So I guess probably we don't need to update it for now.

minor change

Xiangling_L marked 2 inline comments as done.Jul 17 2019, 6:56 AM
sfertile accepted this revision.Mon, Jul 22, 8:02 AM

LGTM.

This revision is now accepted and ready to land.Mon, Jul 22, 8:02 AM
jsji accepted this revision.Mon, Jul 22, 8:36 AM

LGTM, sorry for late response.

This revision was automatically updated to reflect the committed changes.