Page MenuHomePhabricator

Fix llvm.aarch64.irg properties.
ClosedPublic

Authored by eugenis on Jul 9 2019, 2:32 PM.

Details

Summary

IRG does not access any memory.
Replace IntrInaccessibleMemOnly with IntrNoMem | IntrHasSideEffects.

Event Timeline

eugenis created this revision.Jul 9 2019, 2:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2019, 2:32 PM

TBH I have no idea how to test this.

chill added a comment.Jul 10 2019, 2:50 AM

I suggested this change here: https://reviews.llvm.org/D60486#inline-574695
But I've got the feeling (from https://reviews.llvm.org/D64414) it a subject for a debate.

TBH I have no idea how to test this.

Is there a builtin that lowers to this, e.g., we test it by lowering C -> IR -> asm, and we can check the properties/attributes on the lower levels.
If not, we could probably start at the IR level, lower to asm, and check the final properties.

eugenis updated this revision to Diff 210473.Jul 17 2019, 6:17 PM

added a test

This revision is now accepted and ready to land.Aug 1 2019, 4:41 PM
This revision was automatically updated to reflect the committed changes.