This is an archive of the discontinued LLVM Phabricator instance.

[ARM][AArch64] Cortex-A65AE, Neoverse E1 and Neoverse N1 support
ClosedPublic

Authored by pbarrio on Jul 9 2019, 5:30 AM.

Event Timeline

pbarrio created this revision.Jul 9 2019, 5:30 AM
ostannard added inline comments.
llvm/include/llvm/Support/AArch64TargetParser.def
95

Why are you just adding cortex-a65ae, and not cortex-a65? Is that coming in a later patch?

96

I think all three of these cores should have AEK_RCPC, AEK_SSBS and AEK_RAS.

llvm/lib/Target/AArch64/AArch64.td
497

I think all three of these should also have FeatureSSBS.

pbarrio updated this revision to Diff 210506.Jul 18 2019, 2:40 AM

Add Cortex-A65 and a few features that were missed in the first patch. I think all the features should be in now.

pbarrio marked 3 inline comments as done.Jul 18 2019, 2:41 AM
ostannard added inline comments.Jul 18 2019, 8:06 AM
llvm/lib/Target/AArch64/AArch64.td
681

These two also need FeatureSSBS.

pbarrio updated this revision to Diff 210853.Jul 19 2019, 9:30 AM

Oooops sorry, not sure how I missed that. I've added SSBS to all the CPUs now.

This revision is now accepted and ready to land.Jul 22 2019, 1:20 AM
pbarrio marked an inline comment as done.Jul 25 2019, 3:34 AM
This revision was automatically updated to reflect the committed changes.