This is an archive of the discontinued LLVM Phabricator instance.

Differential D64399

[CMake] Distribution builds for LLDB standalone
ClosedPublic

Authored by sgraenitz on Jul 9 2019, 4:23 AM.

Details

Reviewers
xiaobai
mgorny
JDevlieghere
davide
compnerd
Commits
rG05adc0f3170e: [CMake] Distribution builds for LLDB standalone
rLLDB365616: [CMake] Distribution builds for LLDB standalone
rL365616: [CMake] Distribution builds for LLDB standalone
Summary

Enable distribution and install-distribution targets in LLDB standalone and pre-populate the cache accordingly on macOS.
Documentation for distribution builds is here: https://llvm.org/docs/BuildingADistribution.html

Diff Detail

Event Timeline

sgraenitz created this revision.Jul 9 2019, 4:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2019, 4:23 AM
Harbormaster completed remote builds in B34580: Diff 208636.Jul 9 2019, 4:27 AM
sgraenitz mentioned this in D64397: [CMake] Remove extra lldb-framework target.Jul 9 2019, 4:28 AM
sgraenitz edited the summary of this revision. (Show Details)Jul 9 2019, 5:02 AM
sgraenitz added a reviewer: compnerd.
sgraenitz mentioned this in D64408: [CMake] `install-distribution` for LLDB on Darwin.Jul 9 2019, 5:58 AM
sgraenitz updated this revision to Diff 208695.Jul 9 2019, 8:25 AM

Add include(LLVMDistributionSupport) which went into the wrong patch

Harbormaster completed remote builds in B34602: Diff 208695.Jul 9 2019, 8:26 AM
JDevlieghere accepted this revision.Jul 9 2019, 8:58 AM

LGTM

This revision is now accepted and ready to land.Jul 9 2019, 8:58 AM
xiaobai accepted this revision.Jul 9 2019, 10:46 AM
Closed by commit rL365616: [CMake] Distribution builds for LLDB standalone (authored by stefan.graenitz). · Explain WhyJul 10 2019, 4:09 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2019, 4:09 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Diffusion mentioned this in rL365617: [CMake] `install-distribution` for LLDB on Darwin.Jul 10 2019, 4:10 AM
sgraenitz mentioned this in rG110f97632e11: [CMake] `install-distribution` for LLDB on Darwin.Jul 10 2019, 4:12 AM

Revision Contents

PathSize
lldb/
4 lines
cmake/
caches/
10 lines

Diff 208636

lldb/CMakeLists.txt

Show First 20 Lines • Show All 214 Lines • ▼ Show 20 Lines if (WIN32 AND NOT "${PYTHON_DLL}" STREQUAL "")
file(TO_NATIVE_PATH "${PYTHON_DLL}" PYTHON_DLL_NATIVE_PATH) file(TO_NATIVE_PATH "${PYTHON_DLL}" PYTHON_DLL_NATIVE_PATH)
add_custom_command( add_custom_command(
TARGET finish_swig TARGET finish_swig
POST_BUILD POST_BUILD
COMMAND ${CMAKE_COMMAND} -E copy ${PYTHON_DLL_NATIVE_PATH} ${LLDB_BIN_DIR} VERBATIM COMMAND ${CMAKE_COMMAND} -E copy ${PYTHON_DLL_NATIVE_PATH} ${LLDB_BIN_DIR} VERBATIM
COMMENT "Copying Python DLL to LLDB binaries directory.") COMMENT "Copying Python DLL to LLDB binaries directory.")
endif () endif ()
endif () endif ()
if(LLDB_BUILT_STANDALONE)
llvm_distribution_add_targets()
endif()

lldb/cmake/caches/Apple-lldb-macOS.cmake

Show All 9 Lines
# Choose the install location for LLDB.framework so that it matches the # Choose the install location for LLDB.framework so that it matches the
# INSTALL_RPATH of the lldb driver. It's either absolute or relative to # INSTALL_RPATH of the lldb driver. It's either absolute or relative to
# CMAKE_INSTALL_PREFIX. In any case, DESTDIR will be an extra prefix. # CMAKE_INSTALL_PREFIX. In any case, DESTDIR will be an extra prefix.
set(LLDB_FRAMEWORK_INSTALL_DIR /Applications/Xcode.app/Contents/SharedFrameworks CACHE STRING "") set(LLDB_FRAMEWORK_INSTALL_DIR /Applications/Xcode.app/Contents/SharedFrameworks CACHE STRING "")
# Release builds may change these: # Release builds may change these:
set(CMAKE_OSX_DEPLOYMENT_TARGET 10.11 CACHE STRING "") set(CMAKE_OSX_DEPLOYMENT_TARGET 10.11 CACHE STRING "")
set(LLDB_USE_SYSTEM_DEBUGSERVER ON CACHE BOOL "") set(LLDB_USE_SYSTEM_DEBUGSERVER OFF CACHE BOOL "")
set(LLVM_EXTERNALIZE_DEBUGINFO OFF CACHE BOOL "") set(LLVM_EXTERNALIZE_DEBUGINFO OFF CACHE BOOL "")
set(LLVM_DISTRIBUTION_COMPONENTS
lldb
liblldb
lldb-argdumper
darwin-debug
debugserver
CACHE STRING "")