Page MenuHomePhabricator

[CMake] Remove extra lldb-framework target
ClosedPublic

Authored by sgraenitz on Jul 9 2019, 3:58 AM.

Details

Summary

The custom lldb-framework target was meant to encapsulate all build steps that LLDB.framework needs on top of the ordinaly liblldb. In the end all of it happens in post-build steps, so we can do the same with liblldb and cut down another source of confusion.

Diff Detail

Repository
rL LLVM

Event Timeline

sgraenitz created this revision.Jul 9 2019, 3:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 9 2019, 3:58 AM
Herald added a subscriber: mgorny. · View Herald Transcript

This simplifies my proposal in D64399, because I don't need it in LLVM_DISTRIBUTION_COMPONENTS and avoid dummy install-distribution and install-distribution-stripped targets.

xiaobai accepted this revision.Jul 9 2019, 10:51 AM

Thanks for cleaning this up!

This revision is now accepted and ready to land.Jul 9 2019, 10:51 AM
JDevlieghere accepted this revision.Jul 9 2019, 11:36 AM
Closed by commit rL365615: [CMake] Remove extra lldb-framework target (authored by stefan.graenitz, committed by ). · Explain WhyJul 10 2019, 4:09 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2019, 4:09 AM