This is an archive of the discontinued LLVM Phabricator instance.

GodeGen, NFC: Add test to track emitStoresForConstant behavior
ClosedPublic

Authored by vitalybuka on Jul 8 2019, 9:27 PM.

Event Timeline

vitalybuka created this revision.Jul 8 2019, 9:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 8 2019, 9:27 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
vitalybuka retitled this revision from GodeGen: Add test to track emitStoresForConstant behavior to GodeGen, NFC: Add test to track emitStoresForConstant behavior.
eugenis accepted this revision.Jul 10 2019, 2:13 PM

LGTM

clang/test/CodeGen/init-memset.c
36

Would it be useful to check the range of the memset? I.e. does it overlap with the following store or not.

This revision is now accepted and ready to land.Jul 10 2019, 2:13 PM
vitalybuka marked an inline comment as done.Jul 10 2019, 3:34 PM
vitalybuka added inline comments.
clang/test/CodeGen/init-memset.c
36

I don't change ranges to it will only complicate tests

This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2019, 3:47 PM